From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1805EC43381 for ; Tue, 19 Feb 2019 12:20:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD44C217D7 for ; Tue, 19 Feb 2019 12:20:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d1FsG8wi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bmnf+N+C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD44C217D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KbtdRZwP0fGx2HomuafVWiktmHE/L9GQxyB2iCkbkRU=; b=d1FsG8witsgUrJ Jz9ji9/onkML/a34muCyzEc8onCt+9L7GHhocLnP3xeGFN0FgAYvRSWBgAmJxpMlcU4xkb9xJsULI KqlpkF6jFHr8UiJ6hKYnk8BRpJflCyP0SblG7azFDOG8SseFzziCgY7q0x3uegNtUlt2kLVyed6zo W700k1gN++if97tY8MTerb85FAtsgpHlnTteeq7DqfOaMtI0wm3ODDjfiR+qWg4QFT6TjDD4QTA6x +r+61ZrhEKbIzCqjMN5zo9OplzNtdL4xBfPVDBkEw42bsIDYuBaj85ndzgsbM7JF3nHB465ZfzfnM peXyIR0fsyHtjAUkt3IA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gw4O8-0006Fn-R5; Tue, 19 Feb 2019 12:20:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gw4O5-0006FQ-N9 for linux-arm-kernel@lists.infradead.org; Tue, 19 Feb 2019 12:20:39 +0000 Received: from localhost (unknown [106.200.226.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D238217D7; Tue, 19 Feb 2019 12:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550578837; bh=36FC+JnFT1126d6LGkSQevFrJ78somWW99q4F4lSsCw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Bmnf+N+CPPdO9GKQApbN/GKlEq7bjDQ9bSOSPyVwZpzULrQPFanI94SRqDiyq0Tdn JcPOLLauzJn/nmQ6b1D2aUlonZJbHqaQ51JQzDNjFc1GEe9fXjrNTiNgZwRpEBWcN5 dxQ8XMYhGQQalBIu9iznA9ZeuWyvLIVPJ3R4bdPQ= Date: Tue, 19 Feb 2019 17:50:27 +0530 From: Vinod Koul To: Baolin Wang Subject: Re: [PATCH 1/3] dt-bindings: dmaengine: Add one new cell to present hardware slave id Message-ID: <20190219122027.GA21884@vkoul-mobl> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190219_042037_785347_BD34B11C X-CRM114-Status: GOOD ( 33.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DTML , eric.long@unisoc.com, arm-soc , Arnd Bergmann , Lyra Zhang , Mark Brown , Linux Kernel Mailing List , dmaengine@vger.kernel.org, Rob Herring , Geert Uytterhoeven , Olof Johansson , Orson Zhai , Dan Williams , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19-02-19, 17:49, Baolin Wang wrote: > Hi Geert, > > On Tue, 19 Feb 2019 at 17:30, Geert Uytterhoeven wrote: > > > > Hi Baolin, > > > > On Tue, Feb 19, 2019 at 4:15 AM Baolin Wang wrote: > > > On Mon, 18 Feb 2019 at 20:23, Arnd Bergmann wrote: > > > > On Mon, Feb 18, 2019 at 11:52 AM Baolin Wang wrote: > > > > > On Mon, 18 Feb 2019 at 18:31, Arnd Bergmann wrote: > > > > > > > > > > > > On Tue, Feb 12, 2019 at 9:25 AM Baolin Wang wrote: > > > > > > > On Fri, 1 Feb 2019 at 19:53, Baolin Wang wrote: > > > > > > > > On Thu, 31 Jan 2019 at 00:52, Arnd Bergmann wrote: > > > > > > > > > On Tue, Jan 22, 2019 at 2:21 PM Baolin Wang wrote: > > > > > > > > > > > > > > > > > > > > Client: > > > > > > > > > > DMA clients connected to the Spreadtrum DMA controller must use the format > > > > > > > > > > -described in the dma.txt file, using a two-cell specifier for each channel. > > > > > > > > > > -The two cells in order are: > > > > > > > > > > +described in the dma.txt file, using a three-cell specifier for each channel. > > > > > > > > > > +The three cells in order are: > > > > > > > > > > 1. A phandle pointing to the DMA controller. > > > > > > > > > > 2. The channel id. > > > > > > > > > > +3. The hardware slave id which is used for clients to trigger DMA engine > > > > > > > > > > +automatically. > > > > > > > > > > > > > > > > > > I notice that this is an incompatible binding change. Is that necessary? > > > > > > > > > If the current code works, I'd suggest allowing both #dma-cells=<2> > > > > > > > > > and <3>, and then implementing both in the driver. > > > > > > > > > > > > > > > > Yes, this is necessary. > > > > > > > > > > > > > > > > Yes, current code can work, but the problem is that the DMA clients > > > > > > > > must add one property (something like "sprd,slave-id") to specify the > > > > > > > > slave id. So considering this, we want to change the dma-cells to 2, > > > > > > > > including dma channel and dma slave id, which can avoid introducing > > > > > > > > some similar properties for DMA clients. > > > > > > > > > > > > > > > > Now there are no DMA clients in mainline for Spreadtrum platform, and > > > > > > > > we want to upstream our first DMA clients: SPI controller. So no other > > > > > > > > drivers need to change when we changing dma cells. Thanks. > > > > > > > > > > > > > > Do you have any other concerns about this patch set? If not, I think > > > > > > > Vinod can apply this patch set. Thanks. > > > > > > > > > > > > Sorry for the late reply. Yes, this makes sense since there are no > > > > > > existing users then. For the DT changes going through the dmaengine > > > > > > tree > > > > > > > > > > > > Acked-by: Arnd Bergmann > > > > > > > > > > Thanks for your reviewing. > > > > > > > > > > > > > > > > > One more question, to make sure we don't need to edit it again: > > > > > > Why do you need both a 'channel id' and a 'slave id' here? Is this > > > > > > a strict hardware requirement for your DMA engine? In many > > > > > > other designs, only a DMA request line number needs to > > > > > > be described, and I think this would correspond to what you > > > > > > call the 'hardware slave id' in your documentation. > > > > > > > > > > I try to explain why we need the slave id. > > > > > > > > > > For our DMA engine driver, we have software request mode and hardware > > > > > request mode. For software request mode, the DMA engine driver need > > > > > trigger DMA to start transfer manually. But for hardware request mode, > > > > > we just set one unique slave id corresponding to the slave hardware to > > > > > the DMA engine, then the slave hardware can trigger DMA automatically. > > > > > And the slave id is not always same with the channel id according to > > > > > the SoC design, so we add one cell to specify the slave id. > > > > > > > > I did understand the need for a slave-id, I was instead wondering about > > > > the channel-id number. On many SoCs, all channels are equal, and you > > > > just have to pick one of those with the right capabilities for a particular > > > > slave. > > > > > > Yes, all channels are equal. We just set a unique slave id for the > > > channel for a particular slave. For example, the SPI slave can use > > > channel 10 for tx transfer by setting slave id 11, or it also can use > > > channel 9 for tx transfer by setting same slave id 11. > > > > So the channel selection is software policy, not hardware description, and > > thus doesn't belong in DT? > > > > Can't the DMA engine driver allocate channels dynamically, removing the > > need to specify this in DT? > > In theory we can do as you suggested. But we still want to > manage/assign the DMA channel resources manually for one SoC, we can > make sure some important DMA slaves (such as audio) can request a DMA > channel at runtime firstly, another benefit is that it is easy to > debug since we can easily know which channel is assigned for this > slave. Are you suggesting that you have more users than channels available? I dont think it is hard to debug if channels are dynamic in nature (for example we can print channel number and you know which one are you talking about, fwiw i have worked on a such a system where we grabbed the free channel) -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel