From: Maxime Ripard <maxime.ripard@bootlin.com>
To: "Jonathan A. Kollasch" <jakllsch@kollasch.net>
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm64: dts: allwinner: fix status LED on nanopi-neo-plus2
Date: Wed, 20 Feb 2019 17:53:21 +0100 [thread overview]
Message-ID: <20190220165321.24eer575gjxi3pdx@flea> (raw)
In-Reply-To: <20190220153303.32081-1-jakllsch@kollasch.net>
Hi!
A few generic comments before, you should send the patches to all the
recipients in get_maintainers.pl, which means that in that case in
particular, you forgot to send it to Chen-Yu Tsai.
Also, when you're sending a new iteration, please provide the changes
you made since the previous iteration after the ---.
On Wed, Feb 20, 2019 at 09:33:03AM -0600, Jonathan A. Kollasch wrote:
> The schematics[1][2] for both versions of the NanoPi NEO Plus2 place the
> STAT status LED on GPIOA10, and describe it as being a blue LED.
>
> This change makes the blue status LED on my v1.0 board functional.
>
> Signed-off-by: Jonathan A. Kollasch <jakllsch@kollasch.net>
>
> [1]: http://wiki.friendlyarm.com/wiki/images/8/86/Schematic_NanoPi_NEO_Plus2-v1.0-1704.pdf
> [2]: http://wiki.friendlyarm.com/wiki/images/b/bf/Schematic_NanoPi_NEO_Plus2-v1.1-1805.pdf
URLs also have the tendency to become dead quite fast, while the git
history is here for ever, so it'd be better to avoid having them in
the commit message itself, but feel free to add them as reference
after the ---
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-02-20 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 13:26 [PATCH] dts: fix status gpioleds on nanopi-neo-plus2 Jonathan A. Kollasch
2018-07-05 14:50 ` Maxime Ripard
2019-02-20 15:33 ` [PATCH v2] arm64: dts: allwinner: fix status LED " Jonathan A. Kollasch
2019-02-20 16:53 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220165321.24eer575gjxi3pdx@flea \
--to=maxime.ripard@bootlin.com \
--cc=jakllsch@kollasch.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox