From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BA93C43381 for ; Thu, 21 Feb 2019 11:14:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD0F82084F for ; Thu, 21 Feb 2019 11:14:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bL+7fOhQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ufh6WSip" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD0F82084F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1DypR+OmJAVQO73KxGbLkQyDtsYkPZLQTurG9pjbRFs=; b=bL+7fOhQUigJiH w2XFW0BrhJ0adjv/9xEK/R17ZyFjuYvJwdpr6SzTdlbx/PD9HPACFL3nEzFQ7E9xcvwmIBOnd6blv Fyyepchq3Eu6AvmvbsLyErisfpi8Ok8k/SKjlITWBsqxpR13VMXQkcxoqpV5FQ0LpVFCM/dPM81fE E0eZV5FaLbSUI2a04vz7bM6U1pOaHf4AEkkUpCH6vuHBEQY0WVwJdzuSvjq91Igw2FsnjnHU0tt3s LvsJEVDhOai5e3Rm6T2X2ySPx0/cdnVIJBwBSK07Yi26spA93oW4ZJx7UjDMyi8BaDmql50DTnOjL KoHyoKAPJ+1gQLG5jumQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwmJS-0002mt-MY; Thu, 21 Feb 2019 11:14:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwmJQ-0002mW-0a; Thu, 21 Feb 2019 11:14:45 +0000 Received: from localhost (unknown [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4A2862084F; Thu, 21 Feb 2019 11:14:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550747683; bh=iSxXfZoLOysfKcCozEmie9SwX3ZktmKo9HSy0fUFQDQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ufh6WSipYdYZdXuBWUy8RiNW1+l7hosZ9ZTdxfM98EJr8GHQl6+vgXj3pr6gyKnv/ Js3Jw2g1F9Z8OGSPh29gCvasMo45uRIgf1snSAInVo0Bly3FVVUyDoditgRAT8LHkr EEOCqvG/cqWEkTl7ggG0L5jdkZVjqUDADOuPxE5w= Date: Thu, 21 Feb 2019 12:14:37 +0100 From: Boris Brezillon To: Miquel Raynal Subject: Re: [RFC PATCH 02/27] mtd: nand: Compile in the NAND core by default Message-ID: <20190221121437.7c551bc5@kernel.org> In-Reply-To: <20190221120610.5abb49ae@xps13> References: <20190221100216.25255-1-miquel.raynal@bootlin.com> <20190221100216.25255-3-miquel.raynal@bootlin.com> <20190221115554.315fbd9b@kernel.org> <20190221120610.5abb49ae@xps13> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190221_031444_091275_A57D6E59 X-CRM114-Status: GOOD ( 22.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mason Yang , Vignesh R , Tudor Ambarus , Julien Su , Richard Weinberger , Schrempf Frieder , Marek Vasut , linux-mtd@lists.infradead.org, Thomas Petazzoni , Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 21 Feb 2019 12:06:10 +0100 Miquel Raynal wrote: > Hi Boris, > > Boris Brezillon wrote on Thu, 21 Feb 2019 > 11:55:54 +0100: > > > On Thu, 21 Feb 2019 11:01:51 +0100 > > Miquel Raynal wrote: > > > > > Force the NAND core be compiled-in when using any kind of NAND. > > > > Why? > > Because all the logic that comes later in the series relies on this > change. I need the NAND core to be compiled-in, Hm, not exactly compiled-in as it can still be selected as a module. > as well the ECC engine > core, as well as everything that is shared between raw NAND and > SPI-NAND which I move in the NAND core. Yes, the core is required for SPI NAND and soon will be for RAW NAND, but I still don't see the problem with the "select NAND_CORE" approach, sorry. > > > > > > > > > Also remove the redundant dependencies on MTD which is enforced by the > > > game of the if/endif blocs. > > > > > > Signed-off-by: Miquel Raynal > > > --- > > > drivers/mtd/nand/Kconfig | 12 ++++++++++-- > > > drivers/mtd/nand/onenand/Kconfig | 1 - > > > drivers/mtd/nand/raw/Kconfig | 1 - > > > drivers/mtd/nand/spi/Kconfig | 1 - > > > 4 files changed, 10 insertions(+), 5 deletions(-) > > > > > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > > > index 495751ed3fd7..e8d26a715922 100644 > > > --- a/drivers/mtd/nand/Kconfig > > > +++ b/drivers/mtd/nand/Kconfig > > > @@ -1,6 +1,14 @@ > > > -config MTD_NAND_CORE > > > - tristate > > > +menuconfig MTD_NAND_CORE > > > + tristate "NAND" > > > > Definitely not something we want to expose in menuconfig. > > I considered the NAND core as essential when using raw NAND and > SPI-NAND. It is needed for SPI NAND, and will be for raw NAND for sure, but I still see no reasons for turning it into a user-visible option. > Hence, turning it into a menuconfig option make the whole > NAND subsystem available (or not) and will appear in a different > "menuconfig page", which really enhances the readability. That's a different thing, and I have no problem with adding an extra level in the Kconfig hierarchy. > > > > > > + default y > > > > I don't see what's the problem with letting SPINAND, RAWNAND and > > ONENAND select this options if they actually need it. > > See the reason above, hence having it "default y" is needed to do not > break existing defconfigs. Not if you make RAW_NAND select NAND_CORE. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel