From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FABCC43381 for ; Thu, 28 Feb 2019 07:38:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09FD5205C9 for ; Thu, 28 Feb 2019 07:38:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jl0Hh476"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ch+mj6lM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09FD5205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=js0f4x01LwqEOB33Y7m9v8MiDV5ZwNJVS6b8odhGZCU=; b=jl0Hh476mx211X exy2wmojlpWYpeK1yHZFc8Wq0rtdP+W0ZFEuyTwMMlI+FFHVQ+ThHJAU25dqZ02LjQg7/w3YMWRKW qBxDboQv4XQg7yBlxp/iftRyBgXebPYLscZBLlIjQbycQ32CSSWaRVPCDpupgpvXBj6Vk+JVYrm0C hnuhum++Wl5fAG5J8Q5ID0CCvir5M1FFS44h/PLPJnnBQ2BJhNMbV/uofqHm+Rw02LoNPyBAbgPVH COJnurx5KyL6ujkcCN7I1ZeyqH/mU1mxUbbEqnMqRGLVB5zaJN5F5CcmnW40qWoLcSpXwmi0086G5 KAOC1ahtQ8u2FRJnPTlA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzGGw-0006zY-5J; Thu, 28 Feb 2019 07:38:26 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzGGr-0006yr-Cm for linux-arm-kernel@lists.infradead.org; Thu, 28 Feb 2019 07:38:23 +0000 Received: by mail-pl1-x642.google.com with SMTP id m10so9311981plt.10 for ; Wed, 27 Feb 2019 23:38:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cOASlEJavzy6jbNTX1VoAOkd7pO5Fd4rcji+cplSKck=; b=ch+mj6lMn/0iALow1x5putNdwm1gkRe9wv6ME9ffL1JiU92gMAqfEyFbPnbDiXB6+J bETwHW9NOW6eDByeri/+f0C5YWuUJFyYGesnd8t7+aq3sa7vtPGbVwu+7QjMuEZp4ASV BJyldOMehy1e1KWPvR/t93Gai3piDe+A0FenJB8zduR/q8wnB7B++R2BJElceIFUPMUz MYgXbW4RSskGfXoHPZhJqdn5x2EWjAAwS8QTMGzM55utya3hM6NbIeM4qB3HDmlf1/q4 M+TsKvq9PnXR0X2d20tMIjRvxpP4gvhBj7mTSdKahyR5dJRDpc9e3vEZdLUEr5rZMRW4 N9gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cOASlEJavzy6jbNTX1VoAOkd7pO5Fd4rcji+cplSKck=; b=uH/yhZNrdH4/6UqK2c5AbzNPYkAjd8olm3oPN86CKO+1FTcpezG9tHYZ9sgdhYWydb KRybfQ/WjnSAqu7KISZczkh1Juvx5dwEo7mc2Rc4lqK4mbm/YIGpafXQ0GIVt68TndfR JZYMI9r7NGSCP64aiw131g752XIIQFJKNMdtMaX4Qm1W9GxPdG8G7wLQg+5Tis/RkbM7 xLtMwv6N2LyTP5hyiJFcsB/lJ56PX6PgQYmjP/6VMvYSDiIYMqJ8C8wDRIP8KdgFwLNB AKSIYa9XHqDW5Ld5gvImQtnJC3GRf7GQsmMx22tsRbztCnXJZVa36/Cp1cJoNDugTsJO 3L0g== X-Gm-Message-State: AHQUAuZxM3iED3gEaV8UFmUzoQ9OPgOMJ6MyIPM/nGfi8Urlq8NwdxSv jBCzLS6g11paOPplVztRzFY= X-Google-Smtp-Source: AHgI3IaUP2SZYIec5/iVisUgkCf1msED0Sb5/aY2AeEV6741pwju7jvHUtVIBPGlu68ubOXtOEzTCA== X-Received: by 2002:a17:902:b413:: with SMTP id x19mr6570214plr.256.1551339499736; Wed, 27 Feb 2019 23:38:19 -0800 (PST) Received: from Inspiron-3521 ([223.186.159.144]) by smtp.gmail.com with ESMTPSA id v26sm24490647pgn.46.2019.02.27.23.38.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Feb 2019 23:38:19 -0800 (PST) Date: Thu, 28 Feb 2019 13:08:08 +0530 From: Leslie Monis To: Maxim Kuvyrkov Subject: Re: [BUG] Linux-next fails to link on ARM in allmodconfig and allyesconfig Message-ID: <20190228073808.GA5866@Inspiron-3521> References: <0B49A364-A5EC-4E23-BA39-9946523A1BAA@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0B49A364-A5EC-4E23-BA39-9946523A1BAA@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190227_233821_464771_49C3AB6B X-CRM114-Status: GOOD ( 17.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dhaval Khandla , Manish Kumar B , Ard Biesheuvel , "David S. Miller" , Dave Taht , Jamal Hadi Salim , "Sachin D. Patil" , broonie@kernel.org, Hrishikesh Hiraskar , "Mohit P. Tahiliani" , Arnd Bergmann , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 28, 2019 at 10:29:42AM +0300, Maxim Kuvyrkov wrote: > Hi Mohit, > > It seems that your commit 3f7ae5f3dc5295ac17d6521130ed8a8f8a723fbf causes a link failure for ARM in allmodconfig and allyesconfig. This happens for at least gcc-8 compiler. > === > ERROR: "__aeabi_uldivmod" [net/sched/sch_pie.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > === > > Would you please investigate? Below are diagnostics from Linaro's automated bisection job. > > === > Culprit: > > commit 3f7ae5f3dc5295ac17d6521130ed8a8f8a723fbf > Author: Mohit P. Tahiliani > Date: Tue Feb 26 00:39:59 2019 +0530 > > net: sched: pie: add more cases to auto-tune alpha and beta > > The current implementation scales the local alpha and beta > variables in the calculate_probability function by the same > amount for all values of drop probability below 1%. > > RFC 8033 suggests using additional cases for auto-tuning > alpha and beta when the drop probability is less than 1%. > > In order to add more auto-tuning cases, MAX_PROB must be > scaled by u64 instead of u32 to prevent underflow when > scaling the local alpha and beta variables in the > calculate_probability function. > > Signed-off-by: Mohit P. Tahiliani > Signed-off-by: Dhaval Khandla > Signed-off-by: Hrishikesh Hiraskar > Signed-off-by: Manish Kumar B > Signed-off-by: Sachin D. Patil > Signed-off-by: Leslie Monis > Acked-by: Dave Taht > Acked-by: Jamal Hadi Salim > Signed-off-by: David S. Miller > > > Results regressed from (for last_good == 30a92ad703b93a96588e05b5bcd7247d7350c673) > reset_artifacts: > -10 > build_abe binutils: > -9 > build_abe stage1: > -8 > linux_n_obj: > 26184 > linux build successful: > all > > to (for first_bad == 3f7ae5f3dc5295ac17d6521130ed8a8f8a723fbf) > reset_artifacts: > -10 > build_abe binutils: > -9 > build_abe stage1: > -8 > linux_n_obj: > 19184 > > First few errors in logs of first_bad: > ERROR: "__aeabi_uldivmod" [net/sched/sch_pie.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > > Artifacts of last_good build: https://ci.linaro.org/job/tcwg_kernel-bisect-gnu-release-arm-next-allmodconfig/18/artifact/artifacts/build-30a92ad703b93a96588e05b5bcd7247d7350c673/ > Artifacts of first_bad build: https://ci.linaro.org/job/tcwg_kernel-bisect-gnu-release-arm-next-allmodconfig/18/artifact/artifacts/build-3f7ae5f3dc5295ac17d6521130ed8a8f8a723fbf/ > === > > -- > Maxim Kuvyrkov > www.linaro.org > > > Hi Max, This bug was fixed by commit ff8285f81822dc8f528b36b6c5c8ab132367e92d commit ff8285f81822dc8f528b36b6c5c8ab132367e92d Author: Leslie Monis Date: Wed Feb 27 06:30:06 2019 +0530 net: sched: pie: fix 64-bit division Use div_u64() to resolve build failures on 32-bit platforms. Fixes: 3f7ae5f3dc52 ("net: sched: pie: add more cases to auto-tune alpha and beta") Signed-off-by: Leslie Monis Reported-by: Randy Dunlap Tested-by: Randy Dunlap Signed-off-by: David S. Miller Leslie _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel