From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Marcin Wojtas <mw@semihalf.com>
Cc: antoine.tenart@bootlin.com, netdev@vger.kernel.org,
gregory.clement@bootlin.com, linux-kernel@vger.kernel.org,
nadavh@marvell.com, thomas.petazzoni@bootlin.com,
jaz@semihalf.com, tn@semihalf.com, stefanc@marvell.com,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [net: PATCH] net: mvpp2: disable link IRQ waiting for IDLE frames
Date: Thu, 28 Feb 2019 09:36:27 +0000 [thread overview]
Message-ID: <20190228093627.vtfglsl2djenohlm@shell.armlinux.org.uk> (raw)
In-Reply-To: <1551289652-7377-1-git-send-email-mw@semihalf.com>
On Wed, Feb 27, 2019 at 06:47:32PM +0100, Marcin Wojtas wrote:
> Current version of the driver was configuring XLG MAC
> in a way to wait 3 IDLE frames before allowing for the
> link-up interrupt to be triggered. This resulted in an
> issue, preventing to detect the link change during RX
> traffic on the interface. Fix that.
What about noise sensitivity? Does this now mean that on boards such as
Macchiatobin Single Shot or Clearfog GT9k where the serdes is connected
directly to a SFP cage, that noise on the serdes lines triggers a link
indication?
>
> Fixes: 4bb043262878 ("net: mvpp2: phylink support")
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 16066c2..f1378f9 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -4532,8 +4532,7 @@ static void mvpp2_xlg_config(struct mvpp2_port *port, unsigned int mode,
> ctrl0 |= MVPP22_XLG_CTRL0_RX_FLOW_CTRL_EN;
>
> ctrl4 &= ~MVPP22_XLG_CTRL4_MACMODSELECT_GMAC;
> - ctrl4 |= MVPP22_XLG_CTRL4_FWD_FC | MVPP22_XLG_CTRL4_FWD_PFC |
> - MVPP22_XLG_CTRL4_EN_IDLE_CHECK;
> + ctrl4 |= MVPP22_XLG_CTRL4_FWD_FC | MVPP22_XLG_CTRL4_FWD_PFC;
>
> writel(ctrl0, port->base + MVPP22_XLG_CTRL0_REG);
> writel(ctrl4, port->base + MVPP22_XLG_CTRL4_REG);
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-28 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 17:47 [net: PATCH] net: mvpp2: disable link IRQ waiting for IDLE frames Marcin Wojtas
2019-02-28 9:36 ` Russell King - ARM Linux admin [this message]
2019-02-28 13:58 ` Marcin Wojtas
2019-04-23 16:08 ` Marcin Wojtas
2019-04-23 17:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228093627.vtfglsl2djenohlm@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@bootlin.com \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tn@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).