From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CEDDC43381 for ; Thu, 28 Feb 2019 09:38:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED1712171F for ; Thu, 28 Feb 2019 09:38:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hhuhVZKj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="B9wEMfNw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED1712171F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GhTGOrvVKsP0jn1O81Gg3hGpY1yseC/NukCkmpQf5+s=; b=hhuhVZKjIJYixN xwRK4m504dh2Pm94Vni4khVnGDZ9OKcPsmrM0XaNMHiNG328X2r0UfwjxcCNLw19Oy2VYMby3Uvva vHRt5dt9f/V6ZbhRDkT0+IhcYtexkIib0lXNwp2pk8eGuOSwYtJNqzWkhBRkgM8hb0diCSb/Yql1r pOvsR/7OBPgMqhhezP92wBI7mDDTQj3ManSH/edg470GP20ALroQDvQGo/bnXUo8iaELhQarDAQME OPSlPRfTA31edGT/GoVwYmBThbRfVq/U/j5lw6yIGXxegSn0fDJPs3DtVDOFujdXUT9rDQn17SXvg aBMirG9lmVA4oxwjd3IQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzI9N-00049w-Ua; Thu, 28 Feb 2019 09:38:45 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzI9J-0003rZ-P3 for linux-arm-kernel@lists.infradead.org; Thu, 28 Feb 2019 09:38:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7y9xwG/CRNbW3l4I71tOuUDLnb461h3PL9eNliEsxkY=; b=B9wEMfNwMMlkg39faULMRI4lp 4OdKeBgV8bJvFvgk9s27XqB56w4uAf1l+CGHI6/e0EfTjDKIivQULsXosOcG7Qfox4zyY0wlhH1Bo QOwS8U14yy10Tzk5hF0XXa+ESsfQYWDu9N/gmXPy3Ru4nPsUU49wzwrYcBq+jEFNcyidJn/1oZANf T1NIjQs9p0L1b458AmpCJ75thoDWiuIfl4DxYHj2p2nmsf6k7FcBVd3A4oomCm+RpGrohL711rI24 dQLTCgUAoZtnPOweuH+CvsGISC2QknL9Y0k6FQTBtIMVRBk0VfWTuh/Nyd9GEQlRbdUITcq1nYe2I li2A4GIOQ==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:37166) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gzI7E-0007tY-3J; Thu, 28 Feb 2019 09:36:32 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.89) (envelope-from ) id 1gzI79-0007Hx-U4; Thu, 28 Feb 2019 09:36:27 +0000 Date: Thu, 28 Feb 2019 09:36:27 +0000 From: Russell King - ARM Linux admin To: Marcin Wojtas Subject: Re: [net: PATCH] net: mvpp2: disable link IRQ waiting for IDLE frames Message-ID: <20190228093627.vtfglsl2djenohlm@shell.armlinux.org.uk> References: <1551289652-7377-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1551289652-7377-1-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190228_013841_815034_57AACE72 X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: antoine.tenart@bootlin.com, netdev@vger.kernel.org, gregory.clement@bootlin.com, linux-kernel@vger.kernel.org, nadavh@marvell.com, thomas.petazzoni@bootlin.com, jaz@semihalf.com, tn@semihalf.com, stefanc@marvell.com, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 27, 2019 at 06:47:32PM +0100, Marcin Wojtas wrote: > Current version of the driver was configuring XLG MAC > in a way to wait 3 IDLE frames before allowing for the > link-up interrupt to be triggered. This resulted in an > issue, preventing to detect the link change during RX > traffic on the interface. Fix that. What about noise sensitivity? Does this now mean that on boards such as Macchiatobin Single Shot or Clearfog GT9k where the serdes is connected directly to a SFP cage, that noise on the serdes lines triggers a link indication? > > Fixes: 4bb043262878 ("net: mvpp2: phylink support") > Signed-off-by: Marcin Wojtas > --- > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > index 16066c2..f1378f9 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > @@ -4532,8 +4532,7 @@ static void mvpp2_xlg_config(struct mvpp2_port *port, unsigned int mode, > ctrl0 |= MVPP22_XLG_CTRL0_RX_FLOW_CTRL_EN; > > ctrl4 &= ~MVPP22_XLG_CTRL4_MACMODSELECT_GMAC; > - ctrl4 |= MVPP22_XLG_CTRL4_FWD_FC | MVPP22_XLG_CTRL4_FWD_PFC | > - MVPP22_XLG_CTRL4_EN_IDLE_CHECK; > + ctrl4 |= MVPP22_XLG_CTRL4_FWD_FC | MVPP22_XLG_CTRL4_FWD_PFC; > > writel(ctrl0, port->base + MVPP22_XLG_CTRL0_REG); > writel(ctrl4, port->base + MVPP22_XLG_CTRL4_REG); > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel