From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E40CC43381 for ; Thu, 28 Feb 2019 12:19:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A70A214D8 for ; Thu, 28 Feb 2019 12:19:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BwO5aa8j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A70A214D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NTK/81Z9HXJQjmsLaVRDq1+x8LCMjKf23KhWFsxmB7I=; b=BwO5aa8jhrglIF ImfXddXQi6H0ZINYZSjrGUST+I62mkvVj2xAyMnBMayaclZ8mGnGo+dRaQPSnm1RD2Zs1E6JbTZOd IIp0AomD7YSD2z43ruoiypwrMRrxIf+HhIzzQKGN6G0CDf/OnNtll+RJvGdEi6A5bZRAC4eKrfe9K 7K7rlyc8+8kWww4tDU3LnZYaqADHCimJZoHC8llRIvZR+K+RfLJyP31pcowOVX+WffiJ8U52FRlqp xxiDGnccA/Fk0b4LLgcJhHb+4L964Ijb88OTs5Njxss4GqitbyjYZn9zJ6VBKE4Hcl7GW4moxj/so Caljfp/vOVl1lHolxnbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzKeg-0007ge-Eg; Thu, 28 Feb 2019 12:19:14 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzKec-0007gL-VV for linux-arm-kernel@lists.infradead.org; Thu, 28 Feb 2019 12:19:12 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DEAD380D; Thu, 28 Feb 2019 04:19:08 -0800 (PST) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB0123F575; Thu, 28 Feb 2019 04:19:07 -0800 (PST) Date: Thu, 28 Feb 2019 12:19:01 +0000 From: Sudeep Holla To: Lingutla Chandrasekhar Subject: Re: [PATCH] arch_topology: Update user supplied capacity to possible cpus in cluster Message-ID: <20190228121901.GA26207@e107155-lin> References: <1551354838-29902-1-git-send-email-clingutla@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1551354838-29902-1-git-send-email-clingutla@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190228_041911_019929_241305D2 X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will.deacon@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, Sudeep Holla Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 28, 2019 at 05:23:58PM +0530, Lingutla Chandrasekhar wrote: > With commit '5bdd2b3f0f8 ("arm64: topology: add support to remove cpu > topology sibling masks")', when cpu hotplugged out, it resets the cpu > information in its sibling CPUs. If user changes capacity of any cpu, > then the new capacity applied to all online cpus in the cluster. > Correct but you are now changing to apply the same to all the CPUs in the package which is wrong. > If any hot plugged out cpu in the same cluster comes back to online, > then that would have different/stale capacity value. > Why not save the value ? > Fix it by applying user supplied capacity to all possible cpus in the > cluster. > NACK for the change. It changes for all the CPUs in the package/socket. Though DT platforms have cluster ids as package ids, that's wrong and must be fixed. So you need to fix this issuw without depending on the package id. I have removed all the wrong users of the same and this is also a wrong usage. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel