From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2368CC43381 for ; Thu, 28 Feb 2019 13:11:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E46A12171F for ; Thu, 28 Feb 2019 13:11:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bdlGYdRM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="eFp1quFw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E46A12171F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xRMiY+E79yWE2i66kHfCqTNngS9/9Xcb1EPlcRzBHK8=; b=bdlGYdRMKeVj88 4i2ZYOGCjhO0+XvrzncmudHyvMJ5DnMRPA60oPxXmNLFnoQ0NoiFUvBUPWeBnkL5BuU8/SGYNwNca 9aB3Z5o9e/c+RD0KnL3SgRjmCnxVJS7LZARknoRkwExGkNZSjoqYnAANvtC2iZjgXxgEw58aXWCnw 10pFuLoGEISU54PRCfz1KHcCe/NgxN8aoQSpSpX7ovjye/hrgY+WssYJGlqPGA5NGTgc0fc7kdZK1 rn0/6lymSJ1atz838rT8nLSWblQdNN0v9NBomX9drfEJIMkO/qJWPj4PPcdxJ44atppJVCg9JH96i d23d2PoApgWyQ2RvhvuQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzLTB-0002B6-EF; Thu, 28 Feb 2019 13:11:25 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzLT1-00029n-TV for linux-arm-kernel@lists.infradead.org; Thu, 28 Feb 2019 13:11:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1dCsrev92yUWlX4d+Ar1uRdwfi+4D5obO9jb8ZJ/b+U=; b=eFp1quFw5OgV4mP9xZ5WPursg peLdyjIrJzawQ6eUs188NJ9RykVtb+UT9TYFA9Ew/TDUEkZmdJIWyJ12pAbRKcLRGHsvqxnxS5DWf 2BCF7r/VVPnEIcWy74d2bz0sewEFC0QsX4mWmA/zNeXYUvsB2OLY/8HTSH8Hrx1y5s+5/mfQ3Sjqf cp+1gQdd3U3wD5eGrlWFFOFFhEkdg0x1EWToMQnnwVdRozv2gJKcSbFPbJJ+PufcFCABUqhro7SPJ yk0pgx899ZnsAaZjtHBjYIHLbVX6HBLEnoLeLi0oATG+FEPjm1VRvleWfxsTz/YMjl9FElDsK+2WQ 2UsPe3KFg==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:54870) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gzLSn-0000VK-Ue; Thu, 28 Feb 2019 13:11:02 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.89) (envelope-from ) id 1gzLSl-0007QC-8b; Thu, 28 Feb 2019 13:10:59 +0000 Date: Thu, 28 Feb 2019 13:10:59 +0000 From: Russell King - ARM Linux admin To: Jyri Sarha Subject: Re: hdmi-codec: modifying params in hw_params() callback Message-ID: <20190228131059.i4nffuylja5p6tjv@shell.armlinux.org.uk> References: <20190228121516.swd3vweisgcxlvld@shell.armlinux.org.uk> <421c1217-6ff6-6ca2-8169-db026284fb29@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <421c1217-6ff6-6ca2-8169-db026284fb29@ti.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190228_051116_121933_739FF37C X-CRM114-Status: GOOD ( 22.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Mark Brown , Liam Girdwood , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 28, 2019 at 02:54:29PM +0200, Jyri Sarha wrote: > On 28/02/2019 14:15, Russell King - ARM Linux admin wrote: > > Hi all, > > > > While looking at hdmi-codec issues, I spotted this code: > > > > static int hdmi_codec_hw_params(struct snd_pcm_substream *substream, > > struct snd_pcm_hw_params *params, > > struct snd_soc_dai *dai) > > { > > ... > > if (params_width(params) > 24) > > params->msbits = 24; > > > > params->msbits is a parameter that is negotiated and refined by > > libasound, and is part of the ALSA constraint system. The "Writing an > > ALSA driver" documentation says about the hw_params callback: > > > > "This is called when the hardware parameter (``hw_params``) is set up > > by the application, that is, once when the buffer size, the period > > size, the format, etc. are defined for the pcm substream." > > > > which suggests we should only be reading the parameters, not writing > > to them. > > > > What's more is that the msbits is a parameter that is refined with > > userspace, so surely the above should be a declared constraint? > > > > Certainly not a constraint. While HDMI can only pass up to 24-bit per > sample audio the most (or at least the two I have worked with) encoders > can take 32-bit wide (and probably wider) samples trough i2s. So the > system can play 32-bit samples, just the 4 LSB is ignored. You have not explained why "not a constraint". From the explanation that Mark gave me on IRC, msbits is the number of bits that the codec respects, whereas the sample bits is the number of bits in the sample. If sample bits - msbits != 0, then that is the number of bits ignored. Mark basically described it as "feel free to send me more than 24 bits but I'm ignoring the LSBs". If the msbits is limited to 24, then userspace gets to know about that limitation when negotiating with ALSA if it is a constraint. If it isn't a constraint, userspace has no way to know. > Actually there is very little difference between the case of playing > 32-bit stereo audio with matching i2s bclk ratio, and playing 24-bit > stereo audio with 64-bit bclk ratio. Especially when the 4 LSB is anyway > ignored like in HDMI audio case. You mean 8 LSB throughout the above two paragraphs. > > Digging a bit deeper, ASoC passes a private copy of the params to each > > codec - a copy is made, then fixups for TDM slots are applied, followed > > by any topology fixups by the DAI link (be_hw_params_fixup) before the > > codec driver's hw_params() callback is made. Afterwards, ASoC reads > > back the rate, channels and physical (memory) width and stores them > > in the codec's DAI structure. The msbits are not read. > > > > hdmi-codec also seems to do nothing with the msbits parameter other > > than the above code. > > > > So, all in all, it seems that the above code limiting msbits is > > redundant - nothing will read this modified value. Can we kill it? > > > > It certainly looks that way, so yes. In any case struct > snd_soc_dai_driver .playback.sig_bits = 24 should be all that is needed. This sets a constraint to limit msbits to 24 for any sample width in core ASoC code, doing exactly what you said "certainly not" to above. It also means that the quoted code in hdmi-codec's hw_params() is redundant for another reason. See the description of: snd_pcm_hw_constraint_msbits() in sound/core/pcm_lib.c, soc_pcm_set_msb() and soc_pcm_apply_msb() in sound/soc/soc-pcm.c. Can you please clarify, because there seems to be some confusion. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel