From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C3C9C10F00 for ; Thu, 28 Feb 2019 14:17:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC320214D8 for ; Thu, 28 Feb 2019 14:17:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pHgjgWP9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nUjyWrZP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC320214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qyg8rbtfj5RnMYb2uTZdbiS6ActP2ymaB5IZztQMNTM=; b=pHgjgWP9FB6JCa x5KN9tn6tfyrvSxV3kWUPHokCXCNrX5C5BbT+RD7k5dgtjixF/GlZ6CdqH9uEVuvZL1KRey5pfdFe hIBwlWK9crVgp1S5A+MAX12StwOamHhbDy01FSUm4fSMHC3oKEr7KXglLr66Yy4vl5q4a9xr84RrV HTPGQ9N9FBGfYOFEHmjpupmlwyBxgl2HNPTfoKeklyu8wh/Tq+zm4fam8Fr7bdQPRp1zF60NFWwr7 Q3X39LJDHHgZkb1X/7/pk8CEjfIm6ctc7KaBK8Teg3XKCXl92nIh5s9B5BSRPiLE7bYSGmvnzpi76 eKzj1m2eftFe6VKvVuNw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzMUo-0006Wd-2h; Thu, 28 Feb 2019 14:17:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzMUT-0006Fk-RS for linux-arm-kernel@lists.infradead.org; Thu, 28 Feb 2019 14:16:51 +0000 Received: from dragon (li1566-229.members.linode.com [139.162.86.229]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F10BF214D8; Thu, 28 Feb 2019 14:16:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551363406; bh=9xSREEXqSZaSGtv+FaDJsnmwYFQhzVRuYTR57iNggpM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nUjyWrZP7KIimTkKuCtHkTEz7N4nI0he2TnJ/aiYRhm0xQm682ahlhEj9oeGNtE2p B0Syo8uVagSdP3LJc8NLuZWDEK3uYoOQ9TBjvB7DAvgSryAc7ILAXA0IyIZYn+Bdkc 6gx7k+H9hclYZYqdiVz3CPlI2l3H0gZ/kAGtNZ/w= Date: Thu, 28 Feb 2019 22:15:46 +0800 From: Shawn Guo To: Abel Vesa Subject: Re: [PATCH v2 2/3] arm64: dts: imx8mq: Add the buck vdd_arm regulator Message-ID: <20190228141543.GA29231@dragon> References: <1550254032-16451-1-git-send-email-abel.vesa@nxp.com> <1550254032-16451-3-git-send-email-abel.vesa@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1550254032-16451-3-git-send-email-abel.vesa@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190228_061649_906013_EFAB16F8 X-CRM114-Status: GOOD ( 17.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , Anson Huang , "devicetree@vger.kernel.org" , Linux Kernel Mailing List , Fabio Estevam , dl-linux-imx , Sascha Hauer , Angus Ainslie , "linux-arm-kernel@lists.infradead.org" , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 15, 2019 at 06:07:23PM +0000, Abel Vesa wrote: > According to the schematics, this is a MP2147 switch converter > which is controlled by GPIO1_IO13. When set the gpio is set to > high the regulator output is set to 0.9V. When the gpio is set > to low the regulator output is set to 1V. > > Signed-off-by: Abel Vesa > --- > arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 36 ++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > index 54737bf..e5da3dd 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > @@ -31,6 +31,35 @@ > gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; > enable-active-high; > }; > + > + buck2_reg: buck2 { Please follow regulator-xxx naming convention. > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_buck2>; > + compatible = "regulator-gpio"; > + regulator-name = "vdd_arm"; > + regulator-min-microvolt = <900000>; > + regulator-max-microvolt = <1000000>; > + gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>; > + states = <1000000 0x0 > + 900000 0x1>; > + enable-active-high; The property only makes sense when enable-gpio is present? Shawn > + }; > +}; > + > +&A53_0 { > + cpu-supply = <&buck2_reg>; > +}; > + > +&A53_1 { > + cpu-supply = <&buck2_reg>; > +}; > + > +&A53_2 { > + cpu-supply = <&buck2_reg>; > +}; > + > +&A53_3 { > + cpu-supply = <&buck2_reg>; > }; > > &fec1 { > @@ -203,6 +232,13 @@ > }; > > &iomuxc { > + pinctrl_buck2: vddarmgrp { > + fsl,pins = < > + MX8MQ_IOMUXC_GPIO1_IO13_GPIO1_IO13 0x19 > + >; > + > + }; > + > pinctrl_fec1: fec1grp { > fsl,pins = < > MX8MQ_IOMUXC_ENET_MDC_ENET1_MDC 0x3 > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel