From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07E4FC10F00 for ; Thu, 28 Feb 2019 21:55:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3DEC218AE for ; Thu, 28 Feb 2019 21:55:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fXyLIzj1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3DEC218AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P2bAQvpdQpt6KThsk3RK8cfv3jE6RUBpNi8/WRKNglM=; b=fXyLIzj1ufqxei 6RRlqcV4f9/+WC57UcuODWAp863o8Qjp13YwH/3vgsmRv4SkkhuFtW702pO0UAZpKkJ+W9xKB5JBq ow4JAVz3IRtmpTi/Pu3rt4W6DE7jFzTJgIL+8zI/TYMJsNuDY3IFMlpasXLvpvLhQ5WWtX216jS5N f4LrDGjyKJg5O4SHvj6kNgk1Ky9D1lqpaK0U1kPdbLGKoyNz3CBw2qERkpTh8HKaL7MZ9uYqaHBcz GMBH9RsLeN5NVEhUeLfiGuVl1Sx8oQHSGETO/X5eFfNwppNRtfqUDkXeFAEAM8mfi2FbRt1x32c25 K7yrz4vxltWfT+uVuoyA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzTeI-0002Bl-SD; Thu, 28 Feb 2019 21:55:26 +0000 Received: from asavdk3.altibox.net ([109.247.116.14]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzTeF-0002Ad-O0 for linux-arm-kernel@lists.infradead.org; Thu, 28 Feb 2019 21:55:25 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id CDB7F20053; Thu, 28 Feb 2019 22:55:20 +0100 (CET) Date: Thu, 28 Feb 2019 22:55:19 +0100 From: Sam Ravnborg To: Claudiu.Beznea@microchip.com Subject: Re: [PATCH 6/7] drm: atmel-hlcdc: enable sys_clk during initalization. Message-ID: <20190228215519.GE30188@ravnborg.org> References: <1551284609-14594-1-git-send-email-claudiu.beznea@microchip.com> <1551284609-14594-7-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1551284609-14594-7-git-send-email-claudiu.beznea@microchip.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=XYAwZIGsAAAA:8 a=e5mUnYsNAAAA:8 a=2RQu7XLWcUR9zxScWdkA:9 a=7Zwj6sZBwVKJAoWSPKxL6X1jA+E=:19 a=CjuIK1q_8ugA:10 a=E8ToXWR_bxluHZ7gmE-Z:22 a=Vxmtnl_E_bksehYqCbjh:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190228_135524_140754_7E1CECFD X-CRM114-Status: GOOD ( 22.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, bbrezillon@kernel.org, airlied@linux.ie, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, robh+dt@kernel.org, thierry.reding@gmail.com, dri-devel@lists.freedesktop.org, daniel@ffwll.ch, Sandeep.Sheriker@microchip.com, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Claudiu On Wed, Feb 27, 2019 at 04:24:40PM +0000, Claudiu.Beznea@microchip.com wrote: > From: Sandeep Sheriker Mallikarjun > > For SAM9X60 SoC, sys_clk is through lcd_gclk clock source and this > needs to be enabled before enabling lcd_clk. We have "ownership" of the clocks in the mfd device. So it would make more sense to let the mfd device handle the base clocks. In other words - what about pushing enable of perigh_clk and sys_clk to the mfd driver. This may have the nice side-effect that we avoid that both the drm driver and the pwm driver enable/disable the periph_clk as it is today. Another comment - fixed_clksrc is used to determine if sys_clk is enabled. But that flag is about the clksource selection, and it is just a coincidence that the same flag can be used here. Why we cannot always enable sys_clk? Do we need to do this only for sam9x60? IF yes, then add a new falg. If no, then skip the flag. Sam > > Signed-off-by: Sandeep Sheriker Mallikarjun > [claudiu.beznea@microchip.com: add fixed_clksrc checks] > Signed-off-by: Claudiu Beznea > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > index 0be13eceedba..8bf51f853721 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > @@ -625,10 +625,18 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev) > dc->hlcdc = dev_get_drvdata(dev->dev->parent); > dev->dev_private = dc; > > + if (dc->desc->fixed_clksrc) { > + ret = clk_prepare_enable(dc->hlcdc->sys_clk); > + if (ret) { > + dev_err(dev->dev, "failed to enable sys_clk\n"); > + goto err_destroy_wq; > + } > + } > + > ret = clk_prepare_enable(dc->hlcdc->periph_clk); > if (ret) { > dev_err(dev->dev, "failed to enable periph_clk\n"); > - goto err_destroy_wq; > + goto err_sys_clk_disable; > } > > pm_runtime_enable(dev->dev); > @@ -664,6 +672,9 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev) > err_periph_clk_disable: > pm_runtime_disable(dev->dev); > clk_disable_unprepare(dc->hlcdc->periph_clk); > +err_sys_clk_disable: > + if (dc->desc->fixed_clksrc) > + clk_disable_unprepare(dc->hlcdc->sys_clk); > > err_destroy_wq: > destroy_workqueue(dc->wq); > @@ -688,6 +699,8 @@ static void atmel_hlcdc_dc_unload(struct drm_device *dev) > > pm_runtime_disable(dev->dev); > clk_disable_unprepare(dc->hlcdc->periph_clk); > + if (dc->desc->fixed_clksrc) > + clk_disable_unprepare(dc->hlcdc->sys_clk); > destroy_workqueue(dc->wq); > } > > @@ -805,6 +818,8 @@ static int atmel_hlcdc_dc_drm_suspend(struct device *dev) > regmap_read(regmap, ATMEL_HLCDC_IMR, &dc->suspend.imr); > regmap_write(regmap, ATMEL_HLCDC_IDR, dc->suspend.imr); > clk_disable_unprepare(dc->hlcdc->periph_clk); > + if (dc->desc->fixed_clksrc) > + clk_disable_unprepare(dc->hlcdc->sys_clk); > > return 0; > } > @@ -814,6 +829,8 @@ static int atmel_hlcdc_dc_drm_resume(struct device *dev) > struct drm_device *drm_dev = dev_get_drvdata(dev); > struct atmel_hlcdc_dc *dc = drm_dev->dev_private; > > + if (dc->desc->fixed_clksrc) > + clk_prepare_enable(dc->hlcdc->sys_clk); > clk_prepare_enable(dc->hlcdc->periph_clk); > regmap_write(dc->hlcdc->regmap, ATMEL_HLCDC_IER, dc->suspend.imr); > > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel