From: Will Deacon <will.deacon@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: mark.rutland@arm.com, catalin.marinas@arm.com,
Will Deacon <will.deacon@arm.com>
Subject: [PATCH 00/10] Rework debug exception handling code
Date: Fri, 1 Mar 2019 13:27:59 +0000 [thread overview]
Message-ID: <20190301132809.24653-1-will.deacon@arm.com> (raw)
Hi all,
Our debug exception handling code is a bit of a horror show. Userspace
can trigger kprobe logic to run (which ends up just returning back to
the brk instruction instead of delivering a SIGTRAP) and can also enter
KGDB if it is enabled (which causes a kernel panic due to a NULL
dereference).
These patch fix those problems and tidy up the code so that they're less
likely to happen again in future.
Will
--->8
Will Deacon (10):
arm64: debug: Don't propagate UNKNOWN FAR into si_code for debug
signals
arm64: debug: Ensure debug handlers check triggering exception level
arm64: debug: Remove unused return value from do_debug_exception()
arm64: debug: Rename addr parameter for non-watchpoint exception hooks
arm64: debug: Remove meaningless comment
arm64: debug: Separate debug hooks based on target exception level
arm64: kprobes: Avoid calling kprobes debug handlers explicitly
arm64: debug: Remove redundant user_mode(regs) checks from debug
handlers
arm64: probes: Move magic BRK values into brk-imm.h
arm64: debug: Clean up brk_handler()
arch/arm64/include/asm/brk-imm.h | 4 ++
arch/arm64/include/asm/debug-monitors.h | 24 +++----
arch/arm64/include/asm/esr.h | 4 +-
arch/arm64/include/asm/kprobes.h | 2 -
arch/arm64/kernel/debug-monitors.c | 111 ++++++++++++++++++--------------
arch/arm64/kernel/kgdb.c | 28 ++++----
arch/arm64/kernel/probes/kprobes.c | 16 ++++-
arch/arm64/kernel/probes/uprobes.c | 19 ++----
arch/arm64/kernel/traps.c | 21 ++----
arch/arm64/mm/fault.c | 19 ++----
10 files changed, 127 insertions(+), 121 deletions(-)
--
2.11.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-03-01 13:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 13:27 Will Deacon [this message]
2019-03-01 13:28 ` [PATCH 01/10] arm64: debug: Don't propagate UNKNOWN FAR into si_code for debug signals Will Deacon
2019-03-01 13:45 ` Mark Rutland
2019-03-05 13:35 ` Sasha Levin
2019-03-01 13:28 ` [PATCH 02/10] arm64: debug: Ensure debug handlers check triggering exception level Will Deacon
2019-03-01 13:46 ` Mark Rutland
2019-03-05 13:35 ` Sasha Levin
2019-03-01 13:28 ` [PATCH 03/10] arm64: debug: Remove unused return value from do_debug_exception() Will Deacon
2019-03-01 13:48 ` Mark Rutland
2019-03-01 13:28 ` [PATCH 04/10] arm64: debug: Rename addr parameter for non-watchpoint exception hooks Will Deacon
2019-03-01 13:49 ` Mark Rutland
2019-03-01 13:28 ` [PATCH 05/10] arm64: debug: Remove meaningless comment Will Deacon
2019-03-01 14:08 ` Mark Rutland
2019-03-01 13:28 ` [PATCH 06/10] arm64: debug: Separate debug hooks based on target exception level Will Deacon
2019-03-01 14:07 ` Mark Rutland
2019-03-01 13:28 ` [PATCH 07/10] arm64: kprobes: Avoid calling kprobes debug handlers explicitly Will Deacon
2019-03-01 14:12 ` Mark Rutland
2019-03-01 13:28 ` [PATCH 08/10] arm64: debug: Remove redundant user_mode(regs) checks from debug handlers Will Deacon
2019-03-01 14:13 ` Mark Rutland
2019-03-01 13:28 ` [PATCH 09/10] arm64: probes: Move magic BRK values into brk-imm.h Will Deacon
2019-03-01 14:16 ` Mark Rutland
2019-03-01 13:28 ` [PATCH 10/10] arm64: debug: Clean up brk_handler() Will Deacon
2019-03-01 14:17 ` Mark Rutland
2019-03-01 16:24 ` [PATCH 00/10] Rework debug exception handling code Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301132809.24653-1-will.deacon@arm.com \
--to=will.deacon@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).