From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC76C43381 for ; Fri, 1 Mar 2019 15:29:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A5A92084D for ; Fri, 1 Mar 2019 15:29:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KPlg0/kU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A5A92084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x6jid7y58CafX3D719vnZ4CnglkFzAi/94j/pSKS+cU=; b=KPlg0/kUL60dNu lsV8SCQ7wlnuI6McAJYtiKCq+LfbvrYAf2rRoaAaui/ZCmnKVQiJ/3o+Wq3mJPS2MkNnwrkEVdrIT cwSJIni//ppRHPdIYEgvtiBiKcPzg3ygRGe/N2/20wFaFN8TXXgEbKew/6ZsTe7s2m1gZDAzELQoo 0ozSdTrrTveUZARRTISCZq5xh1YIrGLT38xe/L727PGQN2o3Hk/zfdZ0WhEqg/x/k/xzCQ6PruQv4 lIlxYws/bFd0Ynkl2stRdb9fktNTQoKtnr5MFsjBf08vUbIEeWGF3tn3barEL32w5o6C1WobOtjsM Bf+nziqjOqX9TGbCZURQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzk6O-0002c6-1L; Fri, 01 Mar 2019 15:29:32 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzk6L-0002ZM-5S for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2019 15:29:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 935BFA78; Fri, 1 Mar 2019 07:29:28 -0800 (PST) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.197.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3D4183F575; Fri, 1 Mar 2019 07:29:27 -0800 (PST) Date: Fri, 1 Mar 2019 15:29:21 +0000 From: Lorenzo Pieralisi To: Wei Yongjun Subject: Re: [PATCH -next] PCI: aardvark: Make symbol 'advk_pci_bridge_emul_ops' static Message-ID: <20190301152921.GA7771@e107981-ln.cambridge.arm.com> References: <20190301065809.66046-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190301065809.66046-1-weiyongjun1@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190301_072929_216008_D613E63C X-CRM114-Status: GOOD ( 14.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org, Thomas Petazzoni , Bjorn Helgaas , Zachary Zhang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 01, 2019 at 06:58:09AM +0000, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/pci/controller/pci-aardvark.c:469:28: warning: > symbol 'advk_pci_bridge_emul_ops' was not declared. Should it be static? > > Fixes: 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI bridge config space") > Signed-off-by: Wei Yongjun > --- > drivers/pci/controller/pci-aardvark.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to pci/misc for v5.1, thanks. Lorenzo > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > index 6eecae447af3..eb58dfdaba1b 100644 > --- a/drivers/pci/controller/pci-aardvark.c > +++ b/drivers/pci/controller/pci-aardvark.c > @@ -466,7 +466,7 @@ advk_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge, > } > } > > -struct pci_bridge_emul_ops advk_pci_bridge_emul_ops = { > +static struct pci_bridge_emul_ops advk_pci_bridge_emul_ops = { > .read_pcie = advk_pci_bridge_emul_pcie_conf_read, > .write_pcie = advk_pci_bridge_emul_pcie_conf_write, > }; > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel