From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9F2DC43381 for ; Fri, 1 Mar 2019 15:55:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99E6120850 for ; Fri, 1 Mar 2019 15:55:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="skeNiYUa"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nt1k1fUw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99E6120850 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qi3JhWvB1UkGS4vjyQQnxHvraTd091qqjdr5DZDVSb8=; b=skeNiYUafASWrl 22eCw3MVHFRWjMuBGEEIzVngXGB01TmsSUG9UNpcffLeYwLtGNwhUI2Hv+VXy3ms4sxPQiiCjWPvc NeGWZqlDhbeatjYwmVw8G+SJq0/2PmeL4hGu73npm2hMbBmvkWqvfIfKscsjZs8s/lSL0d5axUJOQ Xgd2LTq5nH3YfVIYsHMihZGvsU3IfCO0pZ/+mN2enKB7uMuHzURjdgpuIhHPs9O7SEWAfyo63XELb xWzOQsuJNhM3tMgDabg8BX67LG/MAHxkZBTR6kNMeIYUxAi2Xh/+mu/gA66KElSGvcUEraeJFO4gz gCJgyLFASZd/QU6bgjFw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzkVq-0007bL-7w; Fri, 01 Mar 2019 15:55:50 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzkVl-0007ZM-VT for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2019 15:55:47 +0000 Received: by mail-pg1-x544.google.com with SMTP id l11so11620032pgq.10 for ; Fri, 01 Mar 2019 07:55:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jLIyFAifiRAgcvZD4ggavrGnBhF8t9ofKtSW3O8SPdo=; b=nt1k1fUwJM5poxCxYlEuws5SBVNeAlUTIEUk58bnjvn4bqDaBbUPnWWY9gbMmQ/wM6 bGZEwLv4BPHl+SnqH3Jk5ehTLV/5HtuvoTBKYzpymvyrA9yqh2AiWzOqLodBkRAIOPWc lhQXgBObH4PtSaA6zW4FKU5+dSveES5jH1bmiV2PvzObWsAiTjoyaFeG8gIIQtjsHnV9 JKa5raQ4yO5Xm72T97mn4jKpQr1FOArglRPv8vT7gam1j+QkJhht+MQBDPOp7uyeaUPL s/HjI+NFsHChvIY31DnDWQbj2w59Ga/F4Oidt/Ksf3bVg8u/i9Svib5zIm74DBKvFoNT hlKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=jLIyFAifiRAgcvZD4ggavrGnBhF8t9ofKtSW3O8SPdo=; b=Y283GeemahMkD7sdGribd6UXGAzpXmSjcl68EqXGaJj3FBk3p3oSmDYbZwOhQqL8iY COt5d7FqaNNJORVPokGb0YijieejGYmHdo6TFelBsqQjWb/U9xKb/6GvxWmm84eoe93V PiL/t2IkgGUtqd7AroYMfznHjoMDxcGfFVJc3aCbIy8Sc5fxA318hnfUMPuoLP4PdJyv 8r766UsScQWyp/hmBsJhhb+tFq8Mm2MS4YL0YKOzz4/UW2WZipVkT5SRIKNGndoTEpCg 36rS+Z/mhfrKU5WFIrRd1kFuxh/bHR2ethzO8lfsL/k6mI/WMmcyj36IhL+14WHcND3w watw== X-Gm-Message-State: APjAAAUG2Zuv8SsjapORaNj9YwYt3xLSbbfx4QPFZHsnHmi0iWVDufIe C8UvVI0J2M0u1Tnra6qE7hmY X-Google-Smtp-Source: APXvYqwKdl1qp9Psj2lcXh8SiEEmaJX0plH/RB2i6CpFukg+GA77tAJ9rxSY8+0yTca1CBEA64l8KA== X-Received: by 2002:a63:d80b:: with SMTP id b11mr5440880pgh.168.1551455744564; Fri, 01 Mar 2019 07:55:44 -0800 (PST) Received: from Mani-XPS-13-9360 ([2409:4072:630c:677c:2dd3:3db1:5145:4da9]) by smtp.gmail.com with ESMTPSA id b138sm48505561pfb.48.2019.03.01.07.55.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 07:55:43 -0800 (PST) Date: Fri, 1 Mar 2019 21:25:23 +0530 From: Manivannan Sadhasivam To: Wen Yang , linus.walleij@linaro.org, afaerber@suse.de Subject: Re: [PATCH 01/15] ARM: actions: fix a leaked reference by addingmissing of_node_put Message-ID: <20190301155523.GA1915@Mani-XPS-13-9360> References: <1551430616-42014-1-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1551430616-42014-1-git-send-email-wen.yang99@zte.com.cn> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190301_075546_015324_7C3082D1 X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: heiko@sntech.de, maxime.ripard@bootlin.com, catalin.marinas@arm.com, liviu.dudau@arm.com, michal.simek@xilinx.com, xuwei5@hisilicon.com, tmaimon77@gmail.com, lorenzo.pieralisi@arm.com, yuenn@google.com, will.deacon@arm.com, openbmc@lists.ozlabs.org, magnus.damm@gmail.com, linux@armlinux.org.uk, krzk@kernel.org, linux-samsung-soc@vger.kernel.org, wens@csie.org, kgene@kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-imx@nxp.com, linux-rockchip@lists.infradead.org, brendanhiggins@google.com, wang.yi59@zte.com.cn, rjui@broadcom.com, s.hauer@pengutronix.de, f.fainelli@gmail.com, linux-arm-kernel@lists.infradead.org, sbranden@broadcom.com, avifishman70@gmail.com, venture@google.com, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, dinguyen@kernel.org, horms@verge.net.au, kernel@pengutronix.de, sudeep.holla@arm.com, fabio.estevam@nxp.com, shawnguo@kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Wen, On Fri, Mar 01, 2019 at 04:56:42PM +0800, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > = > Detected by coccinelle with the following warnings: > ./arch/arm/mach-actions/platsmp.c:112:2-8: ERROR: missing of_node_put; ac= quired a node pointer with refcount incremented on line 103, but without a = corresponding object release within this function. > ./arch/arm/mach-actions/platsmp.c:124:2-8: ERROR: missing of_node_put; ac= quired a node pointer with refcount incremented on line 115, but without a = corresponding object release within this function. > ./arch/arm/mach-actions/platsmp.c:137:3-9: ERROR: missing of_node_put; ac= quired a node pointer with refcount incremented on line 128, but without a = corresponding object release within this function. > = We have a floating patch for this: https://www.spinics.net/lists/arm-kernel/msg694544.html Andreas: Can you please take a second look at the patchset submitted by Lin= us Walleij and Russel for simplifying the Actions startup code? Thanks, Mani > Signed-off-by: Wen Yang > Cc: "Andreas F=E4rber" > Cc: Manivannan Sadhasivam > Cc: Russell King > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/mach-actions/platsmp.c | 3 +++ > 1 file changed, 3 insertions(+) > = > diff --git a/arch/arm/mach-actions/platsmp.c b/arch/arm/mach-actions/plat= smp.c > index 4fd479c..1a8e078 100644 > --- a/arch/arm/mach-actions/platsmp.c > +++ b/arch/arm/mach-actions/platsmp.c > @@ -107,6 +107,7 @@ static void __init s500_smp_prepare_cpus(unsigned int= max_cpus) > } > = > timer_base_addr =3D of_iomap(node, 0); > + of_node_put(node); > if (!timer_base_addr) { > pr_err("%s: could not map timer registers\n", __func__); > return; > @@ -119,6 +120,7 @@ static void __init s500_smp_prepare_cpus(unsigned int= max_cpus) > } > = > sps_base_addr =3D of_iomap(node, 0); > + of_node_put(node); > if (!sps_base_addr) { > pr_err("%s: could not map sps registers\n", __func__); > return; > @@ -132,6 +134,7 @@ static void __init s500_smp_prepare_cpus(unsigned int= max_cpus) > } > = > scu_base_addr =3D of_iomap(node, 0); > + of_node_put(node); > if (!scu_base_addr) { > pr_err("%s: could not map scu registers\n", __func__); > return; > -- = > 2.9.5 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel