linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2 1/2] of: Add vendor prefix for Menlo Systems GmbH
@ 2019-03-02 14:50 Marek Vasut
  2019-03-02 14:50 ` [PATCH V2 2/2] ARM: dts: imx53: Add Menlosystems M53 board Marek Vasut
  0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2019-03-02 14:50 UTC (permalink / raw)
  To: linux-arm-kernel; +Cc: Marek Vasut, devicetree, Rob Herring, Shawn Guo

Add vendor prefix for Menlo Systems GmbH, http://www.menlosystems.com/ .

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Reviewed-by: Rob Herring <robh@kernel.org>
To: linux-arm-kernel@lists.infradead.org
---
V2: - Rebase on latest next/master
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index bb6f6e8a2eee..0ccf97d44a32 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -244,6 +244,7 @@ melexis	Melexis N.V.
 melfas	MELFAS Inc.
 mellanox	Mellanox Technologies
 memsic	MEMSIC Inc.
+menlo	Menlo Systems GmbH
 merrii	Merrii Technology Co., Ltd.
 micrel	Micrel Inc.
 microchip	Microchip Technology Inc.
-- 
2.19.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH V2 2/2] ARM: dts: imx53: Add Menlosystems M53 board
  2019-03-02 14:50 [PATCH V2 1/2] of: Add vendor prefix for Menlo Systems GmbH Marek Vasut
@ 2019-03-02 14:50 ` Marek Vasut
  2019-03-04  6:50   ` Shawn Guo
  0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2019-03-02 14:50 UTC (permalink / raw)
  To: linux-arm-kernel; +Cc: Marek Vasut, Shawn Guo

Add device tree for the Menlosystems board based on i.MX53 M53 SoM.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Shawn Guo <shawnguo@kernel.org>
To: linux-arm-kernel@lists.infradead.org
---
V2: - Rebase on latest next/master
---
 arch/arm/boot/dts/Makefile           |   1 +
 arch/arm/boot/dts/imx53-m53menlo.dts | 327 +++++++++++++++++++++++++++
 2 files changed, 328 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx53-m53menlo.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index ebe409a3f0e6..89911779f1a1 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -380,6 +380,7 @@ dtb-$(CONFIG_SOC_IMX53) += \
 	imx53-kp-ddc.dtb \
 	imx53-kp-hsc.dtb \
 	imx53-m53evk.dtb \
+	imx53-m53menlo.dtb \
 	imx53-mba53.dtb \
 	imx53-ppd.dtb \
 	imx53-qsb.dtb \
diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
new file mode 100644
index 000000000000..405a57ad01a7
--- /dev/null
+++ b/arch/arm/boot/dts/imx53-m53menlo.dts
@@ -0,0 +1,327 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2019 Marek Vasut <marex@denx.de>
+ */
+
+/dts-v1/;
+#include "imx53-m53.dtsi"
+
+/ {
+	model = "MENLO M53 EMBEDDED DEVICE";
+	compatible = "fsl,imx53";
+
+	leds {
+		compatible = "gpio-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&led_pin_gpio>;
+
+		user1 {
+			label = "TestLed601";
+			gpios = <&gpio6 1 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "mmc0";
+		};
+
+		user2 {
+			label = "TestLed602";
+			gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
+		};
+
+		eth {
+			label = "EthLedYe";
+			gpios = <&gpio2 11 GPIO_ACTIVE_LOW>;
+			linux,default-trigger = "none";
+		};
+	};
+
+	panel {
+		compatible = "edt,etm070080dh6";
+		enable-gpios = <&gpio6 0 GPIO_ACTIVE_HIGH>;
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&lvds0_out>;
+			};
+		};
+	};
+
+	regulators {
+		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		reg_usbh1_vbus: regulator@3 {
+			compatible = "regulator-fixed";
+			reg = <3>;
+			regulator-name = "vbus";
+			regulator-min-microvolt = <5000000>;
+			regulator-max-microvolt = <5000000>;
+			gpio = <&gpio1 2 0>;
+		};
+	};
+};
+
+&can1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_can1>;
+	status = "okay";
+};
+
+&can2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_can2>;
+	status = "okay";
+};
+
+&clks {
+	assigned-clocks = <&clks IMX5_CLK_CKO1_SEL>,
+			  <&clks IMX5_CLK_CKO1_PODF>,
+			  <&clks IMX5_CLK_CKO1>;
+	assigned-clock-parents = <&clks IMX5_CLK_AHB>;
+	assigned-clock-rates = <133333334>, <33333334>, <33333334>;
+};
+
+&esdhc1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_esdhc1>;
+	cd-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>;
+	wp-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>;
+	status = "okay";
+};
+
+&fec {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_fec>;
+	phy-mode = "rmii";
+	status = "okay";
+};
+
+&i2c1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c1>;
+	status = "okay";
+
+	edt-ft5x06@38 {
+		compatible = "edt,edt-ft5x06";
+		reg = <0x38>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_edt_ft5x06>;
+		interrupt-parent = <&gpio6>;
+		interrupts = <5 GPIO_ACTIVE_LOW>;
+		reset-gpios = <&gpio2 9 GPIO_ACTIVE_LOW>;
+		wake-gpios = <&gpio2 10 GPIO_ACTIVE_HIGH>;
+	};
+
+	eeprom@50 {
+		compatible = "atmel,24c64";
+		reg = <0x50>;
+		pagesize = <32>;
+	};
+
+	dac@60 {
+		compatible = "microchip,mcp4725";
+		reg = <0x60>;
+	};
+};
+
+&i2c2 {
+	stmpe610@41 {
+		status = "disabled";
+	};
+};
+
+&i2c3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c3>;
+	status = "okay";
+};
+
+&iomuxc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog>;
+
+	imx53-m53evk {
+		hoggrp {
+			fsl,pins = <
+				MX53_PAD_GPIO_0__CCM_SSI_EXT1_CLK	0x80000000
+				MX53_PAD_EIM_EB3__GPIO2_31		0x80000000
+				MX53_PAD_PATA_DA_0__GPIO7_6		0x80000000
+				MX53_PAD_GPIO_19__CCM_CLKO		0x1d5
+				MX53_PAD_CSI0_MCLK__CCM_CSI0_MCLK	0x1d5
+				MX53_PAD_CSI0_DAT4__GPIO5_22		0x1d5
+				MX53_PAD_CSI0_DAT5__GPIO5_23		0x1d5
+				MX53_PAD_CSI0_DAT6__GPIO5_24		0x1d5
+				MX53_PAD_CSI0_DAT7__GPIO5_25		0x1d5
+				MX53_PAD_CSI0_DAT8__GPIO5_26		0x1d5
+				MX53_PAD_CSI0_DAT9__GPIO5_27		0x1d5
+				MX53_PAD_CSI0_DAT10__GPIO5_28		0x1d5
+				MX53_PAD_CSI0_DAT11__GPIO5_29		0x1d5
+				MX53_PAD_CSI0_DAT14__GPIO6_0		0x1d5
+			>;
+		};
+
+		led_pin_gpio: led_gpio@0 {
+			fsl,pins = <
+				MX53_PAD_CSI0_DAT15__GPIO6_1		0x1d5
+				MX53_PAD_CSI0_DAT16__GPIO6_2		0x1d5
+			>;
+		};
+
+		pinctrl_can1: can1grp {
+			fsl,pins = <
+				MX53_PAD_GPIO_7__CAN1_TXCAN		0x80000000
+				MX53_PAD_GPIO_8__CAN1_RXCAN		0x80000000
+			>;
+		};
+
+		pinctrl_can2: can2grp {
+			fsl,pins = <
+				MX53_PAD_KEY_COL4__CAN2_TXCAN		0x80000000
+				MX53_PAD_KEY_ROW4__CAN2_RXCAN		0x80000000
+			>;
+		};
+
+		pinctrl_display_gpio: display-gpiogrp {
+			fsl,pins = <
+				MX53_PAD_CSI0_DAT12__GPIO5_30		0x1d5 /* Reset */
+				MX53_PAD_CSI0_DAT13__GPIO5_31		0x1d5 /* Interrupt */
+			>;
+		};
+
+		pinctrl_edt_ft5x06: edt-ft5x06grp {
+			fsl,pins = <
+				MX53_PAD_PATA_DATA9__GPIO2_9		0x1d5 /* Reset */
+				MX53_PAD_CSI0_DAT19__GPIO6_5		0x1d5 /* Interrupt */
+				MX53_PAD_PATA_DATA10__GPIO2_10		0x1d5 /* Wake */
+			>;
+		};
+
+		pinctrl_esdhc1: esdhc1grp {
+			fsl,pins = <
+				MX53_PAD_SD1_DATA0__ESDHC1_DAT0		0x1d5
+				MX53_PAD_SD1_DATA1__ESDHC1_DAT1		0x1d5
+				MX53_PAD_SD1_DATA2__ESDHC1_DAT2		0x1d5
+				MX53_PAD_SD1_DATA3__ESDHC1_DAT3		0x1d5
+				MX53_PAD_SD1_CMD__ESDHC1_CMD		0x1d5
+				MX53_PAD_SD1_CLK__ESDHC1_CLK		0x1d5
+			>;
+		};
+
+		pinctrl_fec: fecgrp {
+			fsl,pins = <
+				MX53_PAD_FEC_MDC__FEC_MDC		0x80000000
+				MX53_PAD_FEC_MDIO__FEC_MDIO		0x80000000
+				MX53_PAD_FEC_REF_CLK__FEC_TX_CLK	0x80000000
+				MX53_PAD_FEC_RX_ER__FEC_RX_ER		0x80000000
+				MX53_PAD_FEC_CRS_DV__FEC_RX_DV		0x80000000
+				MX53_PAD_FEC_RXD1__FEC_RDATA_1		0x80000000
+				MX53_PAD_FEC_RXD0__FEC_RDATA_0		0x80000000
+				MX53_PAD_FEC_TX_EN__FEC_TX_EN		0x80000000
+				MX53_PAD_FEC_TXD1__FEC_TDATA_1		0x80000000
+				MX53_PAD_FEC_TXD0__FEC_TDATA_0		0x80000000
+			>;
+		};
+
+		pinctrl_i2c1: i2c1grp {
+			fsl,pins = <
+				MX53_PAD_EIM_D21__I2C1_SCL		0xc0000000
+				MX53_PAD_EIM_D28__I2C1_SDA		0xc0000000
+			>;
+		};
+
+		pinctrl_i2c3: i2c3grp {
+			fsl,pins = <
+				MX53_PAD_GPIO_6__I2C3_SDA		0xc0000000
+				MX53_PAD_GPIO_5__I2C3_SCL		0xc0000000
+			>;
+		};
+
+		pinctrl_lvds0: lvds0grp {
+			fsl,pins = <
+				MX53_PAD_LVDS0_CLK_P__LDB_LVDS0_CLK	0x80000000
+				MX53_PAD_LVDS0_TX0_P__LDB_LVDS0_TX0	0x80000000
+				MX53_PAD_LVDS0_TX1_P__LDB_LVDS0_TX1	0x80000000
+				MX53_PAD_LVDS0_TX2_P__LDB_LVDS0_TX2	0x80000000
+				MX53_PAD_LVDS0_TX3_P__LDB_LVDS0_TX3	0x80000000
+			>;
+		};
+
+		pinctrl_power_button_gpio: powerbutgrp {
+			fsl,pins = <
+				MX53_PAD_SD2_DATA0__AUDMUX_AUD4_RXD	0x1d5
+			>;
+		};
+
+		pinctrl_power_out_gpio: poweroutgrp {
+			fsl,pins = <
+				MX53_PAD_SD2_DATA2__AUDMUX_AUD4_TXD	0x1d5
+			>;
+		};
+
+		pinctrl_uart1: uart1grp {
+			fsl,pins = <
+				MX53_PAD_PATA_DIOW__UART1_TXD_MUX	0x1e4
+				MX53_PAD_PATA_DMACK__UART1_RXD_MUX	0x1e4
+			>;
+		};
+
+		pinctrl_uart2: uart2grp {
+			fsl,pins = <
+				MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX	0x1e4
+				MX53_PAD_PATA_DMARQ__UART2_TXD_MUX	0x1e4
+			>;
+		};
+
+		pinctrl_usb: usbgrp {
+			fsl,pins = <
+				MX53_PAD_GPIO_2__GPIO1_2		0x80000000
+				MX53_PAD_GPIO_3__USBOH3_USBH1_OC	0x80000000
+			>;
+		};
+	};
+};
+
+&ldb {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_lvds0>;
+	status = "okay";
+
+	lvds0: lvds-channel@0 {
+		fsl,data-mapping = "spwg";
+		fsl,data-width = <18>;
+		status = "okay";
+
+		port@2 {
+			reg = <2>;
+			lvds0_out: endpoint {
+				remote-endpoint = <&panel_in>;
+			};
+		};
+	};
+};
+
+&uart1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart1>;
+	status = "okay";
+};
+
+&uart2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart2>;
+	status = "okay";
+};
+
+&usbh1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usb>;
+	vbus-supply = <&reg_usbh1_vbus>;
+	phy_type = "utmi";
+	dr_mode = "peripheral";
+	status = "okay";
+};
+
+&usbotg {
+	dr_mode = "peripheral";
+	status = "okay";
+};
-- 
2.19.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH V2 2/2] ARM: dts: imx53: Add Menlosystems M53 board
  2019-03-02 14:50 ` [PATCH V2 2/2] ARM: dts: imx53: Add Menlosystems M53 board Marek Vasut
@ 2019-03-04  6:50   ` Shawn Guo
  2019-03-04 12:09     ` Marek Vasut
  0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2019-03-04  6:50 UTC (permalink / raw)
  To: Marek Vasut; +Cc: linux-arm-kernel

On Sat, Mar 02, 2019 at 03:50:32PM +0100, Marek Vasut wrote:
> Add device tree for the Menlosystems board based on i.MX53 M53 SoM.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> To: linux-arm-kernel@lists.infradead.org

Did you use get_maintainer.pl, which will at least suggest the
following folks can help review the patch as well?

Pengutronix Kernel Team <kernel@pengutronix.de>
Fabio Estevam <festevam@gmail.com>
NXP Linux Team <linux-imx@nxp.com>

> ---
> V2: - Rebase on latest next/master
> ---
>  arch/arm/boot/dts/Makefile           |   1 +
>  arch/arm/boot/dts/imx53-m53menlo.dts | 327 +++++++++++++++++++++++++++
>  2 files changed, 328 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx53-m53menlo.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index ebe409a3f0e6..89911779f1a1 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -380,6 +380,7 @@ dtb-$(CONFIG_SOC_IMX53) += \
>  	imx53-kp-ddc.dtb \
>  	imx53-kp-hsc.dtb \
>  	imx53-m53evk.dtb \
> +	imx53-m53menlo.dtb \
>  	imx53-mba53.dtb \
>  	imx53-ppd.dtb \
>  	imx53-qsb.dtb \
> diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
> new file mode 100644
> index 000000000000..405a57ad01a7
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx53-m53menlo.dts
> @@ -0,0 +1,327 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (C) 2019 Marek Vasut <marex@denx.de>
> + */
> +
> +/dts-v1/;
> +#include "imx53-m53.dtsi"
> +
> +/ {
> +	model = "MENLO M53 EMBEDDED DEVICE";
> +	compatible = "fsl,imx53";

With patch #1 adding vendor prefix 'menlo', there is no vendor specific
compatible string defined for the board?

> +
> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&led_pin_gpio>;
> +
> +		user1 {
> +			label = "TestLed601";
> +			gpios = <&gpio6 1 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "mmc0";
> +		};
> +
> +		user2 {
> +			label = "TestLed602";
> +			gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "heartbeat";
> +		};
> +
> +		eth {
> +			label = "EthLedYe";
> +			gpios = <&gpio2 11 GPIO_ACTIVE_LOW>;
> +			linux,default-trigger = "none";
> +		};
> +	};
> +
> +	panel {
> +		compatible = "edt,etm070080dh6";
> +		enable-gpios = <&gpio6 0 GPIO_ACTIVE_HIGH>;
> +
> +		port {
> +			panel_in: endpoint {
> +				remote-endpoint = <&lvds0_out>;
> +			};
> +		};
> +	};
> +
> +	regulators {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		reg_usbh1_vbus: regulator@3 {
> +			compatible = "regulator-fixed";
> +			reg = <3>;
> +			regulator-name = "vbus";
> +			regulator-min-microvolt = <5000000>;
> +			regulator-max-microvolt = <5000000>;
> +			gpio = <&gpio1 2 0>;
> +		};
> +	};
> +};
> +
> +&can1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_can1>;
> +	status = "okay";
> +};
> +
> +&can2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_can2>;
> +	status = "okay";
> +};
> +
> +&clks {
> +	assigned-clocks = <&clks IMX5_CLK_CKO1_SEL>,
> +			  <&clks IMX5_CLK_CKO1_PODF>,
> +			  <&clks IMX5_CLK_CKO1>;
> +	assigned-clock-parents = <&clks IMX5_CLK_AHB>;
> +	assigned-clock-rates = <133333334>, <33333334>, <33333334>;
> +};
> +
> +&esdhc1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_esdhc1>;
> +	cd-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>;
> +	wp-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>;
> +	status = "okay";
> +};
> +
> +&fec {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_fec>;
> +	phy-mode = "rmii";
> +	status = "okay";
> +};
> +
> +&i2c1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c1>;
> +	status = "okay";
> +
> +	edt-ft5x06@38 {

Use generic node name 'touchscreen' as recommended by Devicetree
Specification.

> +		compatible = "edt,edt-ft5x06";
> +		reg = <0x38>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_edt_ft5x06>;
> +		interrupt-parent = <&gpio6>;
> +		interrupts = <5 GPIO_ACTIVE_LOW>;
> +		reset-gpios = <&gpio2 9 GPIO_ACTIVE_LOW>;
> +		wake-gpios = <&gpio2 10 GPIO_ACTIVE_HIGH>;
> +	};
> +
> +	eeprom@50 {
> +		compatible = "atmel,24c64";
> +		reg = <0x50>;
> +		pagesize = <32>;
> +	};
> +
> +	dac@60 {
> +		compatible = "microchip,mcp4725";
> +		reg = <0x60>;
> +	};
> +};
> +
> +&i2c2 {
> +	stmpe610@41 {
> +		status = "disabled";
> +	};
> +};
> +
> +&i2c3 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c3>;
> +	status = "okay";
> +};
> +
> +&iomuxc {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_hog>;
> +
> +	imx53-m53evk {
> +		hoggrp {
> +			fsl,pins = <
> +				MX53_PAD_GPIO_0__CCM_SSI_EXT1_CLK	0x80000000

Please use a proper pad configuration value rather than relying on
something bootloader sets up or out of reset.

> +				MX53_PAD_EIM_EB3__GPIO2_31		0x80000000
> +				MX53_PAD_PATA_DA_0__GPIO7_6		0x80000000
> +				MX53_PAD_GPIO_19__CCM_CLKO		0x1d5
> +				MX53_PAD_CSI0_MCLK__CCM_CSI0_MCLK	0x1d5
> +				MX53_PAD_CSI0_DAT4__GPIO5_22		0x1d5
> +				MX53_PAD_CSI0_DAT5__GPIO5_23		0x1d5
> +				MX53_PAD_CSI0_DAT6__GPIO5_24		0x1d5
> +				MX53_PAD_CSI0_DAT7__GPIO5_25		0x1d5
> +				MX53_PAD_CSI0_DAT8__GPIO5_26		0x1d5
> +				MX53_PAD_CSI0_DAT9__GPIO5_27		0x1d5
> +				MX53_PAD_CSI0_DAT10__GPIO5_28		0x1d5
> +				MX53_PAD_CSI0_DAT11__GPIO5_29		0x1d5
> +				MX53_PAD_CSI0_DAT14__GPIO6_0		0x1d5
> +			>;
> +		};
> +
> +		led_pin_gpio: led_gpio@0 {

The node name doesn't match the naming convention used by other pinctrl
nodes here.  And it makes no sense to have a '0' as unit-address.

> +			fsl,pins = <
> +				MX53_PAD_CSI0_DAT15__GPIO6_1		0x1d5
> +				MX53_PAD_CSI0_DAT16__GPIO6_2		0x1d5
> +			>;
> +		};
> +
> +		pinctrl_can1: can1grp {
> +			fsl,pins = <
> +				MX53_PAD_GPIO_7__CAN1_TXCAN		0x80000000
> +				MX53_PAD_GPIO_8__CAN1_RXCAN		0x80000000
> +			>;
> +		};
> +
> +		pinctrl_can2: can2grp {
> +			fsl,pins = <
> +				MX53_PAD_KEY_COL4__CAN2_TXCAN		0x80000000
> +				MX53_PAD_KEY_ROW4__CAN2_RXCAN		0x80000000
> +			>;
> +		};
> +
> +		pinctrl_display_gpio: display-gpiogrp {
> +			fsl,pins = <
> +				MX53_PAD_CSI0_DAT12__GPIO5_30		0x1d5 /* Reset */
> +				MX53_PAD_CSI0_DAT13__GPIO5_31		0x1d5 /* Interrupt */
> +			>;
> +		};
> +
> +		pinctrl_edt_ft5x06: edt-ft5x06grp {
> +			fsl,pins = <
> +				MX53_PAD_PATA_DATA9__GPIO2_9		0x1d5 /* Reset */
> +				MX53_PAD_CSI0_DAT19__GPIO6_5		0x1d5 /* Interrupt */
> +				MX53_PAD_PATA_DATA10__GPIO2_10		0x1d5 /* Wake */
> +			>;
> +		};
> +
> +		pinctrl_esdhc1: esdhc1grp {
> +			fsl,pins = <
> +				MX53_PAD_SD1_DATA0__ESDHC1_DAT0		0x1d5
> +				MX53_PAD_SD1_DATA1__ESDHC1_DAT1		0x1d5
> +				MX53_PAD_SD1_DATA2__ESDHC1_DAT2		0x1d5
> +				MX53_PAD_SD1_DATA3__ESDHC1_DAT3		0x1d5
> +				MX53_PAD_SD1_CMD__ESDHC1_CMD		0x1d5
> +				MX53_PAD_SD1_CLK__ESDHC1_CLK		0x1d5
> +			>;
> +		};
> +
> +		pinctrl_fec: fecgrp {
> +			fsl,pins = <
> +				MX53_PAD_FEC_MDC__FEC_MDC		0x80000000
> +				MX53_PAD_FEC_MDIO__FEC_MDIO		0x80000000
> +				MX53_PAD_FEC_REF_CLK__FEC_TX_CLK	0x80000000
> +				MX53_PAD_FEC_RX_ER__FEC_RX_ER		0x80000000
> +				MX53_PAD_FEC_CRS_DV__FEC_RX_DV		0x80000000
> +				MX53_PAD_FEC_RXD1__FEC_RDATA_1		0x80000000
> +				MX53_PAD_FEC_RXD0__FEC_RDATA_0		0x80000000
> +				MX53_PAD_FEC_TX_EN__FEC_TX_EN		0x80000000
> +				MX53_PAD_FEC_TXD1__FEC_TDATA_1		0x80000000
> +				MX53_PAD_FEC_TXD0__FEC_TDATA_0		0x80000000
> +			>;
> +		};
> +
> +		pinctrl_i2c1: i2c1grp {
> +			fsl,pins = <
> +				MX53_PAD_EIM_D21__I2C1_SCL		0xc0000000
> +				MX53_PAD_EIM_D28__I2C1_SDA		0xc0000000
> +			>;
> +		};
> +
> +		pinctrl_i2c3: i2c3grp {
> +			fsl,pins = <
> +				MX53_PAD_GPIO_6__I2C3_SDA		0xc0000000
> +				MX53_PAD_GPIO_5__I2C3_SCL		0xc0000000
> +			>;
> +		};
> +
> +		pinctrl_lvds0: lvds0grp {
> +			fsl,pins = <
> +				MX53_PAD_LVDS0_CLK_P__LDB_LVDS0_CLK	0x80000000
> +				MX53_PAD_LVDS0_TX0_P__LDB_LVDS0_TX0	0x80000000
> +				MX53_PAD_LVDS0_TX1_P__LDB_LVDS0_TX1	0x80000000
> +				MX53_PAD_LVDS0_TX2_P__LDB_LVDS0_TX2	0x80000000
> +				MX53_PAD_LVDS0_TX3_P__LDB_LVDS0_TX3	0x80000000
> +			>;
> +		};
> +
> +		pinctrl_power_button_gpio: powerbutgrp {

Doesn't seem to be used.

> +			fsl,pins = <
> +				MX53_PAD_SD2_DATA0__AUDMUX_AUD4_RXD	0x1d5
> +			>;
> +		};
> +
> +		pinctrl_power_out_gpio: poweroutgrp {

Ditto

> +			fsl,pins = <
> +				MX53_PAD_SD2_DATA2__AUDMUX_AUD4_TXD	0x1d5
> +			>;
> +		};
> +
> +		pinctrl_uart1: uart1grp {
> +			fsl,pins = <
> +				MX53_PAD_PATA_DIOW__UART1_TXD_MUX	0x1e4
> +				MX53_PAD_PATA_DMACK__UART1_RXD_MUX	0x1e4
> +			>;
> +		};
> +
> +		pinctrl_uart2: uart2grp {
> +			fsl,pins = <
> +				MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX	0x1e4
> +				MX53_PAD_PATA_DMARQ__UART2_TXD_MUX	0x1e4
> +			>;
> +		};
> +
> +		pinctrl_usb: usbgrp {
> +			fsl,pins = <
> +				MX53_PAD_GPIO_2__GPIO1_2		0x80000000
> +				MX53_PAD_GPIO_3__USBOH3_USBH1_OC	0x80000000
> +			>;
> +		};
> +	};
> +};
> +
> +&ldb {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_lvds0>;
> +	status = "okay";
> +
> +	lvds0: lvds-channel@0 {
> +		fsl,data-mapping = "spwg";
> +		fsl,data-width = <18>;
> +		status = "okay";
> +
> +		port@2 {
> +			reg = <2>;

Have a newline between properties and child node.

Shawn

> +			lvds0_out: endpoint {
> +				remote-endpoint = <&panel_in>;
> +			};
> +		};
> +	};
> +};
> +
> +&uart1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_uart1>;
> +	status = "okay";
> +};
> +
> +&uart2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_uart2>;
> +	status = "okay";
> +};
> +
> +&usbh1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usb>;
> +	vbus-supply = <&reg_usbh1_vbus>;
> +	phy_type = "utmi";
> +	dr_mode = "peripheral";
> +	status = "okay";
> +};
> +
> +&usbotg {
> +	dr_mode = "peripheral";
> +	status = "okay";
> +};
> -- 
> 2.19.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH V2 2/2] ARM: dts: imx53: Add Menlosystems M53 board
  2019-03-04  6:50   ` Shawn Guo
@ 2019-03-04 12:09     ` Marek Vasut
  0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2019-03-04 12:09 UTC (permalink / raw)
  To: Shawn Guo; +Cc: linux-arm-kernel

On 3/4/19 7:50 AM, Shawn Guo wrote:
> On Sat, Mar 02, 2019 at 03:50:32PM +0100, Marek Vasut wrote:
>> Add device tree for the Menlosystems board based on i.MX53 M53 SoM.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> To: linux-arm-kernel@lists.infradead.org
> 
> Did you use get_maintainer.pl, which will at least suggest the
> following folks can help review the patch as well?
> 
> Pengutronix Kernel Team <kernel@pengutronix.de>
> Fabio Estevam <festevam@gmail.com>
> NXP Linux Team <linux-imx@nxp.com>

get-maintainer.pl also gives you quite a few unrelated results, so one
has to apply moderation.

>> ---
>> V2: - Rebase on latest next/master
>> ---
>>  arch/arm/boot/dts/Makefile           |   1 +
>>  arch/arm/boot/dts/imx53-m53menlo.dts | 327 +++++++++++++++++++++++++++
>>  2 files changed, 328 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/imx53-m53menlo.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index ebe409a3f0e6..89911779f1a1 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -380,6 +380,7 @@ dtb-$(CONFIG_SOC_IMX53) += \
>>  	imx53-kp-ddc.dtb \
>>  	imx53-kp-hsc.dtb \
>>  	imx53-m53evk.dtb \
>> +	imx53-m53menlo.dtb \
>>  	imx53-mba53.dtb \
>>  	imx53-ppd.dtb \
>>  	imx53-qsb.dtb \
>> diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
>> new file mode 100644
>> index 000000000000..405a57ad01a7
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imx53-m53menlo.dts
>> @@ -0,0 +1,327 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (C) 2019 Marek Vasut <marex@denx.de>
>> + */
>> +
>> +/dts-v1/;
>> +#include "imx53-m53.dtsi"
>> +
>> +/ {
>> +	model = "MENLO M53 EMBEDDED DEVICE";
>> +	compatible = "fsl,imx53";
> 
> With patch #1 adding vendor prefix 'menlo', there is no vendor specific
> compatible string defined for the board?

Fixed

>> +
>> +	leds {
>> +		compatible = "gpio-leds";
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&led_pin_gpio>;
>> +
>> +		user1 {
>> +			label = "TestLed601";
>> +			gpios = <&gpio6 1 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "mmc0";
>> +		};
>> +
>> +		user2 {
>> +			label = "TestLed602";
>> +			gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "heartbeat";
>> +		};
>> +
>> +		eth {
>> +			label = "EthLedYe";
>> +			gpios = <&gpio2 11 GPIO_ACTIVE_LOW>;
>> +			linux,default-trigger = "none";
>> +		};
>> +	};
>> +
>> +	panel {
>> +		compatible = "edt,etm070080dh6";
>> +		enable-gpios = <&gpio6 0 GPIO_ACTIVE_HIGH>;
>> +
>> +		port {
>> +			panel_in: endpoint {
>> +				remote-endpoint = <&lvds0_out>;
>> +			};
>> +		};
>> +	};
>> +
>> +	regulators {
>> +		compatible = "simple-bus";
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +		reg_usbh1_vbus: regulator@3 {
>> +			compatible = "regulator-fixed";
>> +			reg = <3>;
>> +			regulator-name = "vbus";
>> +			regulator-min-microvolt = <5000000>;
>> +			regulator-max-microvolt = <5000000>;
>> +			gpio = <&gpio1 2 0>;
>> +		};
>> +	};
>> +};
>> +
>> +&can1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_can1>;
>> +	status = "okay";
>> +};
>> +
>> +&can2 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_can2>;
>> +	status = "okay";
>> +};
>> +
>> +&clks {
>> +	assigned-clocks = <&clks IMX5_CLK_CKO1_SEL>,
>> +			  <&clks IMX5_CLK_CKO1_PODF>,
>> +			  <&clks IMX5_CLK_CKO1>;
>> +	assigned-clock-parents = <&clks IMX5_CLK_AHB>;
>> +	assigned-clock-rates = <133333334>, <33333334>, <33333334>;
>> +};
>> +
>> +&esdhc1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_esdhc1>;
>> +	cd-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>;
>> +	wp-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>;
>> +	status = "okay";
>> +};
>> +
>> +&fec {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_fec>;
>> +	phy-mode = "rmii";
>> +	status = "okay";
>> +};
>> +
>> +&i2c1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_i2c1>;
>> +	status = "okay";
>> +
>> +	edt-ft5x06@38 {
> 
> Use generic node name 'touchscreen' as recommended by Devicetree
> Specification.

Fixed

>> +		compatible = "edt,edt-ft5x06";
>> +		reg = <0x38>;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&pinctrl_edt_ft5x06>;
>> +		interrupt-parent = <&gpio6>;
>> +		interrupts = <5 GPIO_ACTIVE_LOW>;
>> +		reset-gpios = <&gpio2 9 GPIO_ACTIVE_LOW>;
>> +		wake-gpios = <&gpio2 10 GPIO_ACTIVE_HIGH>;
>> +	};
>> +
>> +	eeprom@50 {
>> +		compatible = "atmel,24c64";
>> +		reg = <0x50>;
>> +		pagesize = <32>;
>> +	};
>> +
>> +	dac@60 {
>> +		compatible = "microchip,mcp4725";
>> +		reg = <0x60>;
>> +	};
>> +};
>> +
>> +&i2c2 {
>> +	stmpe610@41 {
>> +		status = "disabled";
>> +	};
>> +};
>> +
>> +&i2c3 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_i2c3>;
>> +	status = "okay";
>> +};
>> +
>> +&iomuxc {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_hog>;
>> +
>> +	imx53-m53evk {
>> +		hoggrp {
>> +			fsl,pins = <
>> +				MX53_PAD_GPIO_0__CCM_SSI_EXT1_CLK	0x80000000
> 
> Please use a proper pad configuration value rather than relying on
> something bootloader sets up or out of reset.
> 
>> +				MX53_PAD_EIM_EB3__GPIO2_31		0x80000000
>> +				MX53_PAD_PATA_DA_0__GPIO7_6		0x80000000
>> +				MX53_PAD_GPIO_19__CCM_CLKO		0x1d5
>> +				MX53_PAD_CSI0_MCLK__CCM_CSI0_MCLK	0x1d5
>> +				MX53_PAD_CSI0_DAT4__GPIO5_22		0x1d5
>> +				MX53_PAD_CSI0_DAT5__GPIO5_23		0x1d5
>> +				MX53_PAD_CSI0_DAT6__GPIO5_24		0x1d5
>> +				MX53_PAD_CSI0_DAT7__GPIO5_25		0x1d5
>> +				MX53_PAD_CSI0_DAT8__GPIO5_26		0x1d5
>> +				MX53_PAD_CSI0_DAT9__GPIO5_27		0x1d5
>> +				MX53_PAD_CSI0_DAT10__GPIO5_28		0x1d5
>> +				MX53_PAD_CSI0_DAT11__GPIO5_29		0x1d5
>> +				MX53_PAD_CSI0_DAT14__GPIO6_0		0x1d5
>> +			>;
>> +		};
>> +
>> +		led_pin_gpio: led_gpio@0 {
> 
> The node name doesn't match the naming convention used by other pinctrl
> nodes here.  And it makes no sense to have a '0' as unit-address.
> 
>> +			fsl,pins = <
>> +				MX53_PAD_CSI0_DAT15__GPIO6_1		0x1d5
>> +				MX53_PAD_CSI0_DAT16__GPIO6_2		0x1d5
>> +			>;
>> +		};
>> +
>> +		pinctrl_can1: can1grp {
>> +			fsl,pins = <
>> +				MX53_PAD_GPIO_7__CAN1_TXCAN		0x80000000
>> +				MX53_PAD_GPIO_8__CAN1_RXCAN		0x80000000
>> +			>;
>> +		};
>> +
>> +		pinctrl_can2: can2grp {
>> +			fsl,pins = <
>> +				MX53_PAD_KEY_COL4__CAN2_TXCAN		0x80000000
>> +				MX53_PAD_KEY_ROW4__CAN2_RXCAN		0x80000000
>> +			>;
>> +		};
>> +
>> +		pinctrl_display_gpio: display-gpiogrp {
>> +			fsl,pins = <
>> +				MX53_PAD_CSI0_DAT12__GPIO5_30		0x1d5 /* Reset */
>> +				MX53_PAD_CSI0_DAT13__GPIO5_31		0x1d5 /* Interrupt */
>> +			>;
>> +		};
>> +
>> +		pinctrl_edt_ft5x06: edt-ft5x06grp {
>> +			fsl,pins = <
>> +				MX53_PAD_PATA_DATA9__GPIO2_9		0x1d5 /* Reset */
>> +				MX53_PAD_CSI0_DAT19__GPIO6_5		0x1d5 /* Interrupt */
>> +				MX53_PAD_PATA_DATA10__GPIO2_10		0x1d5 /* Wake */
>> +			>;
>> +		};
>> +
>> +		pinctrl_esdhc1: esdhc1grp {
>> +			fsl,pins = <
>> +				MX53_PAD_SD1_DATA0__ESDHC1_DAT0		0x1d5
>> +				MX53_PAD_SD1_DATA1__ESDHC1_DAT1		0x1d5
>> +				MX53_PAD_SD1_DATA2__ESDHC1_DAT2		0x1d5
>> +				MX53_PAD_SD1_DATA3__ESDHC1_DAT3		0x1d5
>> +				MX53_PAD_SD1_CMD__ESDHC1_CMD		0x1d5
>> +				MX53_PAD_SD1_CLK__ESDHC1_CLK		0x1d5
>> +			>;
>> +		};
>> +
>> +		pinctrl_fec: fecgrp {
>> +			fsl,pins = <
>> +				MX53_PAD_FEC_MDC__FEC_MDC		0x80000000
>> +				MX53_PAD_FEC_MDIO__FEC_MDIO		0x80000000
>> +				MX53_PAD_FEC_REF_CLK__FEC_TX_CLK	0x80000000
>> +				MX53_PAD_FEC_RX_ER__FEC_RX_ER		0x80000000
>> +				MX53_PAD_FEC_CRS_DV__FEC_RX_DV		0x80000000
>> +				MX53_PAD_FEC_RXD1__FEC_RDATA_1		0x80000000
>> +				MX53_PAD_FEC_RXD0__FEC_RDATA_0		0x80000000
>> +				MX53_PAD_FEC_TX_EN__FEC_TX_EN		0x80000000
>> +				MX53_PAD_FEC_TXD1__FEC_TDATA_1		0x80000000
>> +				MX53_PAD_FEC_TXD0__FEC_TDATA_0		0x80000000
>> +			>;
>> +		};
>> +
>> +		pinctrl_i2c1: i2c1grp {
>> +			fsl,pins = <
>> +				MX53_PAD_EIM_D21__I2C1_SCL		0xc0000000
>> +				MX53_PAD_EIM_D28__I2C1_SDA		0xc0000000
>> +			>;
>> +		};
>> +
>> +		pinctrl_i2c3: i2c3grp {
>> +			fsl,pins = <
>> +				MX53_PAD_GPIO_6__I2C3_SDA		0xc0000000
>> +				MX53_PAD_GPIO_5__I2C3_SCL		0xc0000000
>> +			>;
>> +		};
>> +
>> +		pinctrl_lvds0: lvds0grp {
>> +			fsl,pins = <
>> +				MX53_PAD_LVDS0_CLK_P__LDB_LVDS0_CLK	0x80000000
>> +				MX53_PAD_LVDS0_TX0_P__LDB_LVDS0_TX0	0x80000000
>> +				MX53_PAD_LVDS0_TX1_P__LDB_LVDS0_TX1	0x80000000
>> +				MX53_PAD_LVDS0_TX2_P__LDB_LVDS0_TX2	0x80000000
>> +				MX53_PAD_LVDS0_TX3_P__LDB_LVDS0_TX3	0x80000000
>> +			>;
>> +		};
>> +
>> +		pinctrl_power_button_gpio: powerbutgrp {
> 
> Doesn't seem to be used.
> 
>> +			fsl,pins = <
>> +				MX53_PAD_SD2_DATA0__AUDMUX_AUD4_RXD	0x1d5
>> +			>;
>> +		};
>> +
>> +		pinctrl_power_out_gpio: poweroutgrp {
> 
> Ditto

Dropped, I'll readd those once I have the new hardware available.

>> +			fsl,pins = <
>> +				MX53_PAD_SD2_DATA2__AUDMUX_AUD4_TXD	0x1d5
>> +			>;
>> +		};
>> +
>> +		pinctrl_uart1: uart1grp {
>> +			fsl,pins = <
>> +				MX53_PAD_PATA_DIOW__UART1_TXD_MUX	0x1e4
>> +				MX53_PAD_PATA_DMACK__UART1_RXD_MUX	0x1e4
>> +			>;
>> +		};
>> +
>> +		pinctrl_uart2: uart2grp {
>> +			fsl,pins = <
>> +				MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX	0x1e4
>> +				MX53_PAD_PATA_DMARQ__UART2_TXD_MUX	0x1e4
>> +			>;
>> +		};
>> +
>> +		pinctrl_usb: usbgrp {
>> +			fsl,pins = <
>> +				MX53_PAD_GPIO_2__GPIO1_2		0x80000000
>> +				MX53_PAD_GPIO_3__USBOH3_USBH1_OC	0x80000000
>> +			>;
>> +		};
>> +	};
>> +};
>> +
>> +&ldb {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_lvds0>;
>> +	status = "okay";
>> +
>> +	lvds0: lvds-channel@0 {
>> +		fsl,data-mapping = "spwg";
>> +		fsl,data-width = <18>;
>> +		status = "okay";
>> +
>> +		port@2 {
>> +			reg = <2>;
> 
> Have a newline between properties and child node.

OK

> Shawn
> 
>> +			lvds0_out: endpoint {
>> +				remote-endpoint = <&panel_in>;
>> +			};
>> +		};
>> +	};
>> +};
>> +
>> +&uart1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_uart1>;
>> +	status = "okay";
>> +};
>> +
>> +&uart2 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_uart2>;
>> +	status = "okay";
>> +};
>> +
>> +&usbh1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_usb>;
>> +	vbus-supply = <&reg_usbh1_vbus>;
>> +	phy_type = "utmi";
>> +	dr_mode = "peripheral";
>> +	status = "okay";
>> +};
>> +
>> +&usbotg {
>> +	dr_mode = "peripheral";
>> +	status = "okay";
>> +};
>> -- 
>> 2.19.2
>>


-- 
Best regards,
Marek Vasut

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-04 12:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-02 14:50 [PATCH V2 1/2] of: Add vendor prefix for Menlo Systems GmbH Marek Vasut
2019-03-02 14:50 ` [PATCH V2 2/2] ARM: dts: imx53: Add Menlosystems M53 board Marek Vasut
2019-03-04  6:50   ` Shawn Guo
2019-03-04 12:09     ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).