From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2918C43381 for ; Sun, 3 Mar 2019 03:11:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7776E20863 for ; Sun, 3 Mar 2019 03:11:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mQVUkJTS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="czRkAxwO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7776E20863 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qL8Xn/JVo+KsNZoS1d8EsahKggYSk2dBYV5bVF6Xzhw=; b=mQVUkJTSXSpltM 6acebWny9JFG6sO/w8t7HzP4JP4fF+mHiLLh+bIg/C8h8/atze8TNf23e8LpSHEOGh2fd04gqFdG/ bjUiVBzrBEkjCOmQOGiOMK6Rvfkkg8s+QcwFr+0CtVtu0AtYLYTwsgTUFKktxNcBMHapLcxI9x8bv 5S1ZXaEGMuOOnqtYfC9CG3HLy7M/zfx1C5mdMx99wa/geEq2+A1K+IXgui8kfX0S7bns05b5eJV/y zVH34mzDx2DdwgYV1pLKuA7QoU9AjE7lc5DgA1K63j9SAWLX3+3Qx3AMM8/YB5xBb9jJeeD/RNwFb dZoR4Bu/PAFyRDPvHhUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0HXS-0008MP-Pg; Sun, 03 Mar 2019 03:11:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0HXP-0008M2-E4 for linux-arm-kernel@lists.infradead.org; Sun, 03 Mar 2019 03:11:41 +0000 Received: from dragon (61-216-91-114.HINET-IP.hinet.net [61.216.91.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D9BF20863; Sun, 3 Mar 2019 03:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551582694; bh=9oDcEAADtKog8aJWEyzC1qr9kTZCUYAo5SRPpKJdl+8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=czRkAxwOW7TfOHxL4WLsR9EX/VWKyRbhXEyNsnDWRH6MeGMCUf0ihDI/scTK4HALr QIMsVZcD/rfcKxNZz4kVro/Dt/k8dgdJUpdYc386/26fqHWLpHkHnJQEC+2AQhp1qD JAzKelvboxXM0viamcabUK+aRfSxTzU1trFaibDo= Date: Sun, 3 Mar 2019 11:10:33 +0800 From: Shawn Guo To: Tim Harvey Subject: Re: [PATCH] ARM: dts: imx: Add TDA19971 HDMI Receiver to GW54xx Message-ID: <20190303031030.GR26041@dragon> References: <20190301163253.12191-1-tharvey@gateworks.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190301163253.12191-1-tharvey@gateworks.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190302_191139_514427_113C15A6 X-CRM114-Status: GOOD ( 20.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 01, 2019 at 08:32:53AM -0800, Tim Harvey wrote: > The GW54xx has a front-panel microHDMI connector routed to a TDA19971 > which is connected the the IPU CSI when using IMX6Q. > > Signed-off-by: Tim Harvey > --- > arch/arm/boot/dts/imx6q-gw54xx.dts | 105 ++++++++++++++++++++++++++ > arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 29 ++++++- > 2 files changed, 131 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6q-gw54xx.dts b/arch/arm/boot/dts/imx6q-gw54xx.dts > index 56e5b5050fcf..cb0a5f7d5a19 100644 > --- a/arch/arm/boot/dts/imx6q-gw54xx.dts > +++ b/arch/arm/boot/dts/imx6q-gw54xx.dts > @@ -12,10 +12,30 @@ > /dts-v1/; > #include "imx6q.dtsi" > #include "imx6qdl-gw54xx.dtsi" > +#include > > / { > model = "Gateworks Ventana i.MX6 Dual/Quad GW54XX"; > compatible = "gw,imx6q-gw54xx", "gw,ventana", "fsl,imx6q"; > + > + sound-digital { > + compatible = "simple-audio-card"; > + simple-audio-card,name = "tda1997x-audio"; > + > + simple-audio-card,dai-link@0 { > + format = "i2s"; > + > + cpu { > + sound-dai = <&ssi2>; > + }; > + > + codec { > + bitclock-master; > + frame-master; > + sound-dai = <&hdmi_receiver>; > + }; > + }; > + }; > }; > > &i2c3 { > @@ -35,6 +55,61 @@ > }; > }; > }; > + > + hdmi_receiver: hdmi-receiver@48 { > + compatible = "nxp,tda19971"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_tda1997x>; > + reg = <0x48>; > + interrupt-parent = <&gpio1>; > + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; > + DOVDD-supply = <®_3p3v>; > + AVDD-supply = <&sw4_reg>; > + DVDD-supply = <&sw4_reg>; > + #sound-dai-cells = <0>; > + nxp,audout-format = "i2s"; > + nxp,audout-layout = <0>; > + nxp,audout-width = <16>; > + nxp,audout-mclk-fs = <128>; > + /* > + * The 8bpp YUV422 semi-planar mode outputs CbCr[11:4] > + * and Y[11:4] across 16bits in the same cycle > + * which we map to VP[15:08]<->CSI_DATA[19:12] > + */ > + nxp,vidout-portcfg = > + /*G_Y_11_8<->VP[15:12]<->CSI_DATA[19:16]*/ > + < TDA1997X_VP24_V15_12 TDA1997X_G_Y_11_8 >, > + /*G_Y_7_4<->VP[11:08]<->CSI_DATA[15:12]*/ > + < TDA1997X_VP24_V11_08 TDA1997X_G_Y_7_4 >, > + /*R_CR_CBCR_11_8<->VP[07:04]<->CSI_DATA[11:08]*/ > + < TDA1997X_VP24_V07_04 TDA1997X_R_CR_CBCR_11_8 >, > + /*R_CR_CBCR_7_4<->VP[03:00]<->CSI_DATA[07:04]*/ > + < TDA1997X_VP24_V03_00 TDA1997X_R_CR_CBCR_7_4 >; > + > + port { > + tda1997x_to_ipu1_csi0_mux: endpoint { > + remote-endpoint = <&ipu1_csi0_mux_from_parallel_sensor>; > + bus-width = <16>; > + hsync-active = <1>; > + vsync-active = <1>; > + data-active = <1>; > + }; > + }; > + }; > +}; > + > +&ipu1_csi0_from_ipu1_csi0_mux { > + bus-width = <16>; > +}; > + > +&ipu1_csi0_mux_from_parallel_sensor { > + remote-endpoint = <&tda1997x_to_ipu1_csi0_mux>; > + bus-width = <16>; > +}; > + > +&ipu1_csi0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ipu1_csi0>; > }; > > &ipu2_csi1_from_ipu2_csi1_mux { > @@ -63,6 +138,30 @@ > >; > }; > > + pinctrl_ipu1_csi0: ipu1_csi0grp { > + fsl,pins = < > + MX6QDL_PAD_CSI0_DAT4__IPU1_CSI0_DATA04 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT5__IPU1_CSI0_DATA05 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT6__IPU1_CSI0_DATA06 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT7__IPU1_CSI0_DATA07 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT8__IPU1_CSI0_DATA08 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT9__IPU1_CSI0_DATA09 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT10__IPU1_CSI0_DATA10 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT11__IPU1_CSI0_DATA11 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT12__IPU1_CSI0_DATA12 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT13__IPU1_CSI0_DATA13 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT14__IPU1_CSI0_DATA14 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT15__IPU1_CSI0_DATA15 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT16__IPU1_CSI0_DATA16 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT17__IPU1_CSI0_DATA17 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT18__IPU1_CSI0_DATA18 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT19__IPU1_CSI0_DATA19 0x1b0b0 > + MX6QDL_PAD_CSI0_MCLK__IPU1_CSI0_HSYNC 0x1b0b0 > + MX6QDL_PAD_CSI0_PIXCLK__IPU1_CSI0_PIXCLK 0x1b0b0 > + MX6QDL_PAD_CSI0_VSYNC__IPU1_CSI0_VSYNC 0x1b0b0 > + >; > + }; > + > pinctrl_ipu2_csi1: ipu2_csi1grp { > fsl,pins = < > MX6QDL_PAD_EIM_EB2__IPU2_CSI1_DATA19 0x1b0b0 > @@ -78,4 +177,10 @@ > MX6QDL_PAD_EIM_A16__IPU2_CSI1_PIXCLK 0x1b0b0 > >; > }; > + > + pinctrl_tda1997x: tda1997xgrp { > + fsl,pins = < > + MX6QDL_PAD_GPIO_7__GPIO1_IO07 0x1b0b0 > + >; > + }; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > index 81b2fcf6eedf..1cbc7baf09dc 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > @@ -10,6 +10,7 @@ > */ > > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -115,12 +116,12 @@ > }; > }; > > - sound { > + sound-analog { > compatible = "fsl,imx6q-ventana-sgtl5000", > "fsl,imx-audio-sgtl5000"; > model = "sgtl5000-audio"; > ssi-controller = <&ssi1>; > - audio-codec = <&codec>; > + audio-codec = <&sgtl5000>; > audio-routing = > "MIC_IN", "Mic Jack", > "Mic Jack", "Mic Bias", > @@ -134,6 +135,25 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_audmux>; /* AUD4<->sgtl5000 */ > status = "okay"; > + > + ssi2 { > + fsl,audmux-port = <1>; > + fsl,port-config = < > + (IMX_AUDMUX_V2_PTCR_TFSDIR | > + IMX_AUDMUX_V2_PTCR_TFSEL(4+8) | /* RXFS */ > + IMX_AUDMUX_V2_PTCR_TCLKDIR | > + IMX_AUDMUX_V2_PTCR_TCSEL(4+8) | /* RXC */ > + IMX_AUDMUX_V2_PTCR_SYN) > + IMX_AUDMUX_V2_PDCR_RXDSEL(4) > + >; > + }; > + > + aud5 { > + fsl,audmux-port = <4>; > + fsl,port-config = < > + IMX_AUDMUX_V2_PTCR_SYN > + IMX_AUDMUX_V2_PDCR_RXDSEL(1)>; > + }; > }; > > &can1 { > @@ -332,7 +352,7 @@ > pinctrl-0 = <&pinctrl_i2c3>; > status = "okay"; > > - codec: sgtl5000@a { > + sgtl5000: codec@a { While we are improve it, audio-codec is the best node name as per Devicetree Specification. I fixed it up and applied the patch. Shawn > compatible = "fsl,sgtl5000"; > reg = <0x0a>; > clocks = <&clks IMX6QDL_CLK_CKO>; > @@ -476,6 +496,9 @@ > MX6QDL_PAD_SD2_DAT2__AUD4_TXD 0x110b0 > MX6QDL_PAD_SD2_DAT1__AUD4_TXFS 0x130b0 > MX6QDL_PAD_GPIO_0__CCM_CLKO1 0x130b0 /* AUD4_MCK */ > + MX6QDL_PAD_EIM_D25__AUD5_RXC 0x130b0 > + MX6QDL_PAD_DISP0_DAT19__AUD5_RXD 0x130b0 > + MX6QDL_PAD_EIM_D24__AUD5_RXFS 0x130b0 > >; > }; > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel