From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8103C43381 for ; Mon, 4 Mar 2019 05:38:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73BD221019 for ; Mon, 4 Mar 2019 05:38:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ivc1s/OQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="kHq1wItZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73BD221019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VRuvipLPmJFTWfOC4FilOSTptMSTo40Vz59XCNcppsY=; b=ivc1s/OQcnbtKe /GS8U+bfh6MaR2zGZfIt6J2A204bSY4zz231qjkhRgp863BrIyYVYRzpTL48lpq4HVZxComBFW+fJ Sxz5ocK5YVzVYh2ZLaMUtUYhWHoVXlySGH/xYfNCAbzgEqREoB6yxU00Q3WrZrw4WqEbqHSloxpuM wvnpwCuqmj7HV8Of3j2919i+Rd5Hxl36pvTj0Kzxzfr6i/huHGoR0fBl41qt0Py+ViOjnYLsTO3Vv RW+C3eLe54qUCxDY314BrtR1SNq/qCDslmnVrxnlsNkEzBFLbfMyxZ26HRIkQv9NRXN3/54SRayKH LauJhXQvrxxJtvEVwCrg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0gJ5-0003B8-Oy; Mon, 04 Mar 2019 05:38:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0gJ2-0003Am-Rg; Mon, 04 Mar 2019 05:38:30 +0000 Received: from dragon (61-216-91-114.HINET-IP.hinet.net [61.216.91.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7747620815; Mon, 4 Mar 2019 05:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551677908; bh=g7AHdyOzT/zu/ZiJT1tf4ulU/osU03BVGW6r8HW1WMU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kHq1wItZ2IcNUbI2+Dn4y51A2o+v5TX84QIIskJyEnT/EWfRNd4KLq7LI4TcVtDWI IsBAr0tJbLL7rb14rPi2pO6RgaznJpRt5qBaFX3makMfC09M8een7JdjM1ZIj8K2n5 2hv873k7oaLKvUfjhF1cRFQYINuVJgUqoKWKsRdk= Date: Mon, 4 Mar 2019 13:37:15 +0800 From: Shawn Guo To: Wen Yang Subject: Re: [PATCH 05/15] ARM: imx51: fix a leaked reference by addingmissing of_node_put Message-ID: <20190304053714.GZ26041@dragon> References: <1551430616-42014-1-git-send-email-wen.yang99@zte.com.cn> <1551430616-42014-5-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1551430616-42014-5-git-send-email-wen.yang99@zte.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190303_213828_915031_FF0948F5 X-CRM114-Status: UNSURE ( 8.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: heiko@sntech.de, maxime.ripard@bootlin.com, catalin.marinas@arm.com, linus.walleij@linaro.org, liviu.dudau@arm.com, michal.simek@xilinx.com, xuwei5@hisilicon.com, manivannan.sadhasivam@linaro.org, Fabio Estevam , tmaimon77@gmail.com, f.fainelli@gmail.com, linux-rockchip@lists.infradead.org, will.deacon@arm.com, openbmc@lists.ozlabs.org, magnus.damm@gmail.com, linux@armlinux.org.uk, krzk@kernel.org, linux-samsung-soc@vger.kernel.org, wens@csie.org, kgene@kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-imx@nxp.com, brendanhiggins@google.com, wang.yi59@zte.com.cn, rjui@broadcom.com, s.hauer@pengutronix.de, lorenzo.pieralisi@arm.com, yuenn@google.com, linux-arm-kernel@lists.infradead.org, sbranden@broadcom.com, avifishman70@gmail.com, venture@google.com, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, dinguyen@kernel.org, horms@verge.net.au, kernel@pengutronix.de, sudeep.holla@arm.com, fabio.estevam@nxp.com, afaerber@suse.de, Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 01, 2019 at 04:56:46PM +0800, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-imx/mach-imx51.c:64:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 57, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel