From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B437C43381 for ; Mon, 4 Mar 2019 10:08:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C85220835 for ; Mon, 4 Mar 2019 10:08:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="luLH2y/L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C85220835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pFCB5CDi5rV1JPX6VCOSvtOYz9BAkUwSIxsPRLRkCSA=; b=luLH2y/LeTjwPI aKC4vXpJr+9JTNgk+kIUcUSo3fqDSwIwXErivp8JLD82uYhWj+v3NuS5qYzsf8uCdKZ8YboUNj33f JfyejB7MPIA8E11tXrO7CuiIIRfw1x103WT8lthdUCypn/ptmXaJYAI3n9zLOAvP3fpquqNX1pK/j LKbJFHIXbMc+kpe68wexPvBsQZAprGb+4p9wPlAKDYJxGeHloW76qf6k75XW9Fn2UvWgfT8AwPTQS U7t6gzFJ1gQHEkjvseBYGNSMJTew9gzHSwCZlpLgdpDqbOPeT8WQPSOs8JmCX4dCCCahcYenmeckO LxoIebc9xw8MG7bVgw8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0kVx-00051w-L9; Mon, 04 Mar 2019 10:08:05 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0kVv-00051a-4I for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2019 10:08:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 71338EBD; Mon, 4 Mar 2019 02:08:02 -0800 (PST) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7A4103F703; Mon, 4 Mar 2019 02:07:59 -0800 (PST) Date: Mon, 4 Mar 2019 10:07:56 +0000 From: Sudeep Holla To: Andy Lutomirski Subject: Re: [PATCH 3/6] x86: clean up _TIF_SYSCALL_EMU handling using ptrace_syscall_enter hook Message-ID: <20190304100756.GB32379@e107155-lin> References: <20190228183220.15626-1-sudeep.holla@arm.com> <20190228183220.15626-4-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_020803_176104_5943FDB7 X-CRM114-Status: GOOD ( 17.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haibo Xu , Steve Capper , Catalin Marinas , Jeff Dike , X86 ML , Will Deacon , LKML , Oleg Nesterov , Richard Weinberger , Ingo Molnar , Paul Mackerras , Michael Ellerman , Borislav Petkov , Thomas Gleixner , Bin Lu , linuxppc-dev , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 02, 2019 at 05:11:40PM -0800, Andy Lutomirski wrote: > On Thu, Feb 28, 2019 at 10:32 AM Sudeep Holla wrote: > > > > Now that we have a new hook ptrace_syscall_enter that can be called from > > syscall entry code and it handles PTRACE_SYSEMU in generic code, we > > can do some cleanup using the same in syscall_trace_enter. > > > > Further the extra logic to find single stepping PTRACE_SYSEMU_SINGLESTEP > > in syscall_slow_exit_work seems unnecessary. Let's remove the same. > > I wasn't cc'd on the whole series, so I can't easily review this. Do > you have a test case to make sure that emulation still works? Are > there adequate tests in tools/testing/selftests/x86? Do they still > pass after this patch? > I will ensure you are cc-ed on the whole threads, sorry for missing. I remember seeing some selftests, but I haven't run them yet. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel