public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Marek Vasut <marek.vasut@gmail.com>,
	Simon Horman <horms+renesas@verge.net.au>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Marek Vasut <marek.vasut+renesas@gmail.com>
Subject: Re: [PATCH] ARM: dts: alt: Add DA9063 PMIC node
Date: Mon, 4 Mar 2019 11:57:05 +0100	[thread overview]
Message-ID: <20190304105705.GA1000@kunai> (raw)
In-Reply-To: <CAMuHMdWStD+on70-e1p0SXbe2igNJxDM1RzeYsdXW+80SA9+sw@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 792 bytes --]


> > Add DA9063 PMIC node to the I2C bus.
> >
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> 
> Thanks for your patch!
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks for CCing me, I didn't get and missed the original patch.

> > +++ b/arch/arm/boot/dts/r8a7794-alt.dts
> > @@ -377,6 +377,27 @@
> >         pinctrl-names = "i2c-exio4";
> >  };
> >
> > +&i2c7 {
> > +       status = "okay";
> > +       clock-frequency = <100000>;
> 
> According to the DA9063 datasheet, the PMIC supports up to 400 kHz.
> It looks like there are no other devices on the bus.
> 
> Wolfram, what's your stance on this?

Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but
seems not. Probably it slipped through the cracks.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-03-04 10:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-03 19:00 [PATCH] ARM: dts: alt: Add DA9063 PMIC node marek.vasut
2019-03-04 10:35 ` Geert Uytterhoeven
2019-03-04 10:57   ` Wolfram Sang [this message]
2019-03-04 10:59     ` Marek Vasut
2019-03-04 11:13       ` Wolfram Sang
2019-03-08 13:40         ` Simon Horman
2019-03-08 13:52           ` Marek Vasut
2019-03-08 14:53             ` Wolfram Sang
2019-03-08 17:46               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190304105705.GA1000@kunai \
    --to=wsa@the-dreams.de \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=horms+renesas@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=marek.vasut@gmail.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox