* [PATCH] ARM: dts: alt: Add DA9063 PMIC node
@ 2019-03-03 19:00 marek.vasut
2019-03-04 10:35 ` Geert Uytterhoeven
0 siblings, 1 reply; 9+ messages in thread
From: marek.vasut @ 2019-03-03 19:00 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-renesas-soc, Simon Horman, Geert Uytterhoeven, Marek Vasut
From: Marek Vasut <marek.vasut+renesas@gmail.com>
Add DA9063 PMIC node to the I2C bus.
Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Simon Horman <horms+renesas@verge.net.au>
Cc: linux-renesas-soc@vger.kernel.org
To: linux-arm-kernel@lists.infradead.org
---
NOTE: R8A7794 Alt does not share the PMIC IRQ line with other PMICs,
hence the regulator-quirk-rcar-gen2.c does not need a new entry.
---
arch/arm/boot/dts/r8a7794-alt.dts | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
index ef7e2a837df6..e0500ec81569 100644
--- a/arch/arm/boot/dts/r8a7794-alt.dts
+++ b/arch/arm/boot/dts/r8a7794-alt.dts
@@ -377,6 +377,27 @@
pinctrl-names = "i2c-exio4";
};
+&i2c7 {
+ status = "okay";
+ clock-frequency = <100000>;
+
+ pmic@58 {
+ compatible = "dlg,da9063";
+ reg = <0x58>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-controller;
+
+ rtc {
+ compatible = "dlg,da9063-rtc";
+ };
+
+ wdt {
+ compatible = "dlg,da9063-watchdog";
+ };
+ };
+};
+
&vin0 {
status = "okay";
pinctrl-0 = <&vin0_pins>;
--
2.19.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] ARM: dts: alt: Add DA9063 PMIC node 2019-03-03 19:00 [PATCH] ARM: dts: alt: Add DA9063 PMIC node marek.vasut @ 2019-03-04 10:35 ` Geert Uytterhoeven 2019-03-04 10:57 ` Wolfram Sang 0 siblings, 1 reply; 9+ messages in thread From: Geert Uytterhoeven @ 2019-03-04 10:35 UTC (permalink / raw) To: Marek Vasut Cc: Geert Uytterhoeven, Linux-Renesas, Wolfram Sang, Simon Horman, Linux ARM, Marek Vasut Hi Marek, On Sun, Mar 3, 2019 at 8:01 PM <marek.vasut@gmail.com> wrote: > From: Marek Vasut <marek.vasut+renesas@gmail.com> > > Add DA9063 PMIC node to the I2C bus. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/arch/arm/boot/dts/r8a7794-alt.dts > +++ b/arch/arm/boot/dts/r8a7794-alt.dts > @@ -377,6 +377,27 @@ > pinctrl-names = "i2c-exio4"; > }; > > +&i2c7 { > + status = "okay"; > + clock-frequency = <100000>; According to the DA9063 datasheet, the PMIC supports up to 400 kHz. It looks like there are no other devices on the bus. Wolfram, what's your stance on this? > + > + pmic@58 { > + compatible = "dlg,da9063"; > + reg = <0x58>; > + interrupt-parent = <&gpio3>; > + interrupts = <31 IRQ_TYPE_LEVEL_LOW>; > + interrupt-controller; > + > + rtc { > + compatible = "dlg,da9063-rtc"; > + }; > + > + wdt { > + compatible = "dlg,da9063-watchdog"; > + }; > + }; > +}; > + Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: alt: Add DA9063 PMIC node 2019-03-04 10:35 ` Geert Uytterhoeven @ 2019-03-04 10:57 ` Wolfram Sang 2019-03-04 10:59 ` Marek Vasut 0 siblings, 1 reply; 9+ messages in thread From: Wolfram Sang @ 2019-03-04 10:57 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Geert Uytterhoeven, Wolfram Sang, Linux-Renesas, Marek Vasut, Simon Horman, Linux ARM, Marek Vasut [-- Attachment #1.1: Type: text/plain, Size: 792 bytes --] > > Add DA9063 PMIC node to the I2C bus. > > > > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks for CCing me, I didn't get and missed the original patch. > > +++ b/arch/arm/boot/dts/r8a7794-alt.dts > > @@ -377,6 +377,27 @@ > > pinctrl-names = "i2c-exio4"; > > }; > > > > +&i2c7 { > > + status = "okay"; > > + clock-frequency = <100000>; > > According to the DA9063 datasheet, the PMIC supports up to 400 kHz. > It looks like there are no other devices on the bus. > > Wolfram, what's your stance on this? Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but seems not. Probably it slipped through the cracks. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: alt: Add DA9063 PMIC node 2019-03-04 10:57 ` Wolfram Sang @ 2019-03-04 10:59 ` Marek Vasut 2019-03-04 11:13 ` Wolfram Sang 0 siblings, 1 reply; 9+ messages in thread From: Marek Vasut @ 2019-03-04 10:59 UTC (permalink / raw) To: Wolfram Sang, Geert Uytterhoeven Cc: Geert Uytterhoeven, Linux-Renesas, Wolfram Sang, Simon Horman, Linux ARM, Marek Vasut On 3/4/19 11:57 AM, Wolfram Sang wrote: > >>> Add DA9063 PMIC node to the I2C bus. >>> >>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >> >> Thanks for your patch! >> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Thanks for CCing me, I didn't get and missed the original patch. > >>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts >>> @@ -377,6 +377,27 @@ >>> pinctrl-names = "i2c-exio4"; >>> }; >>> >>> +&i2c7 { >>> + status = "okay"; >>> + clock-frequency = <100000>; >> >> According to the DA9063 datasheet, the PMIC supports up to 400 kHz. >> It looks like there are no other devices on the bus. >> >> Wolfram, what's your stance on this? > > Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but > seems not. Probably it slipped through the cracks. Do we want to update all of the other boards too ? I'd be cautious about the DVFS I2C, running faster while talking to the PMIC and reading/writing a few registers brings little benefit, while the signal integrity might be impacted. -- Best regards, Marek Vasut _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: alt: Add DA9063 PMIC node 2019-03-04 10:59 ` Marek Vasut @ 2019-03-04 11:13 ` Wolfram Sang 2019-03-08 13:40 ` Simon Horman 0 siblings, 1 reply; 9+ messages in thread From: Wolfram Sang @ 2019-03-04 11:13 UTC (permalink / raw) To: Marek Vasut Cc: Geert Uytterhoeven, Linux-Renesas, Wolfram Sang, Geert Uytterhoeven, Simon Horman, Linux ARM, Marek Vasut [-- Attachment #1.1: Type: text/plain, Size: 1516 bytes --] On Mon, Mar 04, 2019 at 11:59:48AM +0100, Marek Vasut wrote: > On 3/4/19 11:57 AM, Wolfram Sang wrote: > > > >>> Add DA9063 PMIC node to the I2C bus. > >>> > >>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > >> > >> Thanks for your patch! > >> > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Thanks for CCing me, I didn't get and missed the original patch. > > > >>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts > >>> @@ -377,6 +377,27 @@ > >>> pinctrl-names = "i2c-exio4"; > >>> }; > >>> > >>> +&i2c7 { > >>> + status = "okay"; > >>> + clock-frequency = <100000>; > >> > >> According to the DA9063 datasheet, the PMIC supports up to 400 kHz. > >> It looks like there are no other devices on the bus. > >> > >> Wolfram, what's your stance on this? > > > > Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but > > seems not. Probably it slipped through the cracks. > > Do we want to update all of the other boards too ? > > I'd be cautious about the DVFS I2C, running faster while talking to the > PMIC and reading/writing a few registers brings little benefit, while > the signal integrity might be impacted. Can be argued. I think if we would apply some testing on top of this change, we will find that it will work. But we would in deed need this testing as verification, and this is not our top priority project. But if someone feels like running some i2c dumping over night, well, why not.. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: alt: Add DA9063 PMIC node 2019-03-04 11:13 ` Wolfram Sang @ 2019-03-08 13:40 ` Simon Horman 2019-03-08 13:52 ` Marek Vasut 0 siblings, 1 reply; 9+ messages in thread From: Simon Horman @ 2019-03-08 13:40 UTC (permalink / raw) To: Wolfram Sang Cc: Geert Uytterhoeven, Wolfram Sang, Linux-Renesas, Marek Vasut, Geert Uytterhoeven, Linux ARM, Marek Vasut On Mon, Mar 04, 2019 at 12:13:49PM +0100, Wolfram Sang wrote: > On Mon, Mar 04, 2019 at 11:59:48AM +0100, Marek Vasut wrote: > > On 3/4/19 11:57 AM, Wolfram Sang wrote: > > > > > >>> Add DA9063 PMIC node to the I2C bus. > > >>> > > >>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > > >> > > >> Thanks for your patch! > > >> > > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > > Thanks for CCing me, I didn't get and missed the original patch. > > > > > >>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts > > >>> @@ -377,6 +377,27 @@ > > >>> pinctrl-names = "i2c-exio4"; > > >>> }; > > >>> > > >>> +&i2c7 { > > >>> + status = "okay"; > > >>> + clock-frequency = <100000>; > > >> > > >> According to the DA9063 datasheet, the PMIC supports up to 400 kHz. > > >> It looks like there are no other devices on the bus. > > >> > > >> Wolfram, what's your stance on this? > > > > > > Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but > > > seems not. Probably it slipped through the cracks. > > > > Do we want to update all of the other boards too ? > > > > I'd be cautious about the DVFS I2C, running faster while talking to the > > PMIC and reading/writing a few registers brings little benefit, while > > the signal integrity might be impacted. > > Can be argued. I think if we would apply some testing on top of this > change, we will find that it will work. But we would in deed need this > testing as verification, and this is not our top priority project. But > if someone feels like running some i2c dumping over night, well, > why not.. Thanks, I've applied this patch for v5.2. We can do a sweep of frequency updates as a follow-up if we decide that is the right way to go. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: alt: Add DA9063 PMIC node 2019-03-08 13:40 ` Simon Horman @ 2019-03-08 13:52 ` Marek Vasut 2019-03-08 14:53 ` Wolfram Sang 0 siblings, 1 reply; 9+ messages in thread From: Marek Vasut @ 2019-03-08 13:52 UTC (permalink / raw) To: Simon Horman, Wolfram Sang Cc: Geert Uytterhoeven, Linux-Renesas, Wolfram Sang, Geert Uytterhoeven, Linux ARM, Marek Vasut On 3/8/19 2:40 PM, Simon Horman wrote: > On Mon, Mar 04, 2019 at 12:13:49PM +0100, Wolfram Sang wrote: >> On Mon, Mar 04, 2019 at 11:59:48AM +0100, Marek Vasut wrote: >>> On 3/4/19 11:57 AM, Wolfram Sang wrote: >>>> >>>>>> Add DA9063 PMIC node to the I2C bus. >>>>>> >>>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >>>>> >>>>> Thanks for your patch! >>>>> >>>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >>>> >>>> Thanks for CCing me, I didn't get and missed the original patch. >>>> >>>>>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts >>>>>> @@ -377,6 +377,27 @@ >>>>>> pinctrl-names = "i2c-exio4"; >>>>>> }; >>>>>> >>>>>> +&i2c7 { >>>>>> + status = "okay"; >>>>>> + clock-frequency = <100000>; >>>>> >>>>> According to the DA9063 datasheet, the PMIC supports up to 400 kHz. >>>>> It looks like there are no other devices on the bus. >>>>> >>>>> Wolfram, what's your stance on this? >>>> >>>> Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but >>>> seems not. Probably it slipped through the cracks. >>> >>> Do we want to update all of the other boards too ? >>> >>> I'd be cautious about the DVFS I2C, running faster while talking to the >>> PMIC and reading/writing a few registers brings little benefit, while >>> the signal integrity might be impacted. >> >> Can be argued. I think if we would apply some testing on top of this >> change, we will find that it will work. But we would in deed need this >> testing as verification, and this is not our top priority project. But >> if someone feels like running some i2c dumping over night, well, >> why not.. > > Thanks, > > I've applied this patch for v5.2. > We can do a sweep of frequency updates as a follow-up if we decide > that is the right way to go. Do we really want to speed up the PMIC I2C bus ? What are the pros (none?) and cons (might be unstable) ? -- Best regards, Marek Vasut _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: alt: Add DA9063 PMIC node 2019-03-08 13:52 ` Marek Vasut @ 2019-03-08 14:53 ` Wolfram Sang 2019-03-08 17:46 ` Marek Vasut 0 siblings, 1 reply; 9+ messages in thread From: Wolfram Sang @ 2019-03-08 14:53 UTC (permalink / raw) To: Marek Vasut Cc: Geert Uytterhoeven, Linux-Renesas, Wolfram Sang, Simon Horman, Geert Uytterhoeven, Linux ARM, Marek Vasut [-- Attachment #1.1: Type: text/plain, Size: 168 bytes --] > Do we really want to speed up the PMIC I2C bus ? What are the pros > (none?) and cons (might be unstable) ? Then let's go down to 10kHz instead? Even more stable. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: alt: Add DA9063 PMIC node 2019-03-08 14:53 ` Wolfram Sang @ 2019-03-08 17:46 ` Marek Vasut 0 siblings, 0 replies; 9+ messages in thread From: Marek Vasut @ 2019-03-08 17:46 UTC (permalink / raw) To: Wolfram Sang Cc: Geert Uytterhoeven, Linux-Renesas, Wolfram Sang, Simon Horman, Geert Uytterhoeven, Linux ARM, Marek Vasut On 3/8/19 3:53 PM, Wolfram Sang wrote: > >> Do we really want to speed up the PMIC I2C bus ? What are the pros >> (none?) and cons (might be unstable) ? > > Then let's go down to 10kHz instead? Even more stable. 100 kHz and 400 kHz seem to be the most often used I2C frequencies, maybe we should stick to those, since I presume Dialog tested the PMIC with at least those two. -- Best regards, Marek Vasut _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-03-08 17:46 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-03-03 19:00 [PATCH] ARM: dts: alt: Add DA9063 PMIC node marek.vasut 2019-03-04 10:35 ` Geert Uytterhoeven 2019-03-04 10:57 ` Wolfram Sang 2019-03-04 10:59 ` Marek Vasut 2019-03-04 11:13 ` Wolfram Sang 2019-03-08 13:40 ` Simon Horman 2019-03-08 13:52 ` Marek Vasut 2019-03-08 14:53 ` Wolfram Sang 2019-03-08 17:46 ` Marek Vasut
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).