From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA980C43381 for ; Mon, 4 Mar 2019 11:13:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AAA9620663 for ; Mon, 4 Mar 2019 11:13:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WJzAI6DU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAA9620663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jXeIlW1xt4tKser+XZnxx0V9YB2dndxQUG5ao334YdM=; b=WJzAI6DUVa0Zxyn9+tMf3ixX0 C2XGoN9rOy/YTJIB/WzaoEyv91k3phrJH0F+RIrgDzjmwKTdFE5kyhDFr/0EkiPAu5KauqKWZD6u9 nzawtNuwnVYI37I2DbdsAcdY6F70wW2+p+L7g9x4R104rZCS3pPrpv9kLyL6VRnC/K0SwNr3PGtPG 0SazIuWMrmJWNpoz23CT5ekkJ9Ioa7xDK5ieWOijAf78bcmafPSqwzKWP85NWumibQh8/IEMkWaBM ksBx/ZpD6lvg9cZnXrwcSEnZvMwssZnndt56Botbn60xAF6/fpTNaT9Qrhdc8ucVUeilp6IxYHnPS 5udIIFN6Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0lXd-0004m1-Uz; Mon, 04 Mar 2019 11:13:53 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0lXa-0004lf-Ku for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2019 11:13:52 +0000 Received: from localhost (p54B337B5.dip0.t-ipconnect.de [84.179.55.181]) by pokefinder.org (Postfix) with ESMTPSA id CD15A2C3637; Mon, 4 Mar 2019 12:13:49 +0100 (CET) Date: Mon, 4 Mar 2019 12:13:49 +0100 From: Wolfram Sang To: Marek Vasut Subject: Re: [PATCH] ARM: dts: alt: Add DA9063 PMIC node Message-ID: <20190304111349.GB1000@kunai> References: <20190303190059.31155-1-marek.vasut@gmail.com> <20190304105705.GA1000@kunai> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_031350_830331_C002A414 X-CRM114-Status: GOOD ( 16.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , Linux-Renesas , Wolfram Sang , Geert Uytterhoeven , Simon Horman , Linux ARM , Marek Vasut Content-Type: multipart/mixed; boundary="===============5430704774462870497==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5430704774462870497== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="z6Eq5LdranGa6ru8" Content-Disposition: inline --z6Eq5LdranGa6ru8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 04, 2019 at 11:59:48AM +0100, Marek Vasut wrote: > On 3/4/19 11:57 AM, Wolfram Sang wrote: > >=20 > >>> Add DA9063 PMIC node to the I2C bus. > >>> > >>> Signed-off-by: Marek Vasut > >> > >> Thanks for your patch! > >> > >> Reviewed-by: Geert Uytterhoeven > >=20 > > Thanks for CCing me, I didn't get and missed the original patch. > >=20 > >>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts > >>> @@ -377,6 +377,27 @@ > >>> pinctrl-names =3D "i2c-exio4"; > >>> }; > >>> > >>> +&i2c7 { > >>> + status =3D "okay"; > >>> + clock-frequency =3D <100000>; > >> > >> According to the DA9063 datasheet, the PMIC supports up to 400 kHz. > >> It looks like there are no other devices on the bus. > >> > >> Wolfram, what's your stance on this? > >=20 > > Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but > > seems not. Probably it slipped through the cracks. >=20 > Do we want to update all of the other boards too ? >=20 > I'd be cautious about the DVFS I2C, running faster while talking to the > PMIC and reading/writing a few registers brings little benefit, while > the signal integrity might be impacted. Can be argued. I think if we would apply some testing on top of this change, we will find that it will work. But we would in deed need this testing as verification, and this is not our top priority project. But if someone feels like running some i2c dumping over night, well, why not.. --z6Eq5LdranGa6ru8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlx9CG0ACgkQFA3kzBSg KbaFuA//bUF+TvT2LjDMnMFuQfvpzqAp1SnBmUXOPnUbL4wtEY7a5d9xZ7ArwfJa m4n0kD1FoZqXqrBP0EUKkE4gJb0ji+aFZrBREfWy0bei51uwKCKOyNRkLzsDAA4X q+MG+ghZW+gUiB93TXyFZz5msMz/VFgOk2gGupxqADUxMY88xeLTHpHsJl3ie0TT UeNFGSmcmAzkyNtPnIaJzm0Dx7wZ+1eNz0z2+ecoPMTMFw2DCMug4zsY9f8u7HDj ZPkQXcOFP009qovwjCgzSl4chX5TTA6MZcoaZFa1Ylb7mVIBncb5m7sX6IwWzmex HlQ7TKuP0PKGin0n4Gl6gDbpmFdndgy94TO7qilRlq2Vg/P2MJPxztoKQLOggkoD VLuvK8YTsikOcZfhgHILIkiGTEa6q7xCZfaBnXYSIuZJ18Lnz0pO9xnNRC79TCiJ TxpYf6TFRqk4xR40LFidIXLP8eXCyR2UFIhAISPNt9LyQZHhS2rC4+wbXmdeo3kI +pzgW+Hno8KhDY37tCwFkBlOoEp0+JaA89wpnfBbCbIVO7xGWp2LCCN0oZAMS2ZO yP2mFabXMcTGK7VFcA4iuXsYxl93zidgtOtObwk3fRcZlQEqH6Qv3tUH+CRvHLJs Q+EcDcDmCfqvJm5dirHFqyvTTgtG8BUT8AXyn+kC23ylj9xvHNk= =trPV -----END PGP SIGNATURE----- --z6Eq5LdranGa6ru8-- --===============5430704774462870497== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5430704774462870497==--