From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27286C43381 for ; Mon, 4 Mar 2019 12:27:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E374F2070B for ; Mon, 4 Mar 2019 12:27:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bdUbT6IB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E374F2070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6DlVTh4YImmF0VCBRkA0NDbaRcuPLW0uN9CjBqra88w=; b=bdUbT6IBZQmCYk 4m4MTWoa+M6Uu/edm+2U13kAgMeuPWvItsHqBp3oXGNUkzZ51Q7Or2ymoSJACwb1by1sFOScpMnit ha6CmNJLpMQ79Je6HelIa4r32fPtz3+q1vJPkbyZsv+uFTB5A5gB9adtKE/lDqbwR5dDJYDm1Ccxd XedlCjSVF8PQcZEUctS8WLNSp1CtrG3z8IH5PH43NTV5DZHonSAjkE/Sr8EEpuN50IaP7Q/X4vP5s AM9oapCg+GrgDDwOFRCt64d650VjZou6yvKrnC9vcyna0JVvqGt31ybCAKZ+4iML+eaHlCF0SL6GA 33LD0amUDsKe5e9x5oGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0mgj-0007oI-MN; Mon, 04 Mar 2019 12:27:21 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0mgh-0007nz-HQ for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2019 12:27:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 436BDA78; Mon, 4 Mar 2019 04:27:19 -0800 (PST) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 960DB3F575; Mon, 4 Mar 2019 04:27:16 -0800 (PST) Date: Mon, 4 Mar 2019 12:27:11 +0000 From: Sudeep Holla To: Segher Boessenkool Subject: Re: [PATCH 2/6] ptrace: introduce ptrace_syscall_enter to consolidate PTRACE_SYSEMU handling Message-ID: <20190304122711.GA28624@e107155-lin> References: <20190228183220.15626-1-sudeep.holla@arm.com> <20190228183220.15626-3-sudeep.holla@arm.com> <20190304104643.GA28643@e107155-lin> <20190304122331.GG3969@gate.crashing.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190304122331.GG3969@gate.crashing.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_042719_583648_916F090C X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Haibo Xu \(Arm Technology China\)" , Steve Capper , Catalin Marinas , "jdike@addtoit.com" , "x86@kernel.org" , Will Deacon , "linux-kernel@vger.kernel.org" , Oleg Nesterov , Ingo Molnar , Paul Mackerras , Richard Weinberger , Thomas Gleixner , "Bin Lu \(Arm Technology China\)" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 04, 2019 at 06:23:32AM -0600, Segher Boessenkool wrote: > On Mon, Mar 04, 2019 at 10:46:43AM +0000, Sudeep Holla wrote: > > On Mon, Mar 04, 2019 at 08:03:47AM +0000, Haibo Xu (Arm Technology China) wrote: > > > On 2019/3/1 2:32, Sudeep Holla wrote: > > > > +long ptrace_syscall_enter(struct pt_regs *regs) > > > > +{ > > > > +#ifdef TIF_SYSCALL_EMU > > > > + if (test_thread_flag(TIF_SYSCALL_EMU)) { > > > > + if (tracehook_report_syscall_entry(regs)); > > > > > > Shall we remove the semi-colon at end of the above line? > > > > Added intentionally to keep GCC happy. > > GCC warns because the user explicitly asked for it, with __must_check. > If you want to do things with an "if" like this, you should write e.g. > > if (tracehook_report_syscall_entry(regs)) > /* > * We can ignore the return code here, because of > * X and Y and Z. > */ > ; > > Or it probably is nicer to use a block: > > if (tracehook_report_syscall_entry(regs)) { > /* > * We can ignore the return code here, because of > * X and Y and Z. > */ > } > > The point is, you *always* should have a nice fat comment if you are > ignoring the return code of a __must_check function. > Agreed, will add the comment. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel