From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D94C10F03 for ; Mon, 4 Mar 2019 14:46:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0496B20815 for ; Mon, 4 Mar 2019 14:46:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UUZYB8bv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0496B20815 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lkGmi3dogWfQMPTiZ2ai5QXYCjMk/qseyuhWA6cd1XI=; b=UUZYB8bvDTuIdO k4ehRdDHyPE8EZ52opQBz81q8e6aS+6uo+GpujB/cxBpGJ3JIDWeVdIfil6K8tD4yq2+6Ky9kJv3s Rdi3Y22+aPAR6hjmR7YIiSP5FUFuxem7R/+fQCXx+NUYT002kgzJUeJtOXrgndpBqgzGxiMEgVgom J4LYmSOm2WEv9LUC6aX0qpIfX99tbQAwZ4dIXFq6YKp3H3lzP69A2luPELxq6ryTgeAgv7GJ1ko4N RdufIickT02iWmuU2IH0MmQOBaVaYiGUm10PRlPLXhXkgCXBn4bI27akM2xQ6IOJ6dLp10saYyUPE 1gHiffEaiJH05Ll6BJGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0orH-0003J0-Ns; Mon, 04 Mar 2019 14:46:23 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0orE-0003Ia-9Z; Mon, 04 Mar 2019 14:46:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 61FB1EBD; Mon, 4 Mar 2019 06:46:19 -0800 (PST) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3CB503F71D; Mon, 4 Mar 2019 06:46:13 -0800 (PST) Date: Mon, 4 Mar 2019 14:46:06 +0000 From: Sudeep Holla To: Wen Yang Subject: Re: [PATCH 12/15] ARM: vexpress: fix a leaked reference by addingmissing of_node_put Message-ID: <20190304144606.GA7466@e107155-lin> References: <1551430616-42014-1-git-send-email-wen.yang99@zte.com.cn> <1551430616-42014-12-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1551430616-42014-12-git-send-email-wen.yang99@zte.com.cn> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_064620_340241_DAE941C1 X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: heiko@sntech.de, maxime.ripard@bootlin.com, catalin.marinas@arm.com, linus.walleij@linaro.org, liviu.dudau@arm.com, michal.simek@xilinx.com, xuwei5@hisilicon.com, manivannan.sadhasivam@linaro.org, tmaimon77@gmail.com, f.fainelli@gmail.com, linux-rockchip@lists.infradead.org, will.deacon@arm.com, openbmc@lists.ozlabs.org, magnus.damm@gmail.com, linux@armlinux.org.uk, krzk@kernel.org, linux-samsung-soc@vger.kernel.org, wens@csie.org, kgene@kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-imx@nxp.com, brendanhiggins@google.com, wang.yi59@zte.com.cn, rjui@broadcom.com, s.hauer@pengutronix.de, lorenzo.pieralisi@arm.com, yuenn@google.com, linux-arm-kernel@lists.infradead.org, sbranden@broadcom.com, avifishman70@gmail.com, venture@google.com, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, dinguyen@kernel.org, horms@verge.net.au, kernel@pengutronix.de, fabio.estevam@nxp.com, shawnguo@kernel.org, afaerber@suse.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 01, 2019 at 04:56:53PM +0800, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-vexpress/dcscb.c:150:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. > ./arch/arm/mach-vexpress/dcscb.c:160:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. > ./arch/arm/mach-vexpress/dcscb.c:171:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang > Cc: Liviu Dudau > Cc: Sudeep Holla Looks good, assuming you want to take this as a series. Please shout if you want us to take this. Acked-by: Sudeep Holla -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel