From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D913BC10F03 for ; Mon, 4 Mar 2019 14:48:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A894720815 for ; Mon, 4 Mar 2019 14:48:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CsBMQhqB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fJ7xw8Jd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A894720815 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wiix3ADQcjzaKEHvF7ekGDykT6TztTwTnUWBSY6KW4A=; b=CsBMQhqBpaftdq uxHvBbCFAI22saRWLwVHVvyvAUYbVtm/xTvBE1H2UzzsbnwUUPpUhPzv2L9EKuXXXK/k+FHP+gEBH 8L8YG1G1x4dVMnn81jpijJE+6VuDneORsrxQKDVk0BKwH9asq6Ueu0ixonFE/ppegtTePqzkstlRR 7bzADCtEy/BhRRBnfhkfnmjFcsyX0Kt+iaQXjUoebEN/ufsm0Kpy/SZbOcvJbgHQuY7D+0BGMkLY2 ZSo5VsIE+S6ErkjvBTh/XSqf8W+oz1teS+9l7AyQ+u6F7V0JcquUe6VRlQnAM5zYTqLl6EytJkO/4 FS35IKEa+XKwfXe6f+8Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0otg-0004GR-Dg; Mon, 04 Mar 2019 14:48:52 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0otc-0004Ey-4e for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2019 14:48:49 +0000 Received: by mail-pg1-x542.google.com with SMTP id h11so3269589pgl.0 for ; Mon, 04 Mar 2019 06:48:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5M7OwyO6HgUrUJtcdI80kaZEhRjVtvCmXtUf3SxvANc=; b=fJ7xw8JdMM4dAArAke476bB1uuQCPCkRpvrEuv694j/65AqpQw4dwu0rT0PLE8CMUq 8ZZdQa1JhYV/PFADTEKW8EQf740m7UiBQafFMPw0f+JWB6gkNQT1sRny56yLgtwfbyam BOXTPFokqTqcXuP1LyUJ3aB7CeOLkIh9sxSpzOQTkgls61EHY1hX56biugQNpS8QZSxd mKv1oHHQCqBB5tpWWqtGljY/YWIdAs6CEidAP37ohcKFD7YG14I6eQ4YCA53qJzIxWko 9MDgc2PyBF6FA1jwGT8IxR4EuM/jf6gZCESscyiP3T75KlE9ZaP4HRq+cF6o6IYWVkyo Zc8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5M7OwyO6HgUrUJtcdI80kaZEhRjVtvCmXtUf3SxvANc=; b=YLY1jYeK4kGTB8y0x7iLwEDPhvAz3uZYIWgH+TJjPM55T623RAT+PJw9dI2I78lRsR +YRD8L53zeJNhIyzO6xE91R+QDyWg/Ykb/hi/X52H9vng9K7kLES8mZaRTF38mb/l4Tw xcjNdeDW36mKyARV/9gCThlF0apvbkGvCHgxB5o+l0YY8VeH/vLdzMiJpyFBQU5nmNLW F5xc0qxv+XyKEAMqjcu+LnuQQaKemfnaq7Dc1qPA50BiVF9V1uLLBrVV2/PiUkYKLQMv D0XNGaimeffIIB1cGfqCpiAebntZ6a1CrlO9hyRs7UocNg0OXzj7HjjmBbMk7XtCLUTe WlNg== X-Gm-Message-State: APjAAAXBZj9503sTo6cbXcpcSNrNu12XWPwV+cDve2z37bQAQj+Rw5GH tzzdFlMmKUBtwdjGcj8x/zY+ X-Google-Smtp-Source: APXvYqzFd3N9m0cOwhgb2geq+smMS20gI7hq9k0RX5n0UIhO8QQjfez/wbEryv8i0R0DnsQNDgpong== X-Received: by 2002:a63:f07:: with SMTP id e7mr18909505pgl.173.1551710926837; Mon, 04 Mar 2019 06:48:46 -0800 (PST) Received: from Mani-XPS-13-9360 ([2409:4072:88c:f338:bc65:e0ee:7524:9950]) by smtp.gmail.com with ESMTPSA id 63sm10441906pfy.110.2019.03.04.06.48.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Mar 2019 06:48:46 -0800 (PST) Date: Mon, 4 Mar 2019 20:18:29 +0530 From: Manivannan Sadhasivam To: Linus Walleij Subject: Re: [PATCH 01/15] ARM: actions: fix a leaked reference by addingmissing of_node_put Message-ID: <20190304144829.GA5265@Mani-XPS-13-9360> References: <1551430616-42014-1-git-send-email-wen.yang99@zte.com.cn> <20190301155523.GA1915@Mani-XPS-13-9360> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_064848_293628_1D105FBF X-CRM114-Status: GOOD ( 22.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko =?iso-8859-1?Q?St=FCbner?= , Maxime Ripard , Catalin Marinas , Liviu Dudau , Russell King , Xu Wei , Wen Yang , Tomer Maimon , Lorenzo Pieralisi , "open list:ARM/Rockchip SoC..." , Will Deacon , OpenBMC Maillist , Magnus Damm , Michal Simek , Krzysztof Kozlowski , linux-samsung-soc , Chen-Yu Tsai , Kukjin Kim , bcm-kernel-feedback-list , NXP Linux Team , Brendan Higgins , wang.yi59@zte.com.cn, Ray Jui , Sascha Hauer , Florian Fainelli , Nancy Yuen , Linux ARM , Scott Branden , avifishman70@gmail.com, Patrick Venture , "linux-kernel@vger.kernel.org" , Linux-Renesas , Dinh Nguyen , Simon Horman , Sascha Hauer , Sudeep Holla , Fabio Estevam , Shawn Guo , Andreas =?iso-8859-1?Q?F=E4rber?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Linus, On Mon, Mar 04, 2019 at 01:29:33PM +0100, Linus Walleij wrote: > On Fri, Mar 1, 2019 at 4:55 PM Manivannan Sadhasivam > wrote: > > Hi Wen, > > > > On Fri, Mar 01, 2019 at 04:56:42PM +0800, Wen Yang wrote: > > > The call to of_get_next_child returns a node pointer with refcount > > > incremented thus it must be explicitly decremented after the last > > > usage. > > > > > > Detected by coccinelle with the following warnings: > > > ./arch/arm/mach-actions/platsmp.c:112:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 103, but without a corresponding object release within this function. > > > ./arch/arm/mach-actions/platsmp.c:124:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 115, but without a corresponding object release within this function. > > > ./arch/arm/mach-actions/platsmp.c:137:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 128, but without a corresponding object release within this function. > > > > > > > We have a floating patch for this: > > https://www.spinics.net/lists/arm-kernel/msg694544.html > > > > Andreas: Can you please take a second look at the patchset submitted by Linus > > Walleij and Russel for simplifying the Actions startup code? > > Andreas wrote a version of simplifying secondary startup in the > same spirit as Russell's patches, and it's merged and all > is fine I think. > Oops. I think I missed that! Can you please point me to that patch? And how it got merged? I did the PR for actions stuff this time and haven't included any mach-actions patches. Thanks, Mani > If this patch applied on top of the current upstream code I'd say > just forget about my patch and merge Wen's patch instead. > > Yours, > Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel