From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47F02C43381 for ; Mon, 4 Mar 2019 15:43:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 192C7206B8 for ; Mon, 4 Mar 2019 15:43:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Tu80WKUR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 192C7206B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LRdAvov+JrLag3Dxn8JP1IBVjxbzjnUEahZ0AWH6UC0=; b=Tu80WKURkYyvOc7N9ADPUnYEk ZfjZ1OcUxH1T7Hl/9MFPlwbFAFfcUS5gGq51QeXH1ogmxhCKvO2fss8TgyxkYdJxmx7SHHjUFdvET 5IYu/BHNDJ7+nE+JAjvKyVwH2xg+G02AEdQEN2/iXbor4g95OvYQssLdlbQrdCm7UPp2jeFRyesL2 e7kIBirn4HrK2q8hIJrjk5l3Jp5aVoqHps/cDtNo2JLAsPvwX0r84YqfEblG9pHyUeGjbCHit/L9T VNNvDlO3k3w9ce6OEwJMygxtsg4L38HgPyQSwesQ6isqcLCmLmGPHzNo43+z1Ouom0tTiLRNcb7lt mYbpYQTxA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0pkX-0002lB-Qd; Mon, 04 Mar 2019 15:43:29 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0pkU-0002kM-3d for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2019 15:43:28 +0000 X-Originating-IP: 185.94.189.188 Received: from localhost (unknown [185.94.189.188]) (Authenticated sender: maxime.ripard@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 354A0FF81C; Mon, 4 Mar 2019 15:43:20 +0000 (UTC) Date: Mon, 4 Mar 2019 16:43:20 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH v9 2/5] drm/sun4i: sun6i_mipi_dsi: Fix TCON DRQ set bits Message-ID: <20190304154320.uledvwz5jhzt22o3@flea> References: <20190303173527.31055-1-jagan@amarulasolutions.com> <20190303173527.31055-3-jagan@amarulasolutions.com> MIME-Version: 1.0 In-Reply-To: <20190303173527.31055-3-jagan@amarulasolutions.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_074326_299670_36E6B33B X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Daniel Vetter , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============4133543667233420833==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4133543667233420833== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ckvqly3325xxados" Content-Disposition: inline --ckvqly3325xxados Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 03, 2019 at 11:05:24PM +0530, Jagan Teki wrote: > TCON DRQ for non-burst DSI mode can computed based on horizontal > front porch value, but the current driver trying to include sync > timings along with front porch resulting wrong drq. >=20 > This patch is trying to update the drq by subtracting hsync_start > with hdisplay, which is horizontal front porch. >=20 > Current code: > ------------ > mode->hsync_end - mode->hdisplay =3D> horizontal front porch + sync >=20 > With this patch: > ---------------- > mode->hsync_start - mode->hdisplay =3D> horizontal front porch >=20 > BSP code form BPI-M64-bsp is computing TCON DRQ set bits > for non-burts as (from linux-sunxi/ > drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) >=20 > =3D> panel->lcd_ht - panel->lcd_x - panel->lcd_hbp > =3D> (timmings->hor_front_porch + panel->lcd_hbp + panel->lcd_x) ^ + sync length + =20 > - panel->lcd_x - panel->hbp > =3D> timmings->hor_front_porch ^ + sync > =3D> mode->hsync_start - mode->hdisplay s/hsync_start/hsync_end/ Did you encounter any panel where this was fixing something? If so, which one, and what is the matching timings and / or datasheet? Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ckvqly3325xxados Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXH1HmAAKCRDj7w1vZxhR xbE5AQCeJXHl7njsE2u2cncRN3BJU9l5VoQgSMjTqpXB+TrW/wEAokqKp7BJB7eQ T8Bevhwx3dZ0c7Sesev+6hAUeEd5hAI= =0s6U -----END PGP SIGNATURE----- --ckvqly3325xxados-- --===============4133543667233420833== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4133543667233420833==--