From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF0C8C43381 for ; Tue, 5 Mar 2019 09:12:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B13DF2084F for ; Tue, 5 Mar 2019 09:12:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HxlIdWjy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B13DF2084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fuXpgNYBJKutg4Mvoi6win7SExRprDnw8nw62kf/DtU=; b=HxlIdWjyIu+6SfH1cI7cN+UDB NrUmAfwS5L47KZUNH+MUc5VPZYagvTUw6XjVfNN1RmCX6j3w0GTbyzqhrsh53ZJycBnZ67il9GI5z ZmDbNdVkno6OEnqIHlrbEFHsTOedI0BGp4CShiDiKJuihPHhtb7yYi6diFBSSEb3XFJtPxxL8aJx4 RZCasPrAJPJDkKiXfWsxDFLfCs8yvE8Tz9hcRBPGH2rRE4BUpkb/DgOFoFZynhe0QhIQ6a4eKwFyC TgRcbhb09FB+f1P+S65/sV0c3D21bHJ6bn9djgnIMdJ1b0RFNeNG1iZxkF78CknwRID8NlZITP0jY DwSsMLdaA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1684-0004p9-Lv; Tue, 05 Mar 2019 09:12:52 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1680-0004oh-Rw for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 09:12:51 +0000 X-Originating-IP: 90.88.147.150 Received: from localhost (aaubervilliers-681-1-27-150.w90-88.abo.wanadoo.fr [90.88.147.150]) (Authenticated sender: maxime.ripard@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id F278FC0013; Tue, 5 Mar 2019 09:12:40 +0000 (UTC) Date: Tue, 5 Mar 2019 10:12:40 +0100 From: Maxime Ripard To: Alex Deucher Subject: Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data Message-ID: <20190305091240.sbkvdwosocaytx22@flea> References: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> <87wole76ws.fsf@anholt.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_011249_212268_E4834CA6 X-CRM114-Status: GOOD ( 21.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eben@raspberrypi.org, David Airlie , Maarten Lankhorst , Maling list - DRI developers , Paul Kocialkowski , Eric Anholt , Sean Paul , Thomas Petazzoni , Daniel Vetter , linux-arm-kernel Content-Type: multipart/mixed; boundary="===============6873484288331938544==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6873484288331938544== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n2vtjd32cw567zqx" Content-Disposition: inline --n2vtjd32cw567zqx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 04, 2019 at 03:05:31PM -0500, Alex Deucher wrote: > On Mon, Mar 4, 2019 at 2:53 PM Eric Anholt wrote: > > > > Maxime Ripard writes: > > > > > In some cases, in order to accomodate with displays with poor EDIDs, = we > > > need to ignore that the monitor alledgedly supports audio output and > > > disable the audio output. > > > > > > Signed-off-by: Maxime Ripard > > > --- > > > drivers/gpu/drm/drm_edid.c | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > > > index 990b1909f9d7..c0258b011bb2 100644 > > > --- a/drivers/gpu/drm/drm_edid.c > > > +++ b/drivers/gpu/drm/drm_edid.c > > > @@ -4190,6 +4190,11 @@ bool drm_detect_hdmi_monitor(struct edid *edid) > > > } > > > EXPORT_SYMBOL(drm_detect_hdmi_monitor); > > > > > > +static bool ignore_edid_audio =3D false; > > > +module_param(ignore_edid_audio, bool, 0644); > > > +MODULE_PARM_DESC(ignore_edid_audio, > > > + "Ignore the EDID and always consider that a monitor do= esn't have audio capabilities"); > > > + > > > /** > > > * drm_detect_monitor_audio - check monitor audio capability > > > * @edid: EDID block to scan > > > @@ -4209,6 +4214,9 @@ bool drm_detect_monitor_audio(struct edid *edid) > > > bool has_audio =3D false; > > > int start_offset, end_offset; > > > > > > + if (ignore_edid_audio) > > > + goto end; > > > + > > > edid_ext =3D drm_find_cea_extension(edid); > > > if (!edid_ext) > > > goto end; > > > > It looks like the motivation for the original flag on Raspberry Pi was > > "I've got a non-audio monitor, but the system comes up trying to play > > audio to HDMI instead of the analog jack". Do we have some way for DRM > > to communicate to ALSA that this is not the right place to try to play > > audio by default? >=20 > Apparently not. We have users using debug knobs in our drivers to > disable display audio because ALSA defaults to that rather than other > audio. I guess one way to do this would be to register the card only when an audio-capable monitor is connected instead of doing this at probe time. I'm not sure how convenient it is for userspace though. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --n2vtjd32cw567zqx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXH49iAAKCRDj7w1vZxhR xT34AQDwXhsJGWoDU4pebMHaFXdj1Acfc+5W9KZMxBIgEM3qTgD/QeIeceVRJywd BoLElduutiqIDxpJFLUeXfLJWaH9QQk= =Z3V7 -----END PGP SIGNATURE----- --n2vtjd32cw567zqx-- --===============6873484288331938544== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6873484288331938544==--