From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7215CC43381 for ; Tue, 5 Mar 2019 09:55:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4308B2082C for ; Tue, 5 Mar 2019 09:55:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Lp299I8z"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="Ckd119AE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4308B2082C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BJdzOr3QCDDBsg5Hmw8Uek7vOsf5+FAa5byM6gRy/IA=; b=Lp299I8zgqg+9A tiCncpjMj8mpyE/7qJHRP6SfuMS/gyxXNDOf7WyxmNw1elU0NhZAtBBBPB8GaM6qBunJWr3cw2rMz SoeqOwHQDl5bniNt+Xx5NulGZKXRBCjbqIHokNTXrnAw9Zyv0zahMHoChBhEI+uy9UrT1ojWxOnbN qhljWpCAbuUofQomE4kN65u9IkqyVxJ0oZXcHFH1bCpaF++d/ZsJCouGNyXrMFV3eInWj6tLcMyKM W+EdPoBYYgVAilW1izq1EuaexA+H3mviIH4RndBfhOZol+2sWIKaHIM5kjtvmIqzyMm81CqaQHhOS rQ4X7F7gZmstloL8tkrQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h16nb-0006DE-B6; Tue, 05 Mar 2019 09:55:47 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h16nW-0006Br-GS; Tue, 05 Mar 2019 09:55:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=B4wdFcvaQS9jQ+A96f4iwiWLIVrRdXxvFqFNs+W8ziA=; b=Ckd119AEXAaocwB1e1eYphnMi FeX6nPYqK/kOiCtUOoy1uHwB63/BD5ZCx/amoMcFoJkbu4tugwe/vHyBEcyEy//3fITVthW+v/f68 R3TS8hZT/7tsQ/SKTadOcemkA+jONlRdnHwIJacWd8zRw13qfVubvadHfClbxRzt01nUuXidg77wf WEvk0UwP4kWjYdb9LsGHxWtfS0nZlscINv//lhVigNKxU2pRjmzcJMzMPTCFXc3z1VrgB6BAexzFt zJPc98WB5ghjkAF5f60OEXoF1xWFYEQYw3mlXwPDOpZMiwO6Llt+hqM+l26APzDzkVBox9Kk+8t2G pl5YdglNQ==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:54940) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1h16nB-0000Mp-VA; Tue, 05 Mar 2019 09:55:22 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.89) (envelope-from ) id 1h16mv-00035r-Sh; Tue, 05 Mar 2019 09:55:05 +0000 Date: Tue, 5 Mar 2019 09:55:05 +0000 From: Russell King - ARM Linux admin To: Manivannan Sadhasivam Subject: Re: [PATCH 01/15] ARM: actions: fix a leaked reference by addingmissing of_node_put Message-ID: <20190305095505.znposuv6avjtbfwf@shell.armlinux.org.uk> References: <1551430616-42014-1-git-send-email-wen.yang99@zte.com.cn> <20190301155523.GA1915@Mani-XPS-13-9360> <20190304144829.GA5265@Mani-XPS-13-9360> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_015542_552922_45D3B15E X-CRM114-Status: GOOD ( 25.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko =?iso-8859-1?Q?St=FCbner?= , Maxime Ripard , Catalin Marinas , Linus Walleij , Liviu Dudau , Xu Wei , Wen Yang , Tomer Maimon , Lorenzo Pieralisi , "open list:ARM/Rockchip SoC..." , Will Deacon , OpenBMC Maillist , Magnus Damm , Michal Simek , Krzysztof Kozlowski , linux-samsung-soc , Chen-Yu Tsai , Kukjin Kim , bcm-kernel-feedback-list , NXP Linux Team , Brendan Higgins , wang.yi59@zte.com.cn, Ray Jui , Sascha Hauer , Florian Fainelli , Nancy Yuen , Linux ARM , Scott Branden , avifishman70@gmail.com, Patrick Venture , "linux-kernel@vger.kernel.org" , Linux-Renesas , Dinh Nguyen , Simon Horman , Sascha Hauer , Sudeep Holla , Fabio Estevam , Shawn Guo , Andreas =?iso-8859-1?Q?F=E4rber?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 05, 2019 at 07:21:19AM +0530, Manivannan Sadhasivam wrote: > On Tue, 5 Mar, 2019, 4:08 AM Linus Walleij > > On Mon, Mar 4, 2019 at 3:48 PM Manivannan Sadhasivam > > wrote: > > > On Mon, Mar 04, 2019 at 01:29:33PM +0100, Linus Walleij wrote: > > > > On Fri, Mar 1, 2019 at 4:55 PM Manivannan Sadhasivam > > > > wrote: > > > > > Hi Wen, > > > > > > > > > > On Fri, Mar 01, 2019 at 04:56:42PM +0800, Wen Yang wrote: > > > > > > The call to of_get_next_child returns a node pointer with refcount > > > > > > incremented thus it must be explicitly decremented after the last > > > > > > usage. > > > > > > > > > > > > Detected by coccinelle with the following warnings: > > > > > > ./arch/arm/mach-actions/platsmp.c:112:2-8: ERROR: missing > > of_node_put; acquired a node pointer with refcount incremented on line 103, > > but without a corresponding object release within this function. > > > > > > ./arch/arm/mach-actions/platsmp.c:124:2-8: ERROR: missing > > of_node_put; acquired a node pointer with refcount incremented on line 115, > > but without a corresponding object release within this function. > > > > > > ./arch/arm/mach-actions/platsmp.c:137:3-9: ERROR: missing > > of_node_put; acquired a node pointer with refcount incremented on line 128, > > but without a corresponding object release within this function. > > > > > > > > > > > > > > > > We have a floating patch for this: > > > > > https://www.spinics.net/lists/arm-kernel/msg694544.html > > > > > > > > > > Andreas: Can you please take a second look at the patchset submitted > > by Linus > > > > > Walleij and Russel for simplifying the Actions startup code? > > > > > > > > Andreas wrote a version of simplifying secondary startup in the > > > > same spirit as Russell's patches, and it's merged and all > > > > is fine I think. > > > > > > > > > > Oops. I think I missed that! Can you please point me to that patch? And > > how it > > > got merged? I did the PR for actions stuff this time and haven't > > included any > > > mach-actions patches. > > > > I just did git log arch/arm/mach-actions but I think it came in quite some > > time > > ago, not last merge window: > > > > But you see: > > commit 6c2eb3e76fb84e2eb46d484f71fab469c0d9532c > > "ARM: owl: smp: Drop owl_secondary_boot()" > > commit bad29933fef76fb6ee577f4a0b6d145c1f52f663 > > "ARM: owl: smp: Use __pa_symbol()" > > commit 18cfd9429d8a82c49add8f3ca9d366599bfcac45 > > "ARM: owl: smp: Drop bogus holding pen" > > > > platsmp.c looks just fine these days. Except for what Wei's patch is > > fixing, > > of_node_put(). > > > > Nope. platsmp.c still requires some cleanup like removing the redundant > bootlock and pen_release flag as pointed out by Russel. Andreas just > replied to your cleanup patches but there was no follow up since that. So, > I guess we can just apply Russell's patches and this patch once Andreas is > fine with it (it looks good to me though). No. My patches are in my tree queued for this merge window. They are part of a series that can not be broken up and merged separately because all the per-platform patches need to be merged before the final patch "ARM: smp: remove arch-provided "pen_release"" otherwise the platforms break. I thought that was already explained. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel