From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5935DC43381 for ; Tue, 5 Mar 2019 11:39:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A49220842 for ; Tue, 5 Mar 2019 11:39:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EbQaBRhD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A49220842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J3G2kT7oiMJVkPZCbmzHPL+Mvi2DmLriDgpnEozg7pU=; b=EbQaBRhD8s8iu+ K3dNwDr5vNWkQPeQoXKp1yR+FXbSPi9VlT9ATdap4xfGMqkAn8WDy+xgGHBOCwUxFSRwUGNpOdx2g izyjI2qpde3oYFc6bjEz3XJ4ywtb/w8o8b2S332sPpfbRZmkmSUDrNbh9/F/Vj3urkSTqpplWbrgH QAnvLPOXx+QYxRdtH0MbufwATmIPOmyA/5fVyqj9Pkt3C0A8OzqYtME546zcZ6tetuznN/RG3XBtt fFiyPWkq4HqZsT13S/bVuMpSeYlLFbjEWg72teQulaor4pQ0QuxpyF8iIwhSHyXheQ4iPUXJKjyjO wSLuE619sngPq807/UfA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h18Q6-0000Xs-Mq; Tue, 05 Mar 2019 11:39:38 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h18Q3-0000XP-Ub for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 11:39:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C0CFDA78; Tue, 5 Mar 2019 03:39:34 -0800 (PST) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 67E3B3F71D; Tue, 5 Mar 2019 03:39:33 -0800 (PST) Date: Tue, 5 Mar 2019 11:39:30 +0000 From: Sudeep Holla To: Wen Yang Subject: Re: [PATCH v2 12/15] ARM: vexpress: fix a leaked reference by adding missing of_node_put Message-ID: <20190305113930.GB2066@e107155-lin> References: <1551785646-46173-1-git-send-email-wen.yang99@zte.com.cn> <1551785646-46173-12-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1551785646-46173-12-git-send-email-wen.yang99@zte.com.cn> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_033935_989610_46D963B5 X-CRM114-Status: GOOD ( 13.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wang.yi59@zte.com.cn, Lorenzo Pieralisi , Liviu Dudau , linux-kernel@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 05, 2019 at 07:34:03PM +0800, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-vexpress/dcscb.c:150:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. > ./arch/arm/mach-vexpress/dcscb.c:160:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. > ./arch/arm/mach-vexpress/dcscb.c:171:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang > Reviewed-by: Florian Fainelli > Cc: Liviu Dudau > Cc: Sudeep Holla I already Acked assuming you have plans to take this as series. There's no cover letter mentioning your plans to merge this or note to individual platform maintainers. Please let us know. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel