From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CC51C43381 for ; Tue, 5 Mar 2019 11:59:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B6BF206DD for ; Tue, 5 Mar 2019 11:59:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lXIy2K/T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B6BF206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:Date:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4SexHUq4//2NBh70xW8zswclXkA3K+UYNB0bLMJbyGY=; b=lXIy2K/TRTaSPozedWtwhxVaT tahVSOcvwZqfbpoaeW5HS6ViybkU9QZg34GBzSqhhwQI6nhQKWH1Ir0kLPWenT+tD55mQw4IK0YWD WzQeokvYU7Vj+KowMJ+OpRxmASE1DLs3vawmCKCEqwAxcjJX0nq8zncZAlsCdiTIa2HFyz9ibcVD4 K07s//fHYaGByUv1s0rvP7GSkmTzeMAi2fNBQMTktz/7N2rDQodvy1O/11cus7LgWYoNbo+R7kZ8D lkxkaL/7II67pAS7TY+R14QFteK2s9sDy/BA3aCcQMcaXWBdfGPmXTFAPi29QyEASEbWVbHAxCcPn sL5th/Z2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h18jT-0008I8-Jc; Tue, 05 Mar 2019 11:59:39 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h18jP-0008Bk-4H for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 11:59:37 +0000 X-Originating-IP: 90.88.147.150 Received: from localhost (aaubervilliers-681-1-27-150.w90-88.abo.wanadoo.fr [90.88.147.150]) (Authenticated sender: maxime.ripard@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D4C8FC0007; Tue, 5 Mar 2019 11:59:26 +0000 (UTC) From: maxime.ripard@bootlin.com Date: Tue, 5 Mar 2019 12:59:26 +0100 To: Wen Yang Subject: Re: [PATCH v2 10/15] ARM: sunxi: fix a leaked reference by adding missing of_node_put Message-ID: <20190305115926.za332f63piwpnxux@flea> References: <1551785646-46173-1-git-send-email-wen.yang99@zte.com.cn> <1551785646-46173-10-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 In-Reply-To: <1551785646-46173-10-git-send-email-wen.yang99@zte.com.cn> gFrom: Maxime Ripard User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_035935_318173_C707233C X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wang.yi59@zte.com.cn, Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King Content-Type: multipart/mixed; boundary="===============3189989125502397336==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3189989125502397336== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ffjjji2iwbywqv7a" Content-Disposition: inline --ffjjji2iwbywqv7a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 05, 2019 at 07:34:01PM +0800, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. >=20 > Detected by coccinelle with the following warnings: > ./arch/arm/mach-sunxi/platsmp.c:55:2-8: ERROR: missing of_node_put; acqui= red a node pointer with refcount incremented on line 46, but without a corr= esponding object release within this function. > ./arch/arm/mach-sunxi/platsmp.c:138:2-8: ERROR: missing of_node_put; acqu= ired a node pointer with refcount incremented on line 129, but without a co= rresponding object release within this function. >=20 > Signed-off-by: Wen Yang > Reviewed-by: Florian Fainelli > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Russell King > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org Applied, thanks! Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ffjjji2iwbywqv7a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXH5kngAKCRDj7w1vZxhR xX4qAQC3g5Y+G6BrB/fhaiogrHS0yAs7jzz4grg3O2c5NOKMGgEAi5UIlA6a/t8H YETwNXj9AssBJxxxv3JBNOxTSF0AdQs= =Scxs -----END PGP SIGNATURE----- --ffjjji2iwbywqv7a-- --===============3189989125502397336== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3189989125502397336==--