From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC33C43381 for ; Tue, 5 Mar 2019 15:59:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0BA520684 for ; Tue, 5 Mar 2019 15:59:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PrItgNEU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0BA520684 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4l9TXNaaBKp3/CNVOU9iHuhDl/T4kQknCCy8GAIN+Q0=; b=PrItgNEUDtOj2T0cSZurcwb9x cf/uOQcZ6Q2yppVvSeP9G+sVadShztBibaf2libnarFx7/KBDGNr9E/30nfCdfNvXcj61nNdKR7fE ua7mZ06UkRa2xGrcNSZRh3IsztqMoaiZPJV25tOgy0jA0eHut83tPUOK6l02sOn2OoCs22MI1l1aj gwR9ieeUO3AUgC9AQhXZPwrcsVbdpdcAcCQnoUHPygQytxV/KXcnbk4lLC8S2pnFM5ZvLmpnizDVP VxPI9h0n4aOtJ17zaNRPg6ouJJ4b4EutvcQMLiyQXw8MFKGF1rI4wML/wpswoI1f05loSnuutGXuZ nb3i0GqSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1CTf-0000EC-Ik; Tue, 05 Mar 2019 15:59:35 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1CTb-0000DH-BR for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 15:59:33 +0000 X-Originating-IP: 90.88.150.179 Received: from localhost (aaubervilliers-681-1-31-179.w90-88.abo.wanadoo.fr [90.88.150.179]) (Authenticated sender: maxime.ripard@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 4185360013; Tue, 5 Mar 2019 15:59:20 +0000 (UTC) Date: Tue, 5 Mar 2019 16:59:19 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support Message-ID: <20190305155919.cm3yrve3vqp7jimh@flea> References: <20190226060240.8783-1-jagan@amarulasolutions.com> <20190226060240.8783-2-jagan@amarulasolutions.com> <20190227153346.dwd3stsbsvf7rwly@flea> <20190301145724.vhvyoqkkxdflg2g7@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_075931_691958_48864489 X-CRM114-Status: GOOD ( 23.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Ryan Pannell , linux-kernel , Chen-Yu Tsai , Rob Herring , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel Content-Type: multipart/mixed; boundary="===============1029852269729929335==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1029852269729929335== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iy7ufcb2rlgsdx6i" Content-Disposition: inline --iy7ufcb2rlgsdx6i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 01, 2019 at 10:27:14PM +0530, Jagan Teki wrote: > On Fri, Mar 1, 2019 at 8:27 PM Maxime Ripard = wrote: > > > > On Wed, Feb 27, 2019 at 09:49:23PM +0530, Jagan Teki wrote: > > > On Wed, Feb 27, 2019 at 9:03 PM Maxime Ripard wrote: > > > > > > > > Hi, > > > > > > > > On Tue, Feb 26, 2019 at 11:32:40AM +0530, Jagan Teki wrote: > > > > > Oceanic A64-5inMFD is a 5 inch Multi function display baseboard > > > > > designed to mount SoPine SOM. > > > > > > > > > > Key features: > > > > > - Allwinner A64 Cortex-A53 > > > > > - Mali-400MP2 GPU > > > > > - AXP803 PMIC > > > > > - 2GB DDR3 RAM > > > > > - SD Slot > > > > > - SPI-NOR flash > > > > > - EMAC, RTL8211E > > > > > - MCP2515 CAN > > > > > - MIPI-DSI > > > > > - Goodix 911 CTP > > > > > - USB Host > > > > > - 12V DC power supply > > > > > > > > > > Signed-off-by: Jagan Teki > > > > > --- > > > > > arch/arm64/boot/dts/allwinner/Makefile | 1 + > > > > > .../allwinner/sun50i-a64-oceanic-5inmfd.dts | 46 +++++++++++++= ++++++ > > > > > 2 files changed, 47 insertions(+) > > > > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-ocea= nic-5inmfd.dts > > > > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/= boot/dts/allwinner/Makefile > > > > > index a5fb1eaa8acf..ec39fe856117 100644 > > > > > --- a/arch/arm64/boot/dts/allwinner/Makefile > > > > > +++ b/arch/arm64/boot/dts/allwinner/Makefile > > > > > @@ -2,6 +2,7 @@ > > > > > dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-amarula-relic.dtb > > > > > dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-bananapi-m64.dtb sun50i= -a64-bananapi-m64-icn6211.dtb > > > > > dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-nanopi-a64.dtb > > > > > +dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-oceanic-5inmfd.dtb > > > > > dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-olinuxino.dtb > > > > > dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-orangepi-win.dtb > > > > > dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-pine64-lts.dtb > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5in= mfd.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts > > > > > new file mode 100644 > > > > > index 000000000000..d73d1f55acb9 > > > > > --- /dev/null > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts > > > > > @@ -0,0 +1,46 @@ > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > +/* > > > > > + * Copyright (C) 2019 Oceanic Systems (UK) Ltd. > > > > > + * Copyright (C) 2019 Amarula Solutions B.V. > > > > > + * Author: Jagan Teki > > > > > + */ > > > > > + > > > > > +/dts-v1/; > > > > > + > > > > > +#include "sun50i-a64-sopine.dtsi" > > > > > + > > > > > +/ { > > > > > + model =3D "Oceanic A64-5inMFD"; > > > > > + compatible =3D "oceanic,a64-5inmfd", "allwinner,sun50i-a64"; > > > > > > > > The name of the DT is Oceanic 5inMFD, while you call the board > > > > A64-5inMFD here, which name is the actual name? > > > > > > Yes, this is something that we discussed during "Amarula A64-Relic" > > > naming convention. > > > > > > Since these boards are not famous like teres-i we agreed to add vendor > > > name after sun50i-a64- followed by real board name. > > > > > > Here A64 already covered during sun50i-a64- so the dts name simply the > > > - > > > > For the DT name, yeah, we want that pattern. > > > > For the compatible and model, we want to use the model name. >=20 > Entire model name after , ? >=20 > model =3D "Oceanic A64-5inMFD"; > compatible =3D "oceanic,a64-5inmfd", "allwinner,sun50i-a64"; >=20 > is this not sufficient? >=20 > Let me understand with respective few existing stuff. >=20 > model =3D "Amarula A64-Relic"; > compatible =3D "amarula,a64-relic", "allwinner,sun50i-a64"; >=20 > model =3D "Olimex A64 Teres-I" > compatible =3D "olimex,a64-teres-i", "allwinner,sun50i-a64"; This one is called the TERES-A64: https://www.olimex.com/Products/DIY-Laptop/KITS/TERES-A64-WHITE/open-source= -hardware The laptop is the Teres-I, it can have an A64 > model =3D "FriendlyARM NanoPi A64"; > compatible =3D "friendlyarm,nanopi-a64", "allwinner,sun50i-a64"; NanoPi A64 is the name of the board: http://nanopi.io/nanopi-a64.html > model =3D "Olimex A64-Olinuxino"; > compatible =3D "olimex,a64-olinuxino", "allwinner,sun50i-a64" A64-Olinuxino is the name of the board too: https://www.olimex.com/Products/OLinuXino/A64/A64-OLinuXino/open-source-har= dware > Would you comment, what is the different with respect to my change? If the name of the product is 5inMFD, then the model should be Oceanic 5inMFD, and its compatible oceanic,5inmfd Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --iy7ufcb2rlgsdx6i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXH6c1wAKCRDj7w1vZxhR xROYAQC8deU5A9vhREAQQrK6Q7EOCuKH8mkLTmcsFAk0ZXrG7gEA8fUEhN3hVdvx tEyVxtyE6hiw+XrLTXBDiyaxBl7aPgk= =tDgf -----END PGP SIGNATURE----- --iy7ufcb2rlgsdx6i-- --===============1029852269729929335== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1029852269729929335==--