From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6734BC43381 for ; Tue, 5 Mar 2019 17:17:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39ADD20848 for ; Tue, 5 Mar 2019 17:17:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KtswJ5ky"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Aq2FRKya" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39ADD20848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5zFuhVKGBl/bssV0mMegTElP5ILTIESgU8xdmdegn04=; b=KtswJ5ky39WpgM E/IIgpHOp/k1jcK8/jF1cVCUPLMepcX8NFzBEIsW5sKNzq2tdHfAWq+Z1gABAMup7XRj4N1wBLbj5 bPqQsngWkPD1BBUM3s7bMp2fV30IB1CLK16MDOOXzNLuoP3RAQWqiAq/7H62ThAPGnohx04LKNKbZ 00voBuVkmtpX31vSoWdxG913jCaczWWMhE063FkNzlPJLvvZibJ8w5JX6JBzhVGqtuXNTl1uU6pTH wD259iD/+1wmYXrh95eSjLgXPZHxuVxZv6DQshlPbfVrlBz3Wkpid33Y88Qqq8pPd/MugCpycqQ1Y XYk9TU2XsZLvNuEiAwMQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1DhP-00066d-Gd; Tue, 05 Mar 2019 17:17:51 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1DhM-00065o-6Y for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 17:17:49 +0000 Received: by mail-pg1-x544.google.com with SMTP id j3so6056604pgm.11 for ; Tue, 05 Mar 2019 09:17:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/7b8M0CCW3SEgOA19Z77npMOfEbrkCdOfgSC9V3ldzA=; b=Aq2FRKyaCLZfMmBCVmMIVj/oamfkzpu94Me1uEtD+2zjW/xunUlr0omBsnqeLWXE0o HMStnCZ0KRq32j45gFIemCmA5Ol+kiqHsyTcc6qk1Lkw7AAHzu9apy3LX7uxKyeBzMK5 ZNojdp5D66tuPtUGuN4SUpa8Td+6Qs++/LYwvVL96YE5ov0Er/PXFl/LfnUkdQu+G2OM l7DLAXSdAikJWxfht3C75YNdM8lv/DZT2jxk6gxj/qNwcrn1CtBsqRR3Ae3lnvCNXxKo WQ++nRHCSGRzHX5WJDEvs34ZglcZNqFZpDvU9wxFunkpKXFiZrEYu4Y0uQUOhqJSgCau n62g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=/7b8M0CCW3SEgOA19Z77npMOfEbrkCdOfgSC9V3ldzA=; b=gjeRnKvRLqGOg9q0WsIL6UQy2oGIoCpanCNHIGsyVsK6PlfxwseIY49xsXx8E3Z5JH gTzK0xiIMNBZH4wAC7AguVJ9PWxRCjCqfss7uKWqSCFbXlQa15JvWfIvjUeT2HUozSI9 V4fk6R85kj4ap6DTF5/f0UeF7tJX4mKyniE/cWhAXIwIfk3lIab+992ft86nLjtWt2Ok tOYWgylhuRi0jUzWcBJxQz/bp0eDMdBPBedfSTtH8Dw+eiBkunF2J4GKmU2w0WC3Zh0/ rml23VxQGyuNRmMPzm6DzqwG6EDYsMPI/SOCklCy4mKCBfFKaxdHY7RLq9A1IgNDjkxg y+EA== X-Gm-Message-State: APjAAAWdP94iRKP0O8mhCRN3zH50vbcGGbX6CaCjCIVbatEDw9EhuZEu m87FjzHKdMP9Ncqmf5XydME= X-Google-Smtp-Source: APXvYqzaYE/OsigMrxfC1lVCexn+jJlDUflfoUv86uqCZvrOFmcIAOfXYq5b8lSGeb1pkcEXu9xEMg== X-Received: by 2002:a17:902:900a:: with SMTP id a10mr2316459plp.183.1551806265797; Tue, 05 Mar 2019 09:17:45 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id k125sm29772645pgc.51.2019.03.05.09.17.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Mar 2019 09:17:45 -0800 (PST) Date: Tue, 5 Mar 2019 09:17:44 -0800 From: Guenter Roeck To: Chris Packham Subject: Re: [PATCH 1/2] watchdog: orion_wdt: remove orion_wdt_set_timeout Message-ID: <20190305171744.GA32623@roeck-us.net> References: <20190227230707.GA28635@roeck-us.net> <20190304225152.26831-1-chris.packham@alliedtelesis.co.nz> <20190304225152.26831-2-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190304225152.26831-2-chris.packham@alliedtelesis.co.nz> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_091748_268706_188035F0 X-CRM114-Status: GOOD ( 15.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, jason@lakedaemon.net, gregory.clement@bootlin.com, linux-kernel@vger.kernel.org, Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 05, 2019 at 11:51:51AM +1300, Chris Packham wrote: > The watchdog core will do the same thing if no set_timeout > is supplied so we can safely remove orion_wdt_set_timeout. > > Signed-off-by: Chris Packham Reviewed-by: Guenter Roeck > --- > drivers/watchdog/orion_wdt.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c > index 9db3b09f7568..8b259c712c52 100644 > --- a/drivers/watchdog/orion_wdt.c > +++ b/drivers/watchdog/orion_wdt.c > @@ -349,13 +349,6 @@ static unsigned int orion_wdt_get_timeleft(struct watchdog_device *wdt_dev) > return readl(dev->reg + dev->data->wdt_counter_offset) / dev->clk_rate; > } > > -static int orion_wdt_set_timeout(struct watchdog_device *wdt_dev, > - unsigned int timeout) > -{ > - wdt_dev->timeout = timeout; > - return 0; > -} > - > static const struct watchdog_info orion_wdt_info = { > .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING | WDIOF_MAGICCLOSE, > .identity = "Orion Watchdog", > @@ -366,7 +359,6 @@ static const struct watchdog_ops orion_wdt_ops = { > .start = orion_wdt_start, > .stop = orion_wdt_stop, > .ping = orion_wdt_ping, > - .set_timeout = orion_wdt_set_timeout, > .get_timeleft = orion_wdt_get_timeleft, > }; > > -- > 2.21.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel