From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29F31C43381 for ; Tue, 5 Mar 2019 21:30:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDB6F2075B for ; Tue, 5 Mar 2019 21:30:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pUUUHSWE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZyYU/Zvd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDB6F2075B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0GYBFEJBA9Yddd5TPr/oXw+oKKSlQLT/RN1zJ1OrY+Y=; b=pUUUHSWEgzWjni IULxG2e5CsP3svLKXpWBfwHD0rRaQh/3/tCbgHj3hMeNrEO71hfex0v29aYoIbz7zbDhUcCE3+96s 4DmaUkhnxkHdmWRHiDben7wGedq7KxgO7ezGsPGGmD5zPqIbBSwrvolwlXAHYOHui7nu0phhq8n5d SmsJopC5Ow7FAJPE3GpeJn5HtKtvZGTlwB0/pRnP4o4xi4gIjHrBbNOmCU/qF2R6he55Mz7tTFEbY j+rH6Lb5NTRyzoEi53RYjN0soKzat4LfFbz8sF4NWjbWDgu1UYpLoBQowqXdS/4t8nhScJLdsaja1 0uzx/APiUo0rIzG1xmnQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1Hde-0005YP-65; Tue, 05 Mar 2019 21:30:14 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1Hda-0005Xw-OM for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 21:30:12 +0000 Received: by mail-pf1-x443.google.com with SMTP id j5so6687219pfa.2 for ; Tue, 05 Mar 2019 13:30:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OsiD+pEO2P34HR4UNyclDcmDzcvZo8GusN5e2ks18qY=; b=ZyYU/ZvdH9jesfqXrV0pbeWH8Vkrh2An5eHtQr9fmenRZwsBbS1o53waSsGfuU8mX7 EPi0EuXvK1BzAZIbH4viBat17ccdDUTAQZ93JugBzIgzj6y7mu8jqFgM5nLVdiDCKFC/ aSnGqVWOZeXz54vuzjyDjzDVlq5fI3lChfw++yJQuiU9tgviUMMLhRjzA7sz95ZSQrJ/ WOm/rFe0M1Bm8nCgeEuon/ZO85uQBQEalbGVpFzAho5Evw0H2Q6bwmQUm4rXgy2G2fb5 NSx4M3Uo+gTrWvZs2yiDj+sR0o4xD7U7OOOBQbYhdPpHDfIDn2GFpiex5kSDBHM8WgeS hfKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=OsiD+pEO2P34HR4UNyclDcmDzcvZo8GusN5e2ks18qY=; b=J0fvOtLuiAgvTYTE5pm0jzw7sVI1FUwvVikpHWG3ww+sgQMAYElb/4hznpJSt0CrbN Gtnkzp1ioyLstINbd7gMoCQYog3M3Q/dS7PmtmVzotUprJ+cfVOIIoiIo2j4GnZ7724B j1VyuZInSwsbySCKr57k13HkIehvmKUKCtghGGuMIOF0FAcnYHL74h6Z8ovLXJlPGlWE c6lZaT/oLxympgIvltupQyhudCinA8HQhzez35Ezttpv3Y9battsnVaTFxYYDaDEWm90 jRpU3gDNLgv0mFr1l/bb214bCvmlAXlfTN2D/6NAKuBXFRSRskNzbOXq2py38e2INW1M Q1yg== X-Gm-Message-State: APjAAAXVslY0ROZkFUV0EH80V/kFwJMM9+8GdFDk4typo2bJ1LsY9Dxm /cWF+G3c1piRSKlaow5kcxSoM2Ax X-Google-Smtp-Source: APXvYqxkjI60stzBqC6DFKRLyybbwrnwfNuJHp5+4Ml9xlR1McfDpq6Txjeh+soXB6RWo245jjF1VA== X-Received: by 2002:a17:902:ab95:: with SMTP id f21mr3423091plr.188.1551821409820; Tue, 05 Mar 2019 13:30:09 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id k18sm18431374pfj.92.2019.03.05.13.30.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Mar 2019 13:30:08 -0800 (PST) Date: Tue, 5 Mar 2019 13:30:07 -0800 From: Guenter Roeck To: Chris Packham Subject: Re: [PATCH v2 1/3] ARM: dts: armada-38x: add interrupts for watchdog Message-ID: <20190305213007.GA2825@roeck-us.net> References: <20190305201924.14853-1-chris.packham@alliedtelesis.co.nz> <20190305201924.14853-2-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190305201924.14853-2-chris.packham@alliedtelesis.co.nz> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_133010_819267_5EEDBE4F X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, jason@lakedaemon.net, andrew@lunn.ch, gregory.clement@bootlin.com, linux-kernel@vger.kernel.org, Rob Herring , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 06, 2019 at 09:19:22AM +1300, Chris Packham wrote: > The first interrupt is for the regular watchdog timeout. Normally the > RSTOUT line will trigger a reset before this interrupt fires but on > systems with a non-standard reset it may still trigger. > > The second interrupt is for a timer1 which is used as a pre-timeout for > the watchdog. > > Signed-off-by: Chris Packham > --- > Changes in v2: > - new, split out from "watchdog: orion_wdt: use timer1 as a pretimeout" > > arch/arm/boot/dts/armada-38x.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi > index 929459c42760..fc550c640ca8 100644 > --- a/arch/arm/boot/dts/armada-38x.dtsi > +++ b/arch/arm/boot/dts/armada-38x.dtsi > @@ -376,6 +376,8 @@ > reg = <0x20300 0x34>, <0x20704 0x4>, <0x18260 0x4>; > clocks = <&coreclk 2>, <&refclk>; > clock-names = "nbclk", "fixed"; > + interrupts-extended = <&gic GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>, > + <&gic GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>; This will need to be documented, possibly including the use of interrupts-extended (currently only interrupts is documented in Documentation/devicetree/bindings/watchdog/marvel.txt). Also, how would it be handled if the primary interrupt is not specified ? After all, it is optional. Thanks, Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel