From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75835C43381 for ; Wed, 6 Mar 2019 02:59:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4286B20675 for ; Wed, 6 Mar 2019 02:59:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DSp0sLpO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="DHW/YBNj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4286B20675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KQ7tL6d1eOLWG6yBlKBzh8JWMVER0lOn0A6dUE6ZuyI=; b=DSp0sLpOqobHg3 S7wFJ4XHhgCYXF86jCjC2HlHcpNVdHHaUwBghKkyDPa9unoPy0euofCbSfDVpOmZ3kfvuEYYLKkVq c/Bz77cOSwZitIzE3Xsk4nIDTwzdjA2UO1fxV3LTn5Kvx62FKCkD2u1Y9VwsUcVxNiihDkejFqiEv CpvysbVwfUHNmzyd9bOjrn/p25fuzTblfJ6Wo8P4A4ocz/RWNhlfohVzqIuPXxQsYn4T87biXxsg6 q1HUsk4D9uJsP6KGw0VQA0kfqYEBsa/9jtddNhBvJwdNDKqf0aBi506aRCIPMazq20Bk5iXA0OTeS qtmFVv6D4VtD7lSBGKNQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1Mm4-0005Nb-VY; Wed, 06 Mar 2019 02:59:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1Mm1-0005Ms-Nx for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2019 02:59:15 +0000 Received: from dragon (61-216-91-114.HINET-IP.hinet.net [61.216.91.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0379220675; Wed, 6 Mar 2019 02:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551841152; bh=osM66By3LY4Eke2CyQeQ2vwup2tO7woBRnpW5XQ+K/I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DHW/YBNjUJHMy0n7XmcZ3BzmhBu00WykSe7gH6MTiJK8jjeL+QXK+MH6hNig5hr9j P2G8Yqn26KoBa0j6cgryJI0rAaMgEXzVRko+zP42MM8s9rjiqh/U/icEYFV5t5d9xk Io9v0MOMkkW7Zdl2+As8y8GvJolFz22oglqqXxbU= Date: Wed, 6 Mar 2019 10:58:04 +0800 From: Shawn Guo To: Wen Yang Subject: Re: [PATCH v2 05/15] ARM: imx51: fix a leaked reference by adding missing of_node_put Message-ID: <20190306025803.GG26041@dragon> References: <1551785646-46173-1-git-send-email-wen.yang99@zte.com.cn> <1551785646-46173-5-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1551785646-46173-5-git-send-email-wen.yang99@zte.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_185913_802655_EDAF9634 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wang.yi59@zte.com.cn, Sascha Hauer , linux-kernel@vger.kernel.org, Russell King , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 05, 2019 at 07:33:56PM +0800, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-imx/mach-imx51.c:64:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 57, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang > Reviewed-by: Florian Fainelli > Cc: Russell King > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: Lucas Stach > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > v2->v1: add a missing space between "adding" and "missing" I fixed it against v1 which I applied on my branch. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel