From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E381AC43381 for ; Thu, 7 Mar 2019 15:39:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2D9520652 for ; Thu, 7 Mar 2019 15:39:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A7qVJolm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2D9520652 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C769duDhm0h5Q5/hH2/VZk9tDzLNfAuDMwbi7uG2ZW8=; b=A7qVJolmXFh2W+xSrkDq0x1qs 6Q7avc8gQypImzfkxrgdGAd4q7O/NHnm97hfsqbGhJZkZXOlr0oxzb2RAHOCBvOpcJxC0PEDpJ7Ul 7uHGfFR6NiunS5ldbozzSewMV8ex8xshOjTfqUlzGKvb8X/JZoTm5FW9guOVZ/YrKyI4feiZxkkYn dt74uBlTMNSiTDWytgHxBoteWUmzlyplnCGA5oo9Fn8Ic0qEMtGvfcEr8MLv2IGwgxw0uFiRc9XYc 7KxZLhk+dsejmqAKv6eBtRTD2YWiD9VK/FbyQRtUtlLiooxo1ETePrmHoCMu0wHcnbxNTbTMBL3gB GzRa+wADg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1v7c-0007tm-DS; Thu, 07 Mar 2019 15:39:48 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1v7Y-0007t0-Ph for linux-arm-kernel@lists.infradead.org; Thu, 07 Mar 2019 15:39:46 +0000 X-Originating-IP: 90.88.150.179 Received: from localhost (aaubervilliers-681-1-31-179.w90-88.abo.wanadoo.fr [90.88.150.179]) (Authenticated sender: maxime.ripard@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 8E7B560016; Thu, 7 Mar 2019 15:39:35 +0000 (UTC) Date: Thu, 7 Mar 2019 16:39:35 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH v9 2/5] drm/sun4i: sun6i_mipi_dsi: Fix TCON DRQ set bits Message-ID: <20190307153935.uxh2hsmahw5l7h4q@flea> References: <20190303173527.31055-1-jagan@amarulasolutions.com> <20190303173527.31055-3-jagan@amarulasolutions.com> <20190304154320.uledvwz5jhzt22o3@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190307_073945_135114_FE0D6039 X-CRM114-Status: GOOD ( 23.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-sunxi , linux-kernel , dri-devel , Chen-Yu Tsai , Daniel Vetter , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel Content-Type: multipart/mixed; boundary="===============4715364489551927425==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4715364489551927425== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="soqv4aznyvd3ei55" Content-Disposition: inline --soqv4aznyvd3ei55 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 07, 2019 at 05:49:07PM +0530, Jagan Teki wrote: > On Mon, Mar 4, 2019 at 9:13 PM Maxime Ripard = wrote: > > > > On Sun, Mar 03, 2019 at 11:05:24PM +0530, Jagan Teki wrote: > > > TCON DRQ for non-burst DSI mode can computed based on horizontal > > > front porch value, but the current driver trying to include sync > > > timings along with front porch resulting wrong drq. > > > > > > This patch is trying to update the drq by subtracting hsync_start > > > with hdisplay, which is horizontal front porch. > > > > > > Current code: > > > ------------ > > > mode->hsync_end - mode->hdisplay =3D> horizontal front porch + sync > > > > > > With this patch: > > > ---------------- > > > mode->hsync_start - mode->hdisplay =3D> horizontal front porch > > > > > > BSP code form BPI-M64-bsp is computing TCON DRQ set bits > > > for non-burts as (from linux-sunxi/ > > > drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) > > > > > > =3D> panel->lcd_ht - panel->lcd_x - panel->lcd_hbp > > > =3D> (timmings->hor_front_porch + panel->lcd_hbp + panel->lcd_x) > > ^ + sync length + > > > - panel->lcd_x - panel->hbp > > > =3D> timmings->hor_front_porch > > ^ + sync > > > =3D> mode->hsync_start - mode->hdisplay > > > > s/hsync_start/hsync_end/ >=20 > No, it should be front porch so it is hsync_start. This change is > trying to update DRQ set to use front porch and above evaluation from > BSP, result the same front front porch >=20 > Current driver has hsync_end - hdisplay which is not front porch > timing (it is adding extra sync timing). It would be if you considered that the back porch actually was the back porch plus the sync length. I have found no such evidence, quite the opposite actually, everything seems to point at the fact that unlike the TCON, the DSI block uses the back porch as only the back porch. > I believe this is something similar like fixed patches for VBP, HBLK > timings. > > > Did you encounter any panel where this was fixing something? If so, > > which one, and what is the matching timings and / or datasheet? >=20 > W/O this change Bananapi s070wv20 panel has issue on striped lines on > the panel[1] and timings are >=20 > static const struct drm_display_mode s070wv20_default_mode =3D { > .clock =3D 30000, > .vrefresh =3D 60, >=20 > .hdisplay =3D 800, > .hsync_start =3D 800 + 40, > .hsync_end =3D 800 + 40 + 48, > .htotal =3D 800 + 40 + 48 + 40, >=20 > .vdisplay =3D 480, > .vsync_start =3D 480 + 13, > .vsync_end =3D 480 + 13 + 3, > .vtotal =3D 480 + 13 + 3 + 29, > }; >=20 > Which is similar like in panel-simple "bananapi,s070wv20-ct16" >=20 > Here is the DSI panel patches and sequence: > [pixel clock is 30Mhz] https://patchwork.kernel.org/patch/10680331/ > https://github.com/yesnoandor/x300/blob/master/kernel/arch/arm/boot/dts/e= robbing/x300/x300.dtsi#L81 > https://github.com/wxzed/Raspberry_5MIPI_Display/blob/master/I2C_Slave/US= ER/main.c#L15 > https://github.com/eliot-shao/qcom/blob/master/icn6211_cxn0102/kernel/dri= vers/video/msm/mdss/mdss_i2c_interface.c#L152 What are those supposed to be? It doesn't look like timings but rather init= ialization sequences > matches timings for > https://github.com/eliot-shao/qcom/blob/master/icn6211_cxn0102/kernel/arc= h/arm/boot/dts/qcom/dsi-mipi-2-rgb_1280p_video.dtsi#L20 That's not even the same resolution.. > https://github.com/zestroly/micromat/blob/master/test/raspberry/ICN6211.c= pp#L169 And this isn't a set of timings either. > Attached is panel datasheet. Which is for an RGB panel... not a MIPI-DSI one. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --soqv4aznyvd3ei55 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXIE7NgAKCRDj7w1vZxhR xcMeAP4kn2YpZQ4AzJn+YzRG0MXsTGozFHtiqyJBN8em8RoMPgD+P3sYldV1IwPU bLBDM15sBNfruh11kHdpKnqdqaPpiwU= =PIWo -----END PGP SIGNATURE----- --soqv4aznyvd3ei55-- --===============4715364489551927425== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4715364489551927425==--