From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC9AC43381 for ; Sat, 9 Mar 2019 03:52:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC14D207E0 for ; Sat, 9 Mar 2019 03:52:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GWQWOkLB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="m9ayY6z/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC14D207E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OaW+vFQd5zOlaFp5eoNldhHkXJIlzqEJg17oBrRAmv8=; b=GWQWOkLBgTK4zz s12h93mn749PKZjpvEEAso/bI2tQwQUM5GDts5tJLrZzx3uFVQ5/H8+hVzg6/LmB2VXz4gKI/YCJ8 KI4BipnBC3mlqe29iQHDBaSF74691dx1HQZ69Ptj2sotxtErTpf+TmDTjgCHVCYFXquORYvePcaDq MR3xFEKMhSCqIuG6HwP1l7Q+ne0r8KBAOw/AGpxYKv/LOmb5BSj9U3AamzNH3oq/Vvw1adNFS5cYs LzditDyzFesP2YD6fM0gvd2BeUXe7F7a/Bum/TficcHXCAbXPI3DstU7w2lVUnD9M3viZVZZ4F7DY DHtlhHo5fV1KEPPyoUYw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2T2O-0003B8-Tr; Sat, 09 Mar 2019 03:52:40 +0000 Received: from mail-it1-x141.google.com ([2607:f8b0:4864:20::141]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2T2L-0003AJ-Au for linux-arm-kernel@lists.infradead.org; Sat, 09 Mar 2019 03:52:38 +0000 Received: by mail-it1-x141.google.com with SMTP id z124so24435024itc.2 for ; Fri, 08 Mar 2019 19:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=m377kZJyLVBelvFNmvVkrDdNPU+nsXM2F8Z21iX0YCQ=; b=m9ayY6z/EzLJdpsqf0ARQ566h+fNvCK43sc+5RsrKitBH7l5IJYnyxlVcknqGnusWm 8TImiEA0X5wRp3f/WwfSofXpUBq0c3qgw+Y2wFaZBQo7LBl8E74BezC+JelThr8zR9vI eXsReEoRW6yjw4vwYV/ysGsz0oWGP+YtMAAiWcGOt7mJ0iXbuQSf2Wu3fxyQlrCRfrc7 Gfoe6yYd2LjcztJi7lssLpYsp5FbeuckI6Y8DKDyuD52nfWkYUyh6Y6MPW3tDGMcTlN3 PjT4U5nwWQ9kNQTSwfKeomhDAc+f1VEWOnQICfQTktrA3mtrIZUZdNq7nVaUtDirbyXF xRrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=m377kZJyLVBelvFNmvVkrDdNPU+nsXM2F8Z21iX0YCQ=; b=Sz7gGbOWqNfoDyjnj93WzPRnQWxQj8/yrfJu2EdvPIfzsa2fwf+d0OByuUZDDZaXtM SQaGx46B5o3hGHo8h2rNiEaW/EPhRWP5qYRTIRmhJXcsolGVZ3BIe72iKzV8CsY8Qst/ m3BBHs4YbRY1Pg3G0UPNrBWgs0AyEkblqiELFlDxRYO+C1jW+telV+KI3LNIGW0XIymp G6cOKDKojnb2pRi+2xbqwuk1HiGGT4E2h5/2ir1VSuI3XBwSRCT7DqSBpm4isAayygMh m8dugBSZ5GqEdN+uDAeXfYcpkhxGffTfa7v7JVgMgZvBKGGHfcn2XKmpjL1ZPZILoJ0t X6ZA== X-Gm-Message-State: APjAAAUBnZQ/bwno72dDwMSJWntnycwEKfOsYrkQD5M9tIwggsSn6jYp EcSlbcbV5nx3Xpr3mFAFmOYU5g== X-Google-Smtp-Source: APXvYqwCbLxEH0MAwR0zOVXRARtteHVK25Cgv6im4wYGYLl/7gE17TQQw41o7bgV8bkBqOTUfLBQwQ== X-Received: by 2002:a24:38f:: with SMTP id e137mr8855070ite.99.1552103552925; Fri, 08 Mar 2019 19:52:32 -0800 (PST) Received: from google.com ([2620:15c:183:0:a0c3:519e:9276:fc96]) by smtp.gmail.com with ESMTPSA id n4sm3928063ioa.26.2019.03.08.19.52.31 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 08 Mar 2019 19:52:32 -0800 (PST) Date: Fri, 8 Mar 2019 20:52:27 -0700 From: Yu Zhao To: Mark Rutland Subject: Re: [PATCH v2 2/3] arm64: mm: don't call page table ctors for init_mm Message-ID: <20190309035227.GA214016@google.com> References: <20190214211642.2200-1-yuzhao@google.com> <20190218231319.178224-1-yuzhao@google.com> <20190218231319.178224-2-yuzhao@google.com> <20190226151307.GB20230@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190226151307.GB20230@lakrids.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190308_195237_402951_D77CA8A6 X-CRM114-Status: GOOD ( 24.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Ard Biesheuvel , Peter Zijlstra , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, Nick Piggin , Jun Yao , linux-mm@kvack.org, "Aneesh Kumar K . V" , Chintan Pandya , Joel Fernandes , "Kirill A . Shutemov" , Andrew Morton , Laura Abbott , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 26, 2019 at 03:13:07PM +0000, Mark Rutland wrote: > Hi, > > On Mon, Feb 18, 2019 at 04:13:18PM -0700, Yu Zhao wrote: > > init_mm doesn't require page table lock to be initialized at > > any level. Add a separate page table allocator for it, and the > > new one skips page table ctors. > > Just to check, in a previous reply you mentioned we need to call the > ctors for our efi_mm, since we use apply_to_page_range() on that. Is > that only because apply_to_pte_range() tries to take the ptl for non > init_mm? Precisely. > ... or did I miss something else? > > > The ctors allocate memory when ALLOC_SPLIT_PTLOCKS is set. Not > > calling them avoids memory leak in case we call pte_free_kernel() > > on init_mm. > > > > Signed-off-by: Yu Zhao > > Assuming that was all, this patch makes sense to me. FWIW: > > Acked-by: Mark Rutland Thanks. > Thanks, > Mark. > > > --- > > arch/arm64/mm/mmu.c | 15 +++++++++++++-- > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > > index fa7351877af3..e8bf8a6300e8 100644 > > --- a/arch/arm64/mm/mmu.c > > +++ b/arch/arm64/mm/mmu.c > > @@ -370,6 +370,16 @@ static void __create_pgd_mapping(pgd_t *pgdir, phys_addr_t phys, > > } while (pgdp++, addr = next, addr != end); > > } > > > > +static phys_addr_t pgd_kernel_pgtable_alloc(int shift) > > +{ > > + void *ptr = (void *)__get_free_page(PGALLOC_GFP); > > + BUG_ON(!ptr); > > + > > + /* Ensure the zeroed page is visible to the page table walker */ > > + dsb(ishst); > > + return __pa(ptr); > > +} > > + > > static phys_addr_t pgd_pgtable_alloc(int shift) > > { > > void *ptr = (void *)__get_free_page(PGALLOC_GFP); > > @@ -591,7 +601,7 @@ static int __init map_entry_trampoline(void) > > /* Map only the text into the trampoline page table */ > > memset(tramp_pg_dir, 0, PGD_SIZE); > > __create_pgd_mapping(tramp_pg_dir, pa_start, TRAMP_VALIAS, PAGE_SIZE, > > - prot, pgd_pgtable_alloc, 0); > > + prot, pgd_kernel_pgtable_alloc, 0); > > > > /* Map both the text and data into the kernel page table */ > > __set_fixmap(FIX_ENTRY_TRAMP_TEXT, pa_start, prot); > > @@ -1067,7 +1077,8 @@ int arch_add_memory(int nid, u64 start, u64 size, struct vmem_altmap *altmap, > > flags = NO_BLOCK_MAPPINGS | NO_CONT_MAPPINGS; > > > > __create_pgd_mapping(swapper_pg_dir, start, __phys_to_virt(start), > > - size, PAGE_KERNEL, pgd_pgtable_alloc, flags); > > + size, PAGE_KERNEL, pgd_kernel_pgtable_alloc, > > + flags); > > > > return __add_pages(nid, start >> PAGE_SHIFT, size >> PAGE_SHIFT, > > altmap, want_memblock); > > -- > > 2.21.0.rc0.258.g878e2cd30e-goog > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel