From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0C12C43381 for ; Mon, 11 Mar 2019 10:12:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90C0820657 for ; Mon, 11 Mar 2019 10:12:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n6EUDyld"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="IoMxRZXh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90C0820657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oNYaqsz9Z7RNw/v/UK6wjSqVqFbhhthO6bLtC0GBwfw=; b=n6EUDyldE81Q4RgULiQTQ9FP3 ERQfAcXPojxa563Lz7uP7abnqc1Ot/dX/quDsTyBKzmxU7FUPk1tH8+nZmSX8rfEE2NAZ8DNVxMmz 1skww/xmqevk7k1aBl89s3ZzBgJNs4NYteuSc2hgqZiMQ7PHg+tMz9aeBtijyTsNod0cwpa7hIw3Q qWOmkwA55QWq0LQ1NKJS0r0/N1ZfQALwKDFywuVduD/kRRCcyIAXAf08Bq/Q8N7MBxQ7zaUc9OGl5 B110v9MJQNvFpF3aUkr2uSxQ9JOH9TrG8DzUUxmeNj0kAClNxEQsBCKg0yAVuyS6R8W21gK5eTlFt CzptiK6Vg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3Huu-0000mP-3Q; Mon, 11 Mar 2019 10:12:20 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3Hus-0000mF-GL for linux-arm-kernel@bombadil.infradead.org; Mon, 11 Mar 2019 10:12:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VKKErtzUAMyLD1XLnY1mZWj9MuQceBqIOPGv62OOBpE=; b=IoMxRZXhcqsMp01h+ES32Vx0L 2UhnldIRtH9NS8ORMtKnk+1hVit6qCs/9R+EYQ/Qj5TCZUIEgSbPvxmany052HJdx4vtJdqVWitnN VsZfBgr/rq7ztx5mcU5sPQ4NQYMMivVfw7mlo0H7QdItADsEKmPrLW449r9WPh5JzJc6Gohnv8Ey5 OZj4vDJS4c/3zPmQya28h4QLGo9WHcda4uCzjpjkI+njb477uAWzLoonFTQBS2ge/pBcBzL1DnTdY XJyFDDcs6SzMMn1lmCOe3gW/LWIVs1S4bjLoNJTuPwmK0jWzucH6OMc3haZ+qhRKnqQvwlTbQr0Vu MizzX9Gqg==; Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3Huo-0005v4-SR for linux-arm-kernel@lists.infradead.org; Mon, 11 Mar 2019 10:12:16 +0000 X-Originating-IP: 90.88.150.179 Received: from localhost (aaubervilliers-681-1-31-179.w90-88.abo.wanadoo.fr [90.88.150.179]) (Authenticated sender: maxime.ripard@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id B94421BF218; Mon, 11 Mar 2019 10:11:30 +0000 (UTC) Date: Mon, 11 Mar 2019 11:11:30 +0100 From: Maxime Ripard To: Chen-Yu Tsai Subject: Re: [PATCH v3 1/7] dt-bindings: interconnect: Add a dma interconnect name Message-ID: <20190311101130.7t7rctxlqly3uqmt@flea> References: <43eeca13733faefe62f9facc25b8e88f7e593f61.1549897336.git-series.maxime.ripard@bootlin.com> <553c987c-da9a-1f85-fb16-4b9fe17dd14b@linaro.org> <20190305155337.glfvgyddvnkv774m@flea> <0e72fbf7-b100-ddc5-3c19-32f71c37f76f@arm.com> <477995b0-9ac3-b6ca-f5f2-856e4af926f1@linaro.org> <20190307154755.5kgc7oh4b5bhg2fj@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190311_101214_965074_971CADE0 X-CRM114-Status: GOOD ( 38.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Thomas Petazzoni , Arnd Bergmann , Robin Murphy , dri-devel , Dave Martin , Paul Kocialkowski , Chen-Yu Tsai , Rob Herring , Yong Deng , Frank Rowand , Georgi Djakov , linux-arm-kernel Content-Type: multipart/mixed; boundary="===============8422790818663255669==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8422790818663255669== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cgjcr5o5hj4pdzgw" Content-Disposition: inline --cgjcr5o5hj4pdzgw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 08, 2019 at 12:09:47AM +0800, Chen-Yu Tsai wrote: > On Thu, Mar 7, 2019 at 11:48 PM Maxime Ripard = wrote: > > > > On Thu, Mar 07, 2019 at 05:15:20PM +0200, Georgi Djakov wrote: > > > Hi, > > > > > > On 3/5/19 18:14, Robin Murphy wrote: > > > > On 05/03/2019 15:53, Maxime Ripard wrote: > > > >> Hi, > > > >> > > > >> On Fri, Mar 01, 2019 at 07:48:15PM +0200, Georgi Djakov wrote: > > > >>> On 2/11/19 17:02, Maxime Ripard wrote: > > > >>>> The current DT bindings assume that the DMA will be performed by= the > > > >>>> devices through their parent DT node, and rely on that assumption > > > >>>> for the > > > >>>> address translation using dma-ranges. > > > >>>> > > > >>>> However, some SoCs have devices that will perform DMA through > > > >>>> another bus, > > > >>>> with separate address translation rules. We therefore need to > > > >>>> express that > > > >>>> relationship, through the special interconnect name "dma". > > > >>>> > > > >>>> Signed-off-by: Maxime Ripard > > > >>>> --- > > > >>>> Documentation/devicetree/bindings/interconnect/interconnect.tx= t | > > > >>>> 3 +++ > > > >>>> 1 file changed, 3 insertions(+) > > > >>>> > > > >>>> diff --git > > > >>>> a/Documentation/devicetree/bindings/interconnect/interconnect.txt > > > >>>> b/Documentation/devicetree/bindings/interconnect/interconnect.txt > > > >>>> index 5a3c575b387a..e69fc2d992c3 100644 > > > >>>> --- a/Documentation/devicetree/bindings/interconnect/interconnec= t.txt > > > >>>> +++ b/Documentation/devicetree/bindings/interconnect/interconnec= t.txt > > > >>>> @@ -51,6 +51,9 @@ interconnect-names : List of interconnect path > > > >>>> name strings sorted in the same > > > >>>> interconnect-names to match interconnect paths wi= th > > > >>>> interconnect > > > >>>> specifier pairs. > > > >>>> + Reserved interconnect names: > > > >>>> + * dma: Path from the device to the main > > > >>>> memory of the system > > > >>> > > > >>> Bikeshed: As it's from the device to the main memory, maybe here = we can > > > >>> also denote this my calling the path dma-mem or dma-memory. For o= ther > > > >>> paths, we are trying to mention both the source and the destinati= on and > > > >>> maybe it would be good to be consistent although this is special = one. > > > >> > > > >> I'm not sure I understand what you mean. You'd like two interconne= ct > > > >> names, one called dma-memory, and one memory-dma? > > > > > > > > Hmm, yes, it's not like "dma" describes an actual source or destina= tion > > > > either :/ > > > > > > IIUC, it's a path (bus) that a dma device use to access some memory > > > (read or/and write). So i have used source-destination above more in = the > > > sense of initiator-target or master-slave. My suggestion was just to > > > change the reserved interconnect name from "dma" to "dma-mem" or > > > "dma-memory". > > > > If dma is an issue in itself, maybe we can call it "device-memory" ? >=20 > Might I ask what happens if the device can both DMA to and from memory? We can create another one called memory-device if that's needed? > IIRC the display frontends, backends, and mixers all have writeback > capability, using the same interconnect port. I think in both cases it's the same path. The camera driver also need to have that offset, even though it's a producer and not a consumer, and the VPU does too. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --cgjcr5o5hj4pdzgw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXIY0UgAKCRDj7w1vZxhR xWlzAQDQWxjEX8QrpJ0nCrdPzyE5N6pgFtbmWODK1evHzMqRTQEA8b3Igx1mPZoF I5Smn7hZCFuJtSJuAFxmmpEUIMVwtgQ= =UI++ -----END PGP SIGNATURE----- --cgjcr5o5hj4pdzgw-- --===============8422790818663255669== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8422790818663255669==--