From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96595C43381 for ; Mon, 11 Mar 2019 13:00:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EF1C2075C for ; Mon, 11 Mar 2019 13:00:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZCyjtstS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="SpM7sVz6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EF1C2075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wzf3RAioOpgotJcqVOlUVvP5RSiioUeI7CQVIrri56U=; b=ZCyjtstS9FNt5d 8s05v897jPdDNd93O6rvZ0aAyAhvTqoKsu49JwpSkrS9V6AEqFYKkpwBC30/Z64FinRE/SzH9mm5k LEv14kAkh1aQEiCLUHX2jmpuUoi3joQ6LYOvWyE5ooKuZZkUpwQH36lHVxpsIS5YBSP5PEYShaGVj P17oRkrU20/qW4PuOljVkPaoAgmqQ/DCGjUQ3TDtuX8MaKNPviUFNp7oMTWloL2b6IalClgZHPcmz 40eI5Lp3eQifNnXwCPMSg0J+zCBMNyRkOahYEma2BpEm9pcSaqk9zorgs1vQ3wiDJUfYbifk/xeuU hf7DVunOITCJMkAE96Rg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3KXt-0007dq-B3; Mon, 11 Mar 2019 13:00:45 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3KXm-0007d7-A7 for linux-arm-kernel@lists.infradead.org; Mon, 11 Mar 2019 13:00:43 +0000 Received: by mail-ed1-x543.google.com with SMTP id r23so1413055edm.7 for ; Mon, 11 Mar 2019 06:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2UntTb0a1mBcbLGb31/L3RtCOXqvVe5fTf5lWVQp4O0=; b=SpM7sVz6lEdM7V/VipOqcnsgSZ8JDYvQTK2/vwz5Cxh7/sebV51F3Km4E3Cn7EqLwG hEK30uS4cnSg/9/Zc5dGWJghk/u2ubFDKpAsdnNTPf9z918FZxRxnZrTxMF5dsTygONO uHRUGnMp8QGawezHIX9qKyTZiwnB4gvzBubZM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=2UntTb0a1mBcbLGb31/L3RtCOXqvVe5fTf5lWVQp4O0=; b=FFxl51B7x2ZiqCxw/zcbkhldntBFvVEKIEMRpbggk8/o75jsNLlmvRuwI6jp/MEAeo BqeZIJlGJfhR3QdxTHry3f1Yush1oOfzCkX7a7DRU3FsWa/bV9ncFmfhwQTBn1lSBAc9 /i6D6dR+xeBie7H0pupbsN+KKYqXDrLk8q5FIf33lQ+RZJtXQdoJfduCCVmsQ7/WfdEH KRpLsE8FhuOiwilD14Dl8HrbG3Vi3N2qBMeaPieJsGj0TakjsqnNLYpigFbrmrCag9DK BFyglT08lBOCQP7FPfWr12XfxHipFgKHmpiQzOttZoiiBIG6BsUSrcnxpILy/3phWAV0 2U/A== X-Gm-Message-State: APjAAAV0/Q79Q6ahJFVP+m5jo1g+khWEFqMCXsD0x3UCDMC7wZofVG/Q Cs4K4sTRv73AAE/eSKvXb1SXPQ== X-Google-Smtp-Source: APXvYqwCvQJVwrTig24wiAlKy6rFbFpYSnpcZsSHkOC3Mr1D+tAphp5zcpOTnfwGj8DjJvLTHvPacQ== X-Received: by 2002:a17:906:4819:: with SMTP id w25mr21852866ejq.150.1552309236029; Mon, 11 Mar 2019 06:00:36 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id gr15sm3063505ejb.8.2019.03.11.06.00.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Mar 2019 06:00:35 -0700 (PDT) Date: Mon, 11 Mar 2019 14:00:33 +0100 From: Daniel Vetter To: Maxime Ripard Subject: Re: [PATCH 0/7] drm/vc4: Allow for more boot-time configuration Message-ID: <20190311130033.GC2665@phenom.ffwll.local> References: <87o96q76c6.fsf@anholt.net> <20190305091416.37w5nz4c3wjnder6@flea> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190305091416.37w5nz4c3wjnder6@flea> X-Operating-System: Linux phenom 4.19.0-1-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190311_060038_351824_2064D2ED X-CRM114-Status: GOOD ( 14.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eben@raspberrypi.org, David Airlie , dri-devel@lists.freedesktop.org, Paul Kocialkowski , Eric Anholt , Sean Paul , Thomas Petazzoni , Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 05, 2019 at 10:14:16AM +0100, Maxime Ripard wrote: > Hi, > > On Mon, Mar 04, 2019 at 12:06:01PM -0800, Eric Anholt wrote: > > > Since a change of the command line parser can pretty easily get things > > > wrong and introduce regressions, I also worked with a number of unit tests > > > that you can find here: http://code.bulix.org/tpo7dg-607264?raw > > > > Would kselftests be an appropriate way to include these, maybe? > > That looks like a good way to do this indeed. I'll try it and let you know drm/selftests already has a pile of infrastructure, together with igt and will be run in intel-gfx-ci to make sure stuff keeps working. And yeah parser like this is imo the perfect selftest use-case. If you wonder about kselftest and kunit and all that: We have some compat glue, but I do hope that longterm we can all unify these internal self/unit tests under one framework. For now I recommend the drm one, since that's CI'ed. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel