From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4AADC43381 for ; Mon, 11 Mar 2019 14:14:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1C5F2075C for ; Mon, 11 Mar 2019 14:14:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P5x1EE6/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="jw3GanCN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1C5F2075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g0BC0B81OH5WeicXL6pcrc7AMTb5m+a7FquDGvhTu94=; b=P5x1EE6/39Lbg8 DKlvmuQ+XI4YngaRiKPQtn3bY7/GAd4W6m5xJ/4tK1qQ0vkICPaKbJeGFkTXTiI7UXy/pUl1HfGg+ yffHwhXeIc09ZAAyugj+dYxb3roip+ZXK9JqJpAfLP8RUdjswaRUCAeHrjO8GS1SOt2zonDr7jOJn Z2QBSCctycJ93z1c78taC7UhrpBr1aQWS4FXIbNqtE/Yvc8RCVpwTxc2/ox9TzzZgXIm1n2TAserq o2WINq5NE/2tI4RKpdCSMO982+8mCLulHi5D52Vsiss9PPb85EXUwVW07NzuAyFR0ttZ/pQmWBoEF J9WDI6KzHPf3aPOvPMMg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3Lgt-0005Vp-Ej; Mon, 11 Mar 2019 14:14:07 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3Lgp-0005VN-SA for linux-arm-kernel@lists.infradead.org; Mon, 11 Mar 2019 14:14:05 +0000 Received: from localhost (50-82-46-41.client.mchsi.com [50.82.46.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2011E2075C; Mon, 11 Mar 2019 14:14:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552313643; bh=DeX8Tnx+/DvUL5y4hqhKMNh6svHiIweAR/X01hBixrg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jw3GanCNRK5zOAUggeNcCLXf2gu+Te/x/v63BGlFcM5iPhC4IOwu7qusrBLF2QC6c 1DPqMPZZERwbkicjMPy/bRFrbGixD/Gd2dybpkFgExHP+dJe2OpkKprEFMiSDcoi/I 9+4BXSxLCO89Wg9J/TK3F7U80s9c2HkASxYTUoyE= Date: Mon, 11 Mar 2019 09:14:02 -0500 From: Bjorn Helgaas To: "Z.q. Hou" Subject: Re: [PATCHv4 11/28] PCI: mobiveil: only fix up the Class Code field Message-ID: <20190311141401.GG214730@google.com> References: <20190311093130.7209-1-Zhiqiang.Hou@nxp.com> <20190311093130.7209-12-Zhiqiang.Hou@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190311093130.7209-12-Zhiqiang.Hou@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190311_071404_004182_4529E7BA X-CRM114-Status: GOOD ( 18.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "lorenzo.pieralisi@arm.com" , Xiaowei Bao , "linux-pci@vger.kernel.org" , "l.subrahmanya@mobiveil.co.in" , "will.deacon@arm.com" , "linux-kernel@vger.kernel.org" , Leo Li , "M.h. Lian" , "robh+dt@kernel.org" , Mingkai Hu , "catalin.marinas@arm.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 11, 2019 at 09:31:23AM +0000, Z.q. Hou wrote: > From: Hou Zhiqiang > > Fix up the Class Code to PCI bridge, do not change the Revision ID. > And move the fixup to mobiveil_host_init function. Add parens after function name. Please explain why this change is needed. Does it fix a bug? Does this fix the problem that the PCI core didn't correctly identify the device as a bridge because it identified bridges by class code instead of header type? That problem *should* be fixed by b2fb5cc57469 ("PCI: Rely on config space header type, not class code"), which is now upstream. You might still want this class code change so that lspci shows the correct thing. That's fine, but the changelog should say why we're doing it. > Fixes: 9af6bcb11e12 ("PCI: mobiveil: Add Mobiveil PCIe Host Bridge > IP driver") Make this "Fixes:" line a single line again. > Signed-off-by: Hou Zhiqiang > Reviewed-by: Minghuan Lian > Reviewed-by: Subrahmanya Lingappa > --- > V4: > - no change > > drivers/pci/controller/pcie-mobiveil.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c > index 78e575e71f4d..8eee1ab7ee24 100644 > --- a/drivers/pci/controller/pcie-mobiveil.c > +++ b/drivers/pci/controller/pcie-mobiveil.c > @@ -653,6 +653,12 @@ static int mobiveil_host_init(struct mobiveil_pcie *pcie) > type, resource_size(win->res)); > } > > + /* fixup for PCIe class register */ > + value = csr_readl(pcie, PAB_INTP_AXI_PIO_CLASS); > + value &= 0xff; > + value |= (PCI_CLASS_BRIDGE_PCI << 16); > + csr_writel(pcie, value, PAB_INTP_AXI_PIO_CLASS); > + > /* setup MSI hardware registers */ > mobiveil_pcie_enable_msi(pcie); > > @@ -896,9 +902,6 @@ static int mobiveil_pcie_probe(struct platform_device *pdev) > goto error; > } > > - /* fixup for PCIe class register */ > - csr_writel(pcie, 0x060402ab, PAB_INTP_AXI_PIO_CLASS); > - > /* initialize the IRQ domains */ > ret = mobiveil_pcie_init_irq_domain(pcie); > if (ret) { > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel