From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9E8C43381 for ; Mon, 11 Mar 2019 15:38:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FF5421741 for ; Mon, 11 Mar 2019 15:38:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mtbMsl41" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FF5421741 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=boy7tqXKHs9njGKJkoLNnQmKUXFRGn9IgRVeE7hKjTQ=; b=mtbMsl41lpi/3j2uAcMy+Qqvj dL8LcUo3sVQ5afFCaXr8muuCfA7S2UQ0l1Q+/gubZ8c+fs9wS/Ej1xpzZaCV7+mexGE5U6YImwfw8 xU4Y8G62j7KJtQ8oBuB5wrah9e2YJRWOSEF/EPuHpEQKc+2BLwNiHBCuOVvUZSyLD39vOv5IM7ylU gWX6IFUTfUyIyqcue0+tcUOuebwk0BA+NUERWgs+Xb7RIT0sksU287LAoI05D+mSVSnRsqwZJVgvu COYQh6Mt8hbWkqvV4BzUB170xtQFecHvw9LLMdG5DDOvWHMrCBmCrJ+n1F/gqPZJF9R/rhuF0knHx bX6H9QzDg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3Mzz-0006xv-90; Mon, 11 Mar 2019 15:37:55 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3Mzu-0006xY-0f for linux-arm-kernel@lists.infradead.org; Mon, 11 Mar 2019 15:37:53 +0000 Received: from localhost (aaubervilliers-681-1-31-179.w90-88.abo.wanadoo.fr [90.88.150.179]) (Authenticated sender: maxime.ripard@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 2181910000A; Mon, 11 Mar 2019 15:37:34 +0000 (UTC) Date: Mon, 11 Mar 2019 16:37:34 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH v8 01/15] drm/sun4i: dsi: Fix video start delay computation Message-ID: <20190311153734.izg44ijwqqh2vpxc@flea> References: <20190311133637.18334-1-jagan@amarulasolutions.com> <20190311133637.18334-2-jagan@amarulasolutions.com> MIME-Version: 1.0 In-Reply-To: <20190311133637.18334-2-jagan@amarulasolutions.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190311_083750_357231_82EFEC94 X-CRM114-Status: GOOD ( 18.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , Michael Turquette , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Rob Herring , Daniel Vetter , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============3883504625507438873==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3883504625507438873== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gkffxe7wlup45xq3" Content-Disposition: inline --gkffxe7wlup45xq3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 11, 2019 at 07:06:23PM +0530, Jagan Teki wrote: > Vertical video start delay is computed by excluding vertical front > porch value from total vertical timings. >=20 > This clearly confirmed from BSP code and here how it computed, >=20 > (drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) > u32 vfp =3D panel->lcd_vt - panel->lcd_y - panel->lcd_vbp; > =3D> (panel->lcd_vt) - panel->lcd_y - (panel->lcd_vbp) > =3D> (timmings->ver_front_porch + panel->lcd_vbp + panel->lcd_y) > - panel->lcd_y - (panel->lcd_vbp) > =3D> timmings->ver_front_porch + panel->lcd_vbp + panel->lcd_y > - panel->lcd_y - panel->lcd_vbp > =3D> timmings->ver_front_porch >=20 > But the current driver is assuming it can exclude vertical front > porch along with vertical sync values from total vertical timings, > which resulting wrong start delay indeed wrong picture rendering > in the panel. Same story here: which panel, which datasheet, which "wrong picture rendering"? > Example: timings, where it produces the issue. > { > .vdisplay =3D 600, > .vsync_start =3D 600 + 12, > .vsync_end =3D 600 + 12 + 2, > .vtotal =3D 600 + 12 + 2 + 21, > } Can you 100% trust those timings? > It produces the desired start delay value as 19 but the correct working > value should be 513. > > So, Fix it by computing proper video start delay. >=20 > Fixes: 69006ef0ecb1 ("drm/sun4i: dsi: Change the start delay calculation") > Signed-off-by: Jagan Teki > --- > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun= 4i/sun6i_mipi_dsi.c > index 62a508420227..8d6292c0158b 100644 > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > @@ -364,8 +364,14 @@ static void sun6i_dsi_inst_init(struct sun6i_dsi *ds= i, > static u16 sun6i_dsi_get_video_start_delay(struct sun6i_dsi *dsi, > struct drm_display_mode *mode) > { > - u16 start =3D clamp(mode->vtotal - mode->vdisplay - 10, 8, 100); > - u16 delay =3D mode->vtotal - (mode->vsync_end - mode->vdisplay) + start; > + u16 delay =3D mode->vtotal - (mode->vsync_start - mode->vdisplay); > + > + /** > + * BSP comment: > + * put start_delay to tcon. set ready sync early to dramfreq, > + * so set start_delay 1 > + */ That doesn't make any sense to me... What does it mean? Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --gkffxe7wlup45xq3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXIaAvgAKCRDj7w1vZxhR xXs1AP0etuFMtzbwlTM4yI+9ntNLA+5Rp+ZPoilius9At8DlDwEA3fqiZzpYxCxO B9BgvlqO7a9/DDgDCcBEHJ3Wu9mv8wM= =D3L3 -----END PGP SIGNATURE----- --gkffxe7wlup45xq3-- --===============3883504625507438873== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3883504625507438873==--