From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53B6BC43381 for ; Tue, 12 Mar 2019 07:50:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21888214D8 for ; Tue, 12 Mar 2019 07:50:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UuVIdYM2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=umn.edu header.i=@umn.edu header.b="nHSku0XL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21888214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=umn.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=u3G+ru6F89qhtJv/2dYs7Cd3B1jETXqPMOvn2wpOGkg=; b=UuV IdYM2MXZeakFtMdfvpcWoCQ3uYzAYqLFwgzNyZJcT6aCy1UW3GCtjIbLfu1TUV/BjI8cAarodR5xK 8B5fnpdz8TKinyHCONtcLP3wSMDYvaiRPSA9KpRfJFeEJu3n9oL0z7gUXjfK04A220SltmAaWTdZo cOQdhj0rWDcFp9/2pt8FPRpnoXet4ycLQA0id6DcLCJJktvpiGeRzHz2yexLWNS0oGcsrlhILY2QT 5zO2SqSHWUtG81pBT4JIEH37+8vjNbrgRq4KPckI7L+XFGW4YafNTy6xZ0pb1G3an0F39Os8aM40X kEWW3HobdjO3eR8oEZ5/pKdoZbn4Gzw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3cBb-00043I-3X; Tue, 12 Mar 2019 07:50:55 +0000 Received: from mta-p7.oit.umn.edu ([134.84.196.207]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3cBX-00042f-Mo for linux-arm-kernel@lists.infradead.org; Tue, 12 Mar 2019 07:50:53 +0000 Received: from localhost (unknown [127.0.0.1]) by mta-p7.oit.umn.edu (Postfix) with ESMTP id 619969C5 for ; Tue, 12 Mar 2019 07:50:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p7.oit.umn.edu ([127.0.0.1]) by localhost (mta-p7.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N_SmbnMU1QVN for ; Tue, 12 Mar 2019 02:50:50 -0500 (CDT) Received: from mail-it1-f199.google.com (mail-it1-f199.google.com [209.85.166.199]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p7.oit.umn.edu (Postfix) with ESMTPS id 39E79836 for ; Tue, 12 Mar 2019 02:50:49 -0500 (CDT) Received: by mail-it1-f199.google.com with SMTP id o73so1471888itb.1 for ; Tue, 12 Mar 2019 00:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=cCzogPH+NILYsqX4kJaeZubessnMrupncJNs9YIpvCw=; b=nHSku0XLPT8YAk3cPSEu5ouAgNXBY137dQqHd7glQY1duamQeYYEYMMF8EbxnAQiW4 BSgPlerCbgnEeLV2mivsCmK+ZAo9x/hsQv/WJEiq2iIG7ogyy3UhBJZd82rwafWRqlp9 7itDVVnNCWCtUxYY6Wpv0NkqTOpIC8u0NrIUiucmlT+bov+QrXc+1lI03+7IIomUWBIu b6ldMUpfSXaQogsfwYKZ93I1cTZ/wAiiF5LN4ngWcUj8auo5mh/Nb/hcMlacCAK320/e kgjwCcTEmvruFRJmxksIWoA9t/szI88I+8M7Up6bM6KwfyMAGyR9GCX8pJRS5f1rXsLs VSPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cCzogPH+NILYsqX4kJaeZubessnMrupncJNs9YIpvCw=; b=oZOtZX6G8OaSXbwJ1jqjnB8fIyRXEeDX7U6aQXx9n4CurXg6ICAntVNX2wl0kYekHP qMsKau7wMH8LyA2mbs2O1c02HLN1Wb2jNaAaNaK/G5C0fiKAewMnQntxj5sQBGjiV0v3 /9p+NWwctvr92kVdOxUoFsoJJQ2tWxPeyTcsMfY3EjMUKmF5vL9BxIV/RvdAARxnr3ga lfr7K0eA1RtdOvRgmQnTqfCLzsaPCeqBguNRg7EgOAvOdhfQWezde8ZDXz4A06e6zgoq Hf5Jvjakd9Yx5/P2RqV0jyiOS+HOBoOfm3sTUKaxbb8VTUCp9NecLvi/bDe1+GeO7+wi vilw== X-Gm-Message-State: APjAAAXBkaSS3TRqxQJ6P7YP9U6UjaUOaEsOkBICtL33A3RvTyNP0l2U uiw9jhteaWbNe41rIzeaCgNSZbDwgLnK9NrqX4MUGPqBS1RWMErgdDF+WI4j5czZn2L6lKcYhh/ C321P/EOIE+t5DYDLBS7jATb8sv2pmBEY/NHjukc= X-Received: by 2002:a5d:93d9:: with SMTP id j25mr20449495ioo.305.1552377049005; Tue, 12 Mar 2019 00:50:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqySKdTwSbF12uEqKV+X5R0H6vQ6AW+F8lgxZfBZnn/CNF8EZx5T4x9srmlhOqht6eSmWxveLA== X-Received: by 2002:a5d:93d9:: with SMTP id j25mr20449475ioo.305.1552377048729; Tue, 12 Mar 2019 00:50:48 -0700 (PDT) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id c14sm3409784iot.13.2019.03.12.00.50.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2019 00:50:48 -0700 (PDT) From: Kangjie Lu To: kjlu@umn.edu Subject: [PATCH] net: dwmac-sun8i: fix a missing check of of_get_phy_mode Date: Tue, 12 Mar 2019 02:50:40 -0500 Message-Id: <20190312075040.32115-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190312_005051_825113_2EFEDAEA X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , Maxime Ripard , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Chen-Yu Tsai , Jose Abreu , Maxime Coquelin , pakki001@umn.edu, Giuseppe Cavallaro , "David S. Miller" , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_get_phy_mode may fail and return a negative error code; the fix checks the return value of of_get_phy_mode and returns -EINVAL of it fails. Signed-off-by: Kangjie Lu --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index 0f660af01a4b..195669f550f0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -1147,7 +1147,10 @@ static int sun8i_dwmac_probe(struct platform_device *pdev) return ret; } - plat_dat->interface = of_get_phy_mode(dev->of_node); + ret = of_get_phy_mode(dev->of_node); + if (ret < 0) + return -EINVAL; + plat_dat->interface = ret; /* platform data specifying hardware features and callbacks. * hardware features were copied from Allwinner drivers. -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel