Re: sun6i MIPI DSI driver EoTp

Maxime Ripard
2019-03-13T15:20:42Z

[-- Attachment #1.1: Type: text/plain, Size: 1663 bytes --]

On Tue, Mar 12, 2019 at 10:17:49PM +0300, Sergey Suloev wrote:
> On 3/12/19 6:52 PM, Maxime Ripard wrote:
> > Hi,
> >
> > On Mon, Mar 11, 2019 at 09:43:36PM +0300, Sergey Suloev wrote:
> > > according to MIPI DSI spec chapter 8.8.2  the EoTp packet can be enabled or
> > > disabled on the protocol level.
> > > It seems like that it might be required for the panel I am working on (Himax
> > > HX8379A-based panel).
> > > Here is some crappy driver I found on github showing that it might be an
> > > issue  [1]
> > >
> > > May I ask you if this feature supported by sun6i MIPI DSI driver and
> > > where ?
> > > As there is no datasheet available, could you please help to support this
> > > feature (if not yet) ?
> > I haven't seen any panel that used it so far, so I have no idea.
> >
> > I guess this would be controlled through
> > SUN6I_DSI_BASIC_CTL0_HS_EOTP_EN in the driver.
>
> thanks for pointing this
>
> > > The second point is that the panel requires NON-BURST-WITH-SYNC-EVENTS mode.
> > > Could it be a problem with the current driver?
> > That should be supported in -next
>
> does your "should" mean "already supported" or "will be supported" ?

There's code to deal with burst mode but I just realised you wanted
non-burst. This was supported from day one, but we've landed some
quite important fixes that you might want to look at.

> I did a quick compare 4.20.15 with next and there is no difference in MIPI
> DSI driver code (apart from moving phy away).

Which tree have you compared 4.20 with?

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]