Re: [PATCH v5 1/2] media: uapi: Add H264 low-level decoder API compound controls.

From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Tomasz Figa <tfiga@chromium.org>
Cc: "list@263.net:IOMMU DRIVERS <iommu@lists.linux-foundation.org>,
	Joerg Roedel <joro@8bytes.org>,
	" <linux-arm-kernel@lists.infradead.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Alexandre Courbot <acourbot@chromium.org>,
	Jonas Karlman <jonas@kwiboo.se>,
	jenskuske@gmail.com, linux-sunxi@googlegroups.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Guenter Roeck <groeck@chromium.org>,
	Nicolas Dufresne <nicolas.dufresne@collabora.com>,
	Ezequiel Garcia <ezequiel@collabora.com>,
	Pawel Osciak <posciak@chromium.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH v5 1/2] media: uapi: Add H264 low-level decoder API compound controls.
Date: Wed, 13 Mar 2019 16:31:30 +0100	[thread overview]
Message-ID: <20190313153130.hnp5eybcgjm34i4n@flea> (raw)
In-Reply-To: <CAAFQd5AKXz5QmqnSEkChf8DqPkhEuUQg--q9dZKPmB1kBR1hzA@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1634 bytes --]

Hi Tomasz,

On Fri, Mar 08, 2019 at 03:12:18PM +0900, Tomasz Figa wrote:
> > +.. _v4l2-mpeg-h264:
> > +
> > +``V4L2_CID_MPEG_VIDEO_H264_SPS (struct)``
> > +    Specifies the sequence parameter set (as extracted from the
> > +    bitstream) for the associated H264 slice data. This includes the
> > +    necessary parameters for configuring a stateless hardware decoding
> > +    pipeline for H264.  The bitstream parameters are defined according
> > +    to :ref:`h264`. Unless there's a specific comment, refer to the
> > +    specification for the documentation of these fields, section 7.4.2.1.1
> > +    "Sequence Parameter Set Data Semantics".
> 
> I don't see this section being added by this patch. Where does it come from?

This is referring to the the H264 spec itself, as I was trying to
point out with the reference in that paragraph. How would you write
this down to make it more obvious?

> > +.. c:type:: v4l2_ctrl_h264_decode_param
> > +
> > +.. cssclass:: longtable
> > +
> > +.. flat-table:: struct v4l2_ctrl_h264_decode_param
> > +    :header-rows:  0
> > +    :stub-columns: 0
> > +    :widths:       1 1 2
> > +
> > +    * - __u32
> > +      - ``num_slices``
> > +      - Number of slices needed to decode the current frame
> > +    * - __u16
> > +      - ``idr_pic_flag``
> > +      - Is the picture an IDR picture?
> 
> Sounds like this could be made a flag to be consistent with how this
> kind of fields are represented in the other structs.

I'll change that, thanks!

Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel