From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0828CC43381 for ; Thu, 14 Mar 2019 11:28:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB47120854 for ; Thu, 14 Mar 2019 11:28:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AdlekEew"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="EUG+o/lQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB47120854 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xz0fub5bg6Sk1xUdsRzdJYlHVlr1UTbjDPOssEVuqTo=; b=AdlekEewz65hRm UxFEXlsBhyTI+kp6ZP5I+r+3mIaN7VUeBLtEGh7L1Xzr3WF60gGE3iTCi6MBDfnHyoq0ilboSmYJ0 KP2lMHC4qEZUSTRovA28PSQmyzIfVet1TRUTTKVVHYHdSP/NltsKctLsvLydnM497CUv6LaX/HfGY qp9BiBS4Tv44lUgAB/564HyMo1XVxZEHElY6gXTAdEHavovWsv0M7fiIWaFnAF1npKfy/vSUB1Szm pJ1N7hKD0LrFczAMUvWoDYOXlofvxX14GFq5/FqWzV5C7hi37eZuOJ0FY8zZrqVtQrIDqYQDCWA5/ K8ZgKChTg/H/x5VTmjfQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4OWk-00066y-5A; Thu, 14 Mar 2019 11:27:58 +0000 Received: from userp2130.oracle.com ([156.151.31.86]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4OWe-00065x-Qk; Thu, 14 Mar 2019 11:27:55 +0000 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2EBJK3S172818; Thu, 14 Mar 2019 11:27:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=Le8UAUdoSGnHWNDAHe9ATwLbJm9Dei1A3Ha7QuxbK94=; b=EUG+o/lQBPxq2OgkE5hvBu1uk97FwAs+0KYHBL7HjXcPd1TC2TSB9hhjJq4EXxQMgCoW EuLhdtOby/RXQkd1/yuPbrBp7w56SZ5hRKzffw04mbZm0rIZNIbYQs0gtNffQWlDCJsq apbCgZjWrUJX0fyU4aubHi7ywJZESrfAuG6elFzL3UFqp+wQ5JRfZb4XwWn7R+KWniaT ghTPej2oVPTR7FVxojyouTrn8U4vGqHH+qnjrctGO00HzEYC2oMzQHdrZ6r1iGT4aSIL 083n+IOy71rAj9voJiybURxPCXu3ADEwch3hJU3z3vmgeqUZUf229JOh4W1Q3KcXiUva uA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2r44wugcex-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Mar 2019 11:27:44 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x2EBRh2J007277 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Mar 2019 11:27:43 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x2EBRgfJ021577; Thu, 14 Mar 2019 11:27:42 GMT Received: from kadam (/197.157.0.16) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 14 Mar 2019 11:27:41 +0000 Date: Thu, 14 Mar 2019 14:27:32 +0300 From: Dan Carpenter To: Armando Miraglia , Jean Delvare Subject: Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c Message-ID: <20190314112732.GJ2227@kadam> References: <20190313122403.248873-1-armax@google.com> <20190313123454.GB2202@kadam> <20190314111313.GB8034@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190314111313.GB8034@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9194 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903140081 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190314_042752_999571_C196F7B6 X-CRM114-Status: GOOD ( 19.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, sankalpnegi2310@gmail.com, linux-kernel@vger.kernel.org, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, gregkh@linuxfoundation.org, neil@brown.name, sr@denx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 14, 2019 at 12:13:15PM +0100, Armando Miraglia wrote: > My answers are in-line below. BTW bare with me as this is my attempt to get my > feet wet in how to contribute to the linux kernel for my own pleasure and > interest :) > No problem at all. > Is there an explicit intent to deprecate Lindent in favor of checkpatch.pl > --fix? If one would like to contribute to fixing the tooling for linting which > of the two would be the right target for such an effort? > I've added Jean to the CC list because he worked on Lindent a few years ago. I really think we should just delete Lindent. I haven't used the checkpatch.pl --fix option but Joe Perches has good style. > > > static inline struct mt7621_spi *spidev_to_mt7621_spi(struct spi_device *spi) > > > @@ -303,7 +303,7 @@ static int mt7621_spi_setup(struct spi_device *spi) > > > struct mt7621_spi *rs = spidev_to_mt7621_spi(spi); > > > > > > if ((spi->max_speed_hz == 0) || > > > - (spi->max_speed_hz > (rs->sys_freq / 2))) > > > + (spi->max_speed_hz > (rs->sys_freq / 2))) > > > > Yeah. Lindent is correct here. > > Funny enough, this is something I adjusted manually :) > :) Good. > I have a process question here: to post a change for the only accepted change I > have in this patch should I send out a new patch? > Yeah. If you want. Google for how to send a v2 patch. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel