From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D24C43381 for ; Thu, 14 Mar 2019 15:50:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E3FE2184E for ; Thu, 14 Mar 2019 15:50:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nI5LNJts" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E3FE2184E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nr/VaUj0z5Z83H0Iuy1Ogf55E+WwkiqQbllL7gUDAzA=; b=nI5LNJts8T24/TwUsCR//fAnu F8EXtwMh/zQnSmITSCYc7/LzHJzrAIJx1ILXxS0afjAEtpCj/XuYaZDKWMiQG3FugS4nHicVB6G/J Z34Ek6RQF5GaGlHUZV4YAh0AC3PplSnkpb4vTA5yL1YkYKQVDgsISt8TmeFNv0i/ntwlhoCo+/7rw P7JISZoAx5bLSLCrNbS/aHNXmGGgbLu1qXo0pXEJGmw2j5B++EmR193wLYhVzVs2a3ROXZefG1Jut vXch2FEiPXQxdawEwuem0Z3nlBq9L2eLnF46i+FJUg+MtAlXV/LwtpRFiAcRAHRj4GyJCO79QZdfu keBHpSSYw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4Scl-0001Ue-5u; Thu, 14 Mar 2019 15:50:27 +0000 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4Sci-0001UI-T2 for linux-arm-kernel@lists.infradead.org; Thu, 14 Mar 2019 15:50:26 +0000 X-Originating-IP: 185.94.189.187 Received: from localhost (unknown [185.94.189.187]) (Authenticated sender: maxime.ripard@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 7B6541C000B; Thu, 14 Mar 2019 15:50:12 +0000 (UTC) Date: Thu, 14 Mar 2019 16:50:11 +0100 From: Maxime Ripard To: Paul Kocialkowski Subject: Re: [PATCH] ARM: dts: sun8i-h3: Add support for the RerVision H3-DVK board Message-ID: <20190314155011.znrhrxp6jyrxdodt@flea> References: <20190314130656.8010-1-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 In-Reply-To: <20190314130656.8010-1-paul.kocialkowski@bootlin.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190314_085025_240783_452B8951 X-CRM114-Status: GOOD ( 18.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Rob Herring , Thomas Petazzoni , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7916550318610617346==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7916550318610617346== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gkwgnztfmwdi3bs5" Content-Disposition: inline --gkwgnztfmwdi3bs5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 14, 2019 at 02:06:56PM +0100, Paul Kocialkowski wrote: > This is an H3-based board that sticks close to the reference design. >=20 > Supported features: > * UART > * DRAM > * MMC > * eMMC > * Ethernet > * USB host > * USB peripheral > * HDMI >=20 > Signed-off-by: Paul Kocialkowski > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/sun8i-h3-rervision-dvk.dts | 119 +++++++++++++++++++ > 2 files changed, 120 insertions(+) > create mode 100644 arch/arm/boot/dts/sun8i-h3-rervision-dvk.dts >=20 > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index bd40148a15b2..8db275b75214 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1078,6 +1078,7 @@ dtb-$(CONFIG_MACH_SUN8I) +=3D \ > sun8i-h3-orangepi-plus.dtb \ > sun8i-h3-orangepi-plus2e.dtb \ > sun8i-h3-orangepi-zero-plus2.dtb \ > + sun8i-h3-rervision-dvk.dtb \ > sun8i-r16-bananapi-m2m.dtb \ > sun8i-r16-nintendo-nes-classic.dtb \ > sun8i-r16-nintendo-super-nes-classic.dtb \ > diff --git a/arch/arm/boot/dts/sun8i-h3-rervision-dvk.dts b/arch/arm/boot= /dts/sun8i-h3-rervision-dvk.dts > new file mode 100644 > index 000000000000..94b71e064eb6 > --- /dev/null > +++ b/arch/arm/boot/dts/sun8i-h3-rervision-dvk.dts > @@ -0,0 +1,119 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (C) 2019 Bootlin > + * Author: Paul Kocialkowski > + */ > + > +/dts-v1/; > +#include "sun8i-h3.dtsi" > +#include "sunxi-common-regulators.dtsi" > + > +#include > +#include > + > +/ { > + model =3D "RerVision H3-DVK"; > + compatible =3D "rervision,h3-dvk", "allwinner,sun8i-h3"; > + > + aliases { > + ethernet0 =3D &emac; > + serial0 =3D &uart0; > + }; > + > + chosen { > + stdout-path =3D "serial0:115200n8"; > + }; > + > + connector { > + compatible =3D "hdmi-connector"; > + type =3D "a"; > + > + port { > + hdmi_connector_input: endpoint { > + remote-endpoint =3D <&hdmi_connector_output>; Those are pretty long labels, how would you feel about hdmi_con_in and hdmi_out_con, as we've used on all the other boards? > +&mmc2_8bit_pins { > + drive-strength =3D <40>; > + bias-pull-up; > +}; bias-pull-up is already set by default, and a 30mA drive strength should cover what the spec asks for. Did you encounter any issue with this? Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --gkwgnztfmwdi3bs5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXIp4MwAKCRDj7w1vZxhR xUGmAP9bda6GQ7eidD06h2KNY90UC3Gls/nX7OjeiHngEvp0aAD/bGJmEy8Wic9o 0M6IE88lOXzQtoP28M0j9Z2AQQbijQ0= =wDzW -----END PGP SIGNATURE----- --gkwgnztfmwdi3bs5-- --===============7916550318610617346== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7916550318610617346==--