From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42805C43381 for ; Fri, 15 Mar 2019 10:34:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12890218C3 for ; Fri, 15 Mar 2019 10:34:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mKuMrBcN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12890218C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WXOuB9IjLUyyJ8Fb9vC/c0GlxWMddMKLcIIwLZlOnFA=; b=mKuMrBcN7EO47y zH6ylBbLjisQ3myES8Z+VfNvDc0axa9sJKMLOi0Cjrstewo9I2EJ4HJdIKMO9FH0j9HHEpk/C/kPI c/C3KfHt9Xlq2sQuQ/9+ymK8+LF1tT0rUrwYAGyNcGqCCSIKDnfdTLzz8eTqpcU7nBCc3nA1rP/pC CKTw9cczTzjn+aH3VJiRN14w8Xi3S2zi7Ci/Pp2MRvCiMsx7swAu0+SBEvH9GMBIm4vFolF92Y1JK swDaIUTnU9MSfZ4XIaTVnCriAOF5s+q8XIkV4uS5pLrekagsIpc3HDrK4HII/EevNEBMKojfPBiss J2zvIPoNMfvgLfn/zG2w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4kAU-0005mU-2r; Fri, 15 Mar 2019 10:34:26 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4kAR-0005m5-6Y; Fri, 15 Mar 2019 10:34:24 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2019 03:34:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,481,1544515200"; d="scan'208";a="155309035" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 15 Mar 2019 03:34:18 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 15 Mar 2019 12:34:17 +0200 Date: Fri, 15 Mar 2019 12:34:17 +0200 From: Heikki Krogerus To: Chunfeng Yun Subject: Re: [PATCH v2 4/6] usb: roles: add API to get usb_role_switch by node Message-ID: <20190315103417.GH7752@kuha.fi.intel.com> References: <1552635513-2378-1-git-send-email-chunfeng.yun@mediatek.com> <1552635513-2378-5-git-send-email-chunfeng.yun@mediatek.com> <20190315081835.GD7752@kuha.fi.intel.com> <1552641204.10179.133.camel@mhfsdcap03> <20190315092644.GG7752@kuha.fi.intel.com> <1552642379.10179.138.camel@mhfsdcap03> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1552642379.10179.138.camel@mhfsdcap03> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190315_033423_251424_E7E31C21 X-CRM114-Status: GOOD ( 18.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Hans de Goede , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , Rob Herring , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 15, 2019 at 05:32:59PM +0800, Chunfeng Yun wrote: > Hi, > On Fri, 2019-03-15 at 11:26 +0200, Heikki Krogerus wrote: > > Hi Chunfeng, > > > > On Fri, Mar 15, 2019 at 05:13:24PM +0800, Chunfeng Yun wrote: > > > I encounter a build error when CONFIG_USB_ROLE_SWITCH is not enabled, > > > > > > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_role_sw_register': > > > ./drivers/usb/mtu3/mtu3_dr.c:460: undefined reference to > > > `usb_role_switch_register' > > > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_otg_switch_exit': > > > ./drivers/usb/mtu3/mtu3_dr.c:491: undefined reference to > > > `usb_role_switch_unregister' > > > > So you need to add dependency on USB_ROLE_SWITCH, right? > Yes > > > > > --- a/drivers/usb/mtu3/Kconfig > > +++ b/drivers/usb/mtu3/Kconfig > > @@ -43,6 +43,7 @@ config USB_MTU3_DUAL_ROLE > > bool "Dual Role mode" > > depends on ((USB=y || USB=USB_MTU3) && (USB_GADGET=y || USB_GADGET=USB_MTU3)) > > depends on (EXTCON=y || EXTCON=USB_MTU3) > > + depends on USB_ROLE_SWITCH > > help > > This is the default mode of working of MTU3 controller where > > both host and gadget features are enabled. > > > > > the following patch has fixed the issue, but seems not get into kernel, > > > [v3,08/12] usb: roles: Add usb role switch notifier. > > > https://patchwork.kernel.org/patch/10836525/ > > > > I don't understand how that fixes the problem? That patch will in any > > case be targeting v5.2. We are in the middle of merge window, so > > nothing is happening until v5.1-rc1 is tagged. > It provides some dummy inline functions when USB_ROLE_SWITCH is not > enabled, this will avoid build error Ah, true. Those should brobable be introduced in their own patch. thanks, -- heikki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel