From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20757C43381 for ; Fri, 15 Mar 2019 11:59:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E42C921872 for ; Fri, 15 Mar 2019 11:59:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="glpCkOlL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E42C921872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H6kVWADKX0W+FNokd9eLqjS+cz2AepO2Hv1o3sZVjeA=; b=glpCkOlLlqzKpwneTEdAqa0kx p3LXiDfDghgAFlv9FfLAWtTbSZ1peEtJojcu64RWHtFJXZiYw49lzI+Ii8aLB9xRHWMC/2kG9C7Nu DtJIzYyTFoHqH912MT047mAWrbVaCQL+KYC4kgMb3KptJyf6rfJU+Lk1NT7cGD2EaXsZ5VXYUqY2N NKpFawyU+Ti8ALwsYjqHKHvu9NVr/Jyo/dkMqXIpOg0aPj4IL79TSeMASfTsecCjwLsgVZqZTS1KK 56nB7GDeROlBGM8497+gdQuAcSBmpiH9DjAxgEMrilbm+8Km01fpbsdu4F1oxzDjpdgEHn9D14/hx oiArMW51w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4lUK-0003kU-NI; Fri, 15 Mar 2019 11:59:00 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4lUH-0003k8-PX for linux-arm-kernel@lists.infradead.org; Fri, 15 Mar 2019 11:58:59 +0000 Received: from localhost (aaubervilliers-681-1-80-102.w90-88.abo.wanadoo.fr [90.88.22.102]) (Authenticated sender: maxime.ripard@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 948F610000B; Fri, 15 Mar 2019 11:58:46 +0000 (UTC) Date: Fri, 15 Mar 2019 12:58:45 +0100 From: Maxime Ripard To: Chen-Yu Tsai Subject: Re: [PATCH v2 13/13] ARM: dts: sun9i: Add missing unit address Message-ID: <20190315115845.e2zorlyy54n5kc5r@flea> References: <463dbc60de944f4e0400dcdc190c983cf0d208e8.1552594551.git-series.maxime.ripard@bootlin.com> <20190315090216.qypb7tfquk5bfwth@flea> <20190315091636.b2skesvxtgqauanl@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190315_045858_133433_3838E8A8 X-CRM114-Status: GOOD ( 24.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , Maarten Lankhorst , linux-arm-kernel , dri-devel Content-Type: multipart/mixed; boundary="===============3302760260844076977==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3302760260844076977== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ohl2wruasge5dnd4" Content-Disposition: inline --ohl2wruasge5dnd4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 15, 2019 at 06:22:44PM +0800, Chen-Yu Tsai wrote: > On Fri, Mar 15, 2019 at 5:16 PM Maxime Ripard = wrote: > > > > On Fri, Mar 15, 2019 at 05:09:22PM +0800, Chen-Yu Tsai wrote: > > > On Fri, Mar 15, 2019 at 5:02 PM Maxime Ripard wrote: > > > > > > > > On Fri, Mar 15, 2019 at 10:39:24AM +0800, Chen-Yu Tsai wrote: > > > > > On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard wrote: > > > > > > > > > > > > The soc node in the A80 DTSI has a ranges property, but no matc= hing unit > > > > > > address, which results in a DTC warning. Add the unit address t= o remove > > > > > > that warning. > > > > > > > > > > > > Signed-off-by: Maxime Ripard > > > > > > --- > > > > > > arch/arm/boot/dts/sun9i-a80.dtsi | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/d= ts/sun9i-a80.dtsi > > > > > > index 9b15f272e5f5..7a495c84ab65 100644 > > > > > > --- a/arch/arm/boot/dts/sun9i-a80.dtsi > > > > > > +++ b/arch/arm/boot/dts/sun9i-a80.dtsi > > > > > > @@ -289,7 +289,7 @@ > > > > > > status =3D "disabled"; > > > > > > }; > > > > > > > > > > > > - soc { > > > > > > + soc@20000 { > > > > > > > > > > I thought we didn't like the soc node having an address? > > > > > > > > In general, yes, but in general we also don't have a ranges propert= y. > > > > > > > > > Maybe we just bite the bullet and use 64-bit addresses and sizes = for > > > > > the A80? > > > > > > > > I'd rather not, the current layout of the DT is pretty nice. > > > > > > > > But now I'm thinking, do you remember why we need to do that mapping > > > > in the first place? It's a 32bits SoCs, so why do we need to care > > > > about 64 bits addresses? > > > > > > It supports LPAE, addressing up to 8GB of RAM. Not that I've seen a > > > board sporting that much RAM though. Theobroma Systems might have > > > had such a board though, as their product page says "up to 8GB RAM". > > > > Ah, right. What should we do about this patch then? >=20 > I'm OK with it I suppose. AFAICT only sysfs paths and overlays (which sho= uld > use labels instead) are affected. We can always revert it if there's any fallouts, but we did it already on a number of other SoCs (well, the opposite actually, dropping the unit address), and it wasn't an issue. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ohl2wruasge5dnd4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXIuTdQAKCRDj7w1vZxhR xeFxAPwJ7ljnzIAQzzPxIQu/lCiiRvFEugDYV8/IAKxGCwOs+AEA6NHJIEakt96K DLDHi+Lb6ZE7MyRXvWERRDB0x3ftsgs= =Dsxt -----END PGP SIGNATURE----- --ohl2wruasge5dnd4-- --===============3302760260844076977== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3302760260844076977==--