From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Hans de Goede <hdegoede@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Badhri Jagan Sridharan <badhri@google.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Min Guo <min.guo@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
linux-arm-kernel@lists.infradead.org, Li Jun <jun.li@nxp.com>
Subject: Re: [PATCH v2 4/6] usb: roles: add API to get usb_role_switch by node
Date: Fri, 15 Mar 2019 13:58:54 +0200 [thread overview]
Message-ID: <20190315115854.GJ7752@kuha.fi.intel.com> (raw)
In-Reply-To: <1552641204.10179.133.camel@mhfsdcap03>
On Fri, Mar 15, 2019 at 05:13:24PM +0800, Chunfeng Yun wrote:
> I encounter a build error when CONFIG_USB_ROLE_SWITCH is not enabled,
>
> drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_role_sw_register':
> ./drivers/usb/mtu3/mtu3_dr.c:460: undefined reference to
> `usb_role_switch_register'
> drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_otg_switch_exit':
> ./drivers/usb/mtu3/mtu3_dr.c:491: undefined reference to
> `usb_role_switch_unregister'
>
> the following patch has fixed the issue, but seems not get into kernel,
> [v3,08/12] usb: roles: Add usb role switch notifier.
> https://patchwork.kernel.org/patch/10836525/
>
> What should I do if I add a new API? Thanks
So if you are asking should you supply dummy functions for the new API,
then I would just say that if you do so, you need to prepare these
patches on top of that series from Yu Chen. In general I'm not sure we
need dummy functions with this API.
Hans, comments?
thanks,
--
heikki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-15 11:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 7:38 [PATCH v2 0/6] add USB Type-B GPIO based role switch driver Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 1/6] dt-bindings: connector: add optional properties for Type-B Chunfeng Yun
2019-03-31 6:40 ` Rob Herring
2019-03-31 12:45 ` Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 2/6] dt-bindings: usb: add binding for Type-B dual role switch by GPIO Chunfeng Yun
2019-03-15 7:52 ` Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 4/6] usb: roles: add API to get usb_role_switch by node Chunfeng Yun
2019-03-15 8:18 ` Heikki Krogerus
2019-03-15 9:11 ` Heikki Krogerus
2019-03-15 9:14 ` Chunfeng Yun
2019-03-15 9:13 ` Chunfeng Yun
2019-03-15 9:26 ` Heikki Krogerus
2019-03-15 9:32 ` Chunfeng Yun
2019-03-15 10:34 ` Heikki Krogerus
2019-03-15 11:58 ` Heikki Krogerus [this message]
2019-03-15 7:38 ` [PATCH v2 5/6] usb: roles: add driver of USB Type-B role switch by GPIO Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 6/6] usb: mtu3: register a USB Role Switch for dual role mode Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315115854.GJ7752@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=andy.shevchenko@gmail.com \
--cc=badhri@google.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jun.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=min.guo@mediatek.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).