From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C436C10F00 for ; Mon, 18 Mar 2019 08:58:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A5642082F for ; Mon, 18 Mar 2019 08:58:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tMFBJMYv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A5642082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JdDgRnjn2BL+1e3WmrNA51zfYoi7FBoa1PSGL/Uu/hY=; b=tMFBJMYvd6BQI7h8XvTE1dx+E X3WcAgVGtVbyOeA/8RDfCBgSuKndqLiIwk0ca9nfbe22fwDNxpqRsQPGCoTG3/xiVpsIVudO5NVwK oxfnfj9u40yCb0surisll1/5R8dB0uQdgL7wi4Yr0XykaH4CNOiXV8FRXqiYheclskZiKG3xPpRUW aMt7EPe/SLeM/vx46WIm5XD3IxXCk9JvxDV/csbau+PcPAWkKRZ/iqg2mfWfsSv4MQvu5WorOU1+k G4j+aaaVcLMUf4w9PbW8yFuKKKOI1uFjZA0HVTByBMHyGTZ3Rbui5kx20mECm0wCrA8IOqiVGV+xn DzTp71bUQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5o5v-0004mr-QO; Mon, 18 Mar 2019 08:58:07 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5o5r-0004li-MF for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2019 08:58:05 +0000 X-Originating-IP: 90.88.22.102 Received: from localhost (aaubervilliers-681-1-80-102.w90-88.abo.wanadoo.fr [90.88.22.102]) (Authenticated sender: maxime.ripard@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id F1D48240003; Mon, 18 Mar 2019 08:57:51 +0000 (UTC) Date: Mon, 18 Mar 2019 09:57:51 +0100 From: Maxime Ripard To: Chen-Yu Tsai Subject: Re: [PATCH 4/6] nvmem: sunxi_sid: Read out data in native format Message-ID: <20190318085751.kziqzxnadtho4kdb@flea> References: <20190318073354.12151-1-wens@kernel.org> <20190318073354.12151-5-wens@kernel.org> <20190318084212.lv2lorskizl65uzg@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190318_015803_881604_811A2E2A X-CRM114-Status: GOOD ( 17.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-sunxi , Srinivas Kandagatla , linux-kernel , linux-arm-kernel Content-Type: multipart/mixed; boundary="===============3472537252496144944==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3472537252496144944== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="la2n7sufjnrgak3p" Content-Disposition: inline --la2n7sufjnrgak3p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 18, 2019 at 04:45:19PM +0800, Chen-Yu Tsai wrote: > On Mon, Mar 18, 2019 at 4:42 PM Maxime Ripard wrote: > > > > Hi, > > > > On Mon, Mar 18, 2019 at 03:33:52PM +0800, Chen-Yu Tsai wrote: > > > From: Chen-Yu Tsai > > > > > > Originally the SID e-fuses were thought to be in big-endian format. > > > Later sources show that they are in fact native or little-endian. > > > The most compelling evidence is the thermal sensor calibration data, > > > which is a set of one to three 16-bit values. In native-endian they > > > are in 16-bit cells with increasing offsets, whereas with big-endian > > > they are in the wrong order, and a gap with no data will show if there > > > are one or three cells. > > > > > > Switch to a native endian representation for the nvmem device. For the > > > H3, the register read-out method was already returning data in native > > > endian. This only affects the other SoCs. > > > > > > Signed-off-by: Chen-Yu Tsai > > > > I thought only the newer SoCs were impacted by this issue? > > It is noticable on the newer SoCs. The old ones only have the 128-bit SID, > which could be read either way, as AFAIK it's just a serial number. > > If you think we should leave the old ones alone I can factor that in. IIRC, there was also the SoC ID in the SID on those SoCs as well, which we might have to use in the future so we'll want to make sure it is correct. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --la2n7sufjnrgak3p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXI9djwAKCRDj7w1vZxhR xacmAP4xfPGpJtpCHJ0I2F8yxGCMGRneL3goh1L81MJkeHEBLAEAnmZ8MEF+36qZ 4iIBaJugFY1u2UhzN65t+mHMEi0+SwI= =bftt -----END PGP SIGNATURE----- --la2n7sufjnrgak3p-- --===============3472537252496144944== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3472537252496144944==--