From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBA6AC43381 for ; Mon, 18 Mar 2019 11:57:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD20F2084F for ; Mon, 18 Mar 2019 11:57:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Jf6DteN8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD20F2084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kJM6pS2sOOTYtYG64LZDgUm3BxxIcPYPzAj6HDlebFY=; b=Jf6DteN8xCUmpborQfHp2OSZ6 oP8t0fa2TpE+vxdwb3F0P86zPF4zuE/vVBTrNSc/8sR1rdvPko4QCxyrkLCkZN9vPvjh5vCZAvBrs mFFkUBJ40y1jeVE4mDO2RVmIUPnJbZFQxFd1zmyoJ7Jdv4JV6X/XPmamqU9QTyqF5+Oj4dX0EK4UY No+z+apsLZbxI1b/Y2p2gw+aUBSWTXBLwZUVacHzF7LXsuom++Qf0VdbQ9E8sqNfl9tiYfI8oRYGT PFJ/GBs1oM+67p1JiNKCOYNQ02tO74258bvlR+WyVila3W+bJtP0mroU5KmXZ2ru4UmOdM5MLv6th Fn1roJN0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5qti-0008Mc-DQ; Mon, 18 Mar 2019 11:57:42 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5qte-0008Ld-DE for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2019 11:57:40 +0000 X-Originating-IP: 90.88.22.102 Received: from localhost (aaubervilliers-681-1-80-102.w90-88.abo.wanadoo.fr [90.88.22.102]) (Authenticated sender: maxime.ripard@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 7368DC0006; Mon, 18 Mar 2019 11:57:34 +0000 (UTC) Date: Mon, 18 Mar 2019 12:57:33 +0100 From: Maxime Ripard To: Paul Kocialkowski Subject: Re: [linux-sunxi] Re: [PATCH 04/14] pinctrl: sunxi: v3: really introduce support for V3 Message-ID: <20190318115733.4onedngeaqbm4txp@flea> References: <20190312152256.35574-1-icenowy@aosc.io> <20190312152256.35574-5-icenowy@aosc.io> <20190312153654.25r5orlw7qjtlhbt@flea> <7B6C1341-BAB5-48C5-9E60-11BCEAC3D0CD@aosc.io> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190318_045738_753904_56C92C8B X-CRM114-Status: GOOD ( 23.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-sunxi@googlegroups.com, Rob Herring , Jagan Teki , Chen-Yu Tsai , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io Content-Type: multipart/mixed; boundary="===============4355976456254341903==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4355976456254341903== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kfiqbz764gzlm462" Content-Disposition: inline --kfiqbz764gzlm462 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 18, 2019 at 12:05:12PM +0100, Paul Kocialkowski wrote: > Hi, > > Le mardi 12 mars 2019 =C3=A0 23:45 +0800, Icenowy Zheng a =C3=A9crit : > > > > =E4=BA=8E 2019=E5=B9=B43=E6=9C=8812=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D= =8811:36:54, Maxime Ripard =E5=86=99=E5=88=B0: > > > On Tue, Mar 12, 2019 at 11:22:46PM +0800, Icenowy Zheng wrote: > > > > Introduce the GPIO pins that is only available on V3 (not on V3s) to > > > the > > > > V3 pinctrl driver. > > > > > > > > Signed-off-by: Icenowy Zheng > > > > --- > > > > drivers/pinctrl/sunxi/pinctrl-sun8i-v3.c | 291 > > > +++++++++++++++++++++-- > > > > drivers/pinctrl/sunxi/pinctrl-sunxi.h | 2 + > > > > 2 files changed, 275 insertions(+), 18 deletions(-) > > > > > > > > diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-v3.c > > > b/drivers/pinctrl/sunxi/pinctrl-sun8i-v3.c > > > > index 6704ce8e5e3d..54c210871a95 100644 > > > > --- a/drivers/pinctrl/sunxi/pinctrl-sun8i-v3.c > > > > +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-v3.c > > > > @@ -1,5 +1,5 @@ > > > > /* > > > > - * Allwinner V3s SoCs pinctrl driver. > > > > + * Allwinner V3/V3s SoCs pinctrl driver. > > > > * > > > > * Copyright (C) 2016 Icenowy Zheng > > > > * > > > > @@ -23,7 +23,7 @@ > > > > > > > > #include "pinctrl-sunxi.h" > > > > > > > > -static const struct sunxi_desc_pin sun8i_v3s_pins[] =3D { > > > > +static const struct sunxi_desc_pin sun8i_v3_v3s_pins[] =3D { > > > > > > I'm not sure all that remaining is worth it to be honest. It adds a > > > lot of noise for no particular reason (and the same goes for renaming > > > the file itself) > > > > Maybe keeping names is okay "for historial reasons". > > > > In fact I want to keep them. > > My two cents about this: kernel development is plagued by the unability > to rename and rework things as soon as backward compatibility is > involved. I believe that renaming and reworking things is quite a good > thing to do when it leads to a situation that is easier to understand > and makes more sense. > > In this case, I don't see any blockers that would prevent us from doing > this, so I am strongly in favor of it. I really don't see how increased > noise and "historical reasons" make up for better clarity. It simplifies the git history, for once, which has the side effect of reducing conflicts too. A second one is: Do you prefer to review patches that have some significant value (like a new feature, a bugfix, a new SoC support, etc) or one that renames files and / or symbols? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --kfiqbz764gzlm462 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXI+HnwAKCRDj7w1vZxhR xfbaAP4tTPJsX9kjGgO2E96g98P/Y+TcQb27RkXk4LjnteSexAEAw1P3kGgeQQ04 LmZksUSSEkd+Gy4cLhehmv11w/aPWAo= =CCMo -----END PGP SIGNATURE----- --kfiqbz764gzlm462-- --===============4355976456254341903== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4355976456254341903==--