From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel@ffwll.ch>,
arm-linux <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH] drm/sun4i: Implement gamma correction
Date: Mon, 18 Mar 2019 13:20:03 +0100 [thread overview]
Message-ID: <20190318122003.yyxxo2khyde3uvax@flea> (raw)
In-Reply-To: <CA+E=qVfoK9u9z3T=dBwF03rfUryqnnSb9JriYgFTjXju1sW-3A@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1103 bytes --]
Hi,
On Thu, Mar 14, 2019 at 10:54:26AM -0700, Vasily Khoruzhick wrote:
> On Thu, Mar 14, 2019 at 8:42 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > Hi Vasily,
> >
> > On Wed, Mar 13, 2019 at 07:58:38PM -0700, Vasily Khoruzhick wrote:
> > > Add support for gamma corretion to sun4i TCON driver. Its LUT has 256
> > > entries and can be updated only when gamma correction is disabled.
> > >
> > > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> >
> > It's not really clear to me what you expect a comment on?
>
> I'm not sure that I put gamma correction into right place - gamma lut
> seems to be a property of CRTC, but registers are in TCON module.
The TCON loosely maps to the CRTC, so that's ok.
> Also I'm not sure if gamma correction is supported across all
> Allwinner SoCs - if it doesn't, how do we handle this?
I don't really know if that's supported on all of them, but the way to
handle this would be to associate it with the compatible and add a
quirk if that's relevant.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-03-18 12:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 2:58 [RFC PATCH] drm/sun4i: Implement gamma correction Vasily Khoruzhick
2019-03-14 15:42 ` Maxime Ripard
2019-03-14 17:54 ` Vasily Khoruzhick
2019-03-18 12:20 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318122003.yyxxo2khyde3uvax@flea \
--to=maxime.ripard@bootlin.com \
--cc=airlied@linux.ie \
--cc=anarsoul@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).