From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A863DC43381 for ; Mon, 18 Mar 2019 12:20:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A57420854 for ; Mon, 18 Mar 2019 12:20:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V9DNkMJ3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A57420854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dTMYT52z2U4MbjP0aznJFMNbe+WYfNiyUam+6HF5XzE=; b=V9DNkMJ3EhFhSU6uGvOyg91J7 BsNk2KGASbOiubUBaQM7V6qm05+AmXELMY425A/0JUedt56c3VrtXz48ugyWjawHeq2mgoIS4e8ps BBQI7Cmj9Y6HArw1dKwJXdrczG5vI0dO8ZtpIJv4k4278E4B6vDDrSPHTmM/y/OiUlqpOCICXVGjZ 2Zp9iRVy37AlJqyeBDuTy4AjaxAQlyw9kDrbey9c21Il7EFqBKSTcDnX4851F3qCF5HJIfR/+rclS ey2BsLuzgyjb0dFmVW+b5VgfibsXA9zRUugZPgE4DnZm1yeJbwBNU7cBtuxE4NSr7FeHAas26PsYG v+b9cxl+g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5rFZ-0003M5-Ie; Mon, 18 Mar 2019 12:20:17 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5rFW-0003L5-HK for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2019 12:20:16 +0000 X-Originating-IP: 90.88.22.102 Received: from localhost (aaubervilliers-681-1-80-102.w90-88.abo.wanadoo.fr [90.88.22.102]) (Authenticated sender: maxime.ripard@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id E957BFF802; Mon, 18 Mar 2019 12:20:03 +0000 (UTC) Date: Mon, 18 Mar 2019 13:20:03 +0100 From: Maxime Ripard To: Vasily Khoruzhick Subject: Re: [RFC PATCH] drm/sun4i: Implement gamma correction Message-ID: <20190318122003.yyxxo2khyde3uvax@flea> References: <20190314025838.5867-1-anarsoul@gmail.com> <20190314154203.7fixwajcplie5l3j@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190318_052014_729216_611A4994 X-CRM114-Status: GOOD ( 14.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Chen-Yu Tsai , dri-devel , Daniel Vetter , arm-linux Content-Type: multipart/mixed; boundary="===============8768606725908590798==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8768606725908590798== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="unmgpp7gijcisay6" Content-Disposition: inline --unmgpp7gijcisay6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Thu, Mar 14, 2019 at 10:54:26AM -0700, Vasily Khoruzhick wrote: > On Thu, Mar 14, 2019 at 8:42 AM Maxime Ripard wrote: > > > > Hi Vasily, > > > > On Wed, Mar 13, 2019 at 07:58:38PM -0700, Vasily Khoruzhick wrote: > > > Add support for gamma corretion to sun4i TCON driver. Its LUT has 256 > > > entries and can be updated only when gamma correction is disabled. > > > > > > Signed-off-by: Vasily Khoruzhick > > > > It's not really clear to me what you expect a comment on? > > I'm not sure that I put gamma correction into right place - gamma lut > seems to be a property of CRTC, but registers are in TCON module. The TCON loosely maps to the CRTC, so that's ok. > Also I'm not sure if gamma correction is supported across all > Allwinner SoCs - if it doesn't, how do we handle this? I don't really know if that's supported on all of them, but the way to handle this would be to associate it with the compatible and add a quirk if that's relevant. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --unmgpp7gijcisay6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXI+M8wAKCRDj7w1vZxhR xT+wAQDe0QTMJvNOVnO9/VE/09yMrKTnvtisKdA1epzJ+4xzLwD/Tw5PEiQTSGAh zniXwV6vl8alV3vRbpnV30Ta5fNgLQE= =x5xf -----END PGP SIGNATURE----- --unmgpp7gijcisay6-- --===============8768606725908590798== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8768606725908590798==--